callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add some comments to gtk_tree_model_filter_remove_elt_from_level

Browse Source
This commit is contained in:
Kristian Rietveld
2011-05-22 18:40:21 +02:00
parent e89782742d
commit a485334c37
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gtk/gtktreemodelfilter.c
View File

@ -1230,6 +1230,12 @@ gtk_tree_model_filter_fetch_child (GtkTreeModelFilter *filter,
index); index);
} }
/* Note that this function is never called from the row-deleted handler.
* This means that this function is only used for removing elements
* which are still present in the child model. As a result, we must
* take care to properly release the references the filter model has
* on the child model nodes.
*/
static void static void
gtk_tree_model_filter_remove_elt_from_level (GtkTreeModelFilter *filter, gtk_tree_model_filter_remove_elt_from_level (GtkTreeModelFilter *filter,
FilterLevel *level, FilterLevel *level,
@ -1297,6 +1303,9 @@ gtk_tree_model_filter_remove_elt_from_level (GtkTreeModelFilter *filter,
gtk_tree_model_filter_real_unref_node (GTK_TREE_MODEL (filter), gtk_tree_model_filter_real_unref_node (GTK_TREE_MODEL (filter),
&iter, FALSE); &iter, FALSE);
/* We must account for the filter model's reference, because the
* node is still present in the child model.
*/
if (parent_level || filter->priv->virtual_root) if (parent_level || filter->priv->virtual_root)
gtk_tree_model_filter_unref_node (GTK_TREE_MODEL (filter), &iter); gtk_tree_model_filter_unref_node (GTK_TREE_MODEL (filter), &iter);
else if (elt->ref_count > 0) else if (elt->ref_count > 0)
@ -1346,6 +1355,10 @@ gtk_tree_model_filter_remove_elt_from_level (GtkTreeModelFilter *filter,
iter.stamp = filter->priv->stamp; iter.stamp = filter->priv->stamp;
gtk_tree_model_row_deleted (GTK_TREE_MODEL (filter), path); gtk_tree_model_row_deleted (GTK_TREE_MODEL (filter), path);
/* We must account for the filter model's reference (released
* in gtk_tree_model_filter_free_level), because the node is
* still present in the child model.
*/
while (elt->ref_count > 1) while (elt->ref_count > 1)
gtk_tree_model_filter_real_unref_node (GTK_TREE_MODEL (filter), gtk_tree_model_filter_real_unref_node (GTK_TREE_MODEL (filter),
&iter, FALSE); &iter, FALSE);