callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gdk/wayland: Harden against NULL selection content

Browse Source 
If NULL is returned, probably the client shouldn't advertise the
mimetype. Make it sure we forget entirely about the attempt to
cache this mimetype, as it'll be mistaken as pending otherwise.

Dropping this cached selection will in consequence close the fd
of all pending readers, which seems appropriate for NULL content.

https://gitlab.gnome.org/GNOME/gtk/issues/2456
This commit is contained in:
Carlos Garnacho 2020-02-20 11:36:51 +01:00
parent 6893118510
commit a097ca0906
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gdk/wayland/gdkselection-wayland.c
View File

@ -860,7 +860,14 @@ gdk_wayland_selection_store (GdkWindow *window,
}
stored_selection_add_data (stored_selection, mode, data, len);
stored_selection_notify_write (stored_selection);
if (stored_selection->data)
stored_selection_notify_write (stored_selection);
else
{
g_ptr_array_remove_fast (selection->stored_selections,
stored_selection);
}
/* Handle the next GDK_SELECTION_REQUEST / store, if any */
selection->current_request_selection = GDK_NONE;