callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gtk: Don't call gdk_window_process_updates() when scrolling

Browse Source 
This can cause lagging when scrolling as it causes us to repaint
on every scroll event. This wasn't historically a great problem,
but with smooth scrolling we get a lot more events, so this
now creates visible lagging on slower machines.
This commit is contained in:
Benjamin Otte
2012-04-05 15:48:51 +02:00
committed by Alexander Larsson
parent d55961adf9
commit 917ca6a802
7 changed files with 1 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
gtk/gtkrange.c
View File

@ -116,8 +116,6 @@ struct _GtkRangePrivate
gint slider_start; /* Slider range along the long dimension, in widget->window coords */
gint slider_end;
guint repaint_id;
/* Steppers are: < > ---- < >
* a b c d
*/
@ -1499,10 +1497,6 @@ gtk_range_destroy (GtkWidget *widget)
gtk_range_remove_step_timer (range);
if (priv->repaint_id)
g_source_remove (priv->repaint_id);
priv->repaint_id = 0;
if (priv->adjustment)
{
g_signal_handlers_disconnect_by_func (priv->adjustment,
@ -2034,11 +2028,6 @@ gtk_range_draw (GtkWidget *widget,
"focus-padding", &focus_padding,
NULL);
/* we're now exposing, so there's no need to force early repaints */
if (priv->repaint_id)
g_source_remove (priv->repaint_id);
priv->repaint_id = 0;
gtk_range_calc_marks (range);
gtk_range_calc_layout (range, gtk_adjustment_get_value (priv->adjustment));
@ -2984,20 +2973,6 @@ gtk_range_adjustment_changed (GtkAdjustment *adjustment,
*/
}
static gboolean
force_repaint (gpointer data)
{
GtkRange *range = GTK_RANGE (data);
GtkRangePrivate *priv = range->priv;
GtkWidget *widget = GTK_WIDGET (range);
priv->repaint_id = 0;
if (gtk_widget_is_drawable (widget))
gdk_window_process_updates (gtk_widget_get_window (widget), FALSE);
return FALSE;
}
static void
gtk_range_adjustment_value_changed (GtkAdjustment *adjustment,
gpointer data)
@ -3014,11 +2989,6 @@ gtk_range_adjustment_value_changed (GtkAdjustment *adjustment,
(GTK_IS_SCALE (range) && gtk_scale_get_draw_value (GTK_SCALE (range))))
{
gtk_widget_queue_draw (GTK_WIDGET (range));
/* setup a timer to ensure the range isn't lagging too much behind the scroll position */
if (!priv->repaint_id)
priv->repaint_id = gdk_threads_add_timeout_full (GDK_PRIORITY_EVENTS,
181, force_repaint,
range, NULL);
}
/* Note that we don't round off to priv->round_digits here.