callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

window: Warn when gtk_window_present_with_time() is passed 0

Browse Source 
When 0 or GDK_CURRENT_TIME is passed to gtk_window_present_with_time(),
print a warning so that the application developer knows that this isn't
a supported use of the function, but carry on working for now.
This commit is contained in:
Bastien Nocera 2018-07-25 17:43:02 +02:00 committed by Matthias Clasen
parent 5d7183ee0c
commit 8ed0471785
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gtk/gtkwindow.c
View File

@ -10529,6 +10529,7 @@ gtk_window_present_with_time (GtkWindow *window,
GtkWindowPrivate *priv; GtkWindowPrivate *priv;
GtkWidget *widget; GtkWidget *widget;
GdkWindow *gdk_window; GdkWindow *gdk_window;
static gsize warned_current_time = FALSE;
g_return_if_fail (GTK_IS_WINDOW (window)); g_return_if_fail (GTK_IS_WINDOW (window));
@ -10546,6 +10547,15 @@ gtk_window_present_with_time (GtkWindow *window,
/* Translate a timestamp of GDK_CURRENT_TIME appropriately */ /* Translate a timestamp of GDK_CURRENT_TIME appropriately */
if (timestamp == GDK_CURRENT_TIME) if (timestamp == GDK_CURRENT_TIME)
{ {
if (g_once_init_enter (&warned_current_time))
{
gboolean warned = TRUE;
g_warning ("gtk_window_present_with_time() should not be called with 0, or "
"GDK_CURRENT_TIME as a timestamp, the timestamp should instead be "
"gathered at the time the user initiated the request for the window "
"to be shown");
g_once_init_leave (&warned_current_time, warned);
}
#ifdef GDK_WINDOWING_X11 #ifdef GDK_WINDOWING_X11
if (GDK_IS_X11_WINDOW(gdk_window)) if (GDK_IS_X11_WINDOW(gdk_window))
{ {