callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Range: Bin pointless check before emitting signal

Browse Source 
In scroll_event(), there is no need to check whether we are realized
before emitting ::change-value, as we must be when receiving an event.

Git-formatted/rebased/cleaned up by Daniel Boles <dboles.src@gmail.com>

Close https://gitlab.gnome.org/GNOME/gtk/issues/292
This commit is contained in:
Björn Lindqvist 2008-03-24 21:31:22 +00:00 committed by Daniel Boles
parent 96774e8b5c
commit 893fc1dec4
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gtk/gtkrange.c
View File

@ -3107,18 +3107,12 @@ gtk_range_scroll_event (GtkWidget *widget,
{ {
GtkRange *range = GTK_RANGE (widget); GtkRange *range = GTK_RANGE (widget);
GtkRangePrivate *priv = range->priv; GtkRangePrivate *priv = range->priv;
double delta = _gtk_range_get_wheel_delta (range, event);
gboolean handled;
if (gtk_widget_get_realized (widget)) g_signal_emit (range, signals[CHANGE_VALUE], 0,
{ GTK_SCROLL_JUMP, gtk_adjustment_get_value (priv->adjustment) + delta,
gdouble delta; &handled);
gboolean handled;
delta = _gtk_range_get_wheel_delta (range, event);
g_signal_emit (range, signals[CHANGE_VALUE], 0,
GTK_SCROLL_JUMP, gtk_adjustment_get_value (priv->adjustment) + delta,
&handled);
}
return GDK_EVENT_STOP; return GDK_EVENT_STOP;
} }