callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use g_signal_connect_object for adjustments in GtkSpinButtonAccessible

Browse Source 
An instance of GtkAdjustment may be used by another instance after
the spin button widget is destroyed. In that case, the function
gtk_spin_button_accessible_value_changed() will be called with an
invalid argument. This situation is often caused when one use
GtkCellRendererSpin widget. To avoid invalid call of the function,
the signal handler for the "value-changed" signal should be disconnected
when the spin-button widget is destroyed.
Using g_signal_connect_object achieves just that.
https://bugzilla.gnome.org/show_bug.cgi?id=691592
This commit is contained in:
Matthias Clasen
2013-01-20 22:16:47 -05:00
parent cbce906228
commit 88ed5af5e4
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gtk/a11y/gtkspinbuttonaccessible.c
View File

@ -51,10 +51,10 @@ gtk_spin_button_accessible_initialize (AtkObject *obj,
adjustment = gtk_spin_button_get_adjustment (GTK_SPIN_BUTTON (data)); adjustment = gtk_spin_button_get_adjustment (GTK_SPIN_BUTTON (data));
if (adjustment) if (adjustment)
g_signal_connect (adjustment, g_signal_connect_object (adjustment,
"value-changed", "value-changed",
G_CALLBACK (gtk_spin_button_accessible_value_changed), G_CALLBACK (gtk_spin_button_accessible_value_changed),
obj); obj, 0);
obj->role = ATK_ROLE_SPIN_BUTTON; obj->role = ATK_ROLE_SPIN_BUTTON;
} }
@ -71,9 +71,9 @@ gtk_spin_button_accessible_notify_gtk (GObject *obj,
GtkAdjustment* adjustment; GtkAdjustment* adjustment;
adjustment = gtk_spin_button_get_adjustment (GTK_SPIN_BUTTON (widget)); adjustment = gtk_spin_button_get_adjustment (GTK_SPIN_BUTTON (widget));
g_signal_connect (adjustment, "value-changed", g_signal_connect_object (adjustment, "value-changed",
G_CALLBACK (gtk_spin_button_accessible_value_changed), G_CALLBACK (gtk_spin_button_accessible_value_changed),
spin_button); spin_button, 0);
} }
else else
GTK_WIDGET_ACCESSIBLE_CLASS (gtk_spin_button_accessible_parent_class)->notify_gtk (obj, pspec); GTK_WIDGET_ACCESSIBLE_CLASS (gtk_spin_button_accessible_parent_class)->notify_gtk (obj, pspec);