callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gkimmulticontext: Fix crash due to leaked signal handler

Browse Source 
The problem is caused by gtk_im_multicontext_set_slave(), which forgets
to disconnect these signal handlers:
* gtk_im_multicontext_retrieve_surrounding_cb
* gtk_im_multicontext_delete_surrounding_cb

If slave GtkImContext emits signal after GtkIMMulticontext context is
destroyed, this leads to reading freed memory, sometimes causing a crash.

Fixes: #2365
This commit is contained in:
Alexandr Miloslavskiy 2019-12-17 12:44:33 +01:00
parent fcc72575a2
commit 822705fe3e
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gtk/gtkimmulticontext.c
View File

@ -193,6 +193,12 @@ gtk_im_multicontext_set_slave (GtkIMMulticontext *multicontext,
g_signal_handlers_disconnect_by_func (priv->slave, g_signal_handlers_disconnect_by_func (priv->slave,
gtk_im_multicontext_commit_cb, gtk_im_multicontext_commit_cb,
multicontext); multicontext);
g_signal_handlers_disconnect_by_func (priv->slave,
gtk_im_multicontext_retrieve_surrounding_cb,
multicontext);
g_signal_handlers_disconnect_by_func (priv->slave,
gtk_im_multicontext_delete_surrounding_cb,
multicontext);
g_object_unref (priv->slave); g_object_unref (priv->slave);
priv->slave = NULL; priv->slave = NULL;