callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

themingengine: simplify render_extension() default implementation

Browse Source 
Avoid doing useless translations/rotations, since themes will most
likely set different CSS gradients using left/right/top/bottom style
classes, or use a plain color.

https://bugzilla.gnome.org/show_bug.cgi?id=674809
This commit is contained in:
Cosimo Cecchi
2012-04-24 20:22:24 -04:00
parent d12fd1435a
commit 7e917e54a3
1 changed files with 4 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
gtk/gtkthemingengine.c
View File

@ -2296,62 +2296,35 @@ gtk_theming_engine_render_extension (GtkThemingEngine *engine,
GtkJunctionSides junction = 0; GtkJunctionSides junction = 0;
guint hidden_side = 0; guint hidden_side = 0;
cairo_save (cr);
switch (gap_side) switch (gap_side)
{ {
case GTK_POS_LEFT: case GTK_POS_LEFT:
junction = GTK_JUNCTION_LEFT; junction = GTK_JUNCTION_LEFT;
hidden_side = (1 << GTK_CSS_LEFT); hidden_side = (1 << GTK_CSS_LEFT);
cairo_translate (cr, x + width, y);
cairo_rotate (cr, G_PI / 2);
break; break;
case GTK_POS_RIGHT: case GTK_POS_RIGHT:
junction = GTK_JUNCTION_RIGHT; junction = GTK_JUNCTION_RIGHT;
hidden_side = (1 << GTK_CSS_RIGHT); hidden_side = (1 << GTK_CSS_RIGHT);
cairo_translate (cr, x, y + height);
cairo_rotate (cr, - G_PI / 2);
break; break;
case GTK_POS_TOP: case GTK_POS_TOP:
junction = GTK_JUNCTION_TOP; junction = GTK_JUNCTION_TOP;
hidden_side = (1 << GTK_CSS_TOP); hidden_side = (1 << GTK_CSS_TOP);
cairo_translate (cr, x + width, y + height);
cairo_rotate (cr, G_PI);
break; break;
case GTK_POS_BOTTOM: case GTK_POS_BOTTOM:
junction = GTK_JUNCTION_BOTTOM; junction = GTK_JUNCTION_BOTTOM;
hidden_side = (1 << GTK_CSS_BOTTOM); hidden_side = (1 << GTK_CSS_BOTTOM);
cairo_translate (cr, x, y);
break; break;
} }
if (gap_side == GTK_POS_TOP || _gtk_theming_background_init (&bg, engine,
gap_side == GTK_POS_BOTTOM) x, y,
_gtk_theming_background_init (&bg, engine, width, height,
0, 0, junction);
width, height,
GTK_JUNCTION_BOTTOM);
else
_gtk_theming_background_init (&bg, engine,
0, 0,
height, width,
GTK_JUNCTION_BOTTOM);
_gtk_theming_background_render (&bg, cr); _gtk_theming_background_render (&bg, cr);
cairo_restore (cr);
cairo_save (cr);
render_frame_internal (engine, cr, render_frame_internal (engine, cr,
x, y, width, height, x, y, width, height,
hidden_side, junction); hidden_side, junction);
cairo_restore (cr);
} }
static void static void