callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gtkcssprovider: Use g_slice_dup() to copy GValues around

Browse Source 
GValues stored in GtkCssRulesets are gslice managed, so don't
g_memdup() GValues from shorthand properties. This fixes
memory corruptions when reloading contents in a GtkCssProvider.
This commit is contained in:
Carlos Garnacho
2011-05-30 19:04:22 +02:00
parent 7a730ae213
commit 747dc65c2c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gtk/gtkcssprovider.c
View File

@ -1086,9 +1086,9 @@ gtk_css_ruleset_add (GtkCssRuleset *ruleset,
{ {
const GtkStyleProperty *child; const GtkStyleProperty *child;
GValue *value; GValue *value;
child = _gtk_style_property_lookup (parameters[i].name); child = _gtk_style_property_lookup (parameters[i].name);
value = g_memdup (&parameters[i].value, sizeof (GValue)); value = g_slice_dup (GValue, &parameters[i].value);
gtk_css_ruleset_add (ruleset, child, value); gtk_css_ruleset_add (ruleset, child, value);
} }
g_free (parameters); g_free (parameters);