callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GtkMenuTrackerItem: Plug a memory leak

Browse Source 
gtk_menu_tracker_get_[verb_]icon both return a reference,
so don't use g_value_set_object, which adds another one.
This commit is contained in:
Matthias Clasen
2014-06-28 22:39:43 -04:00
parent d143919527
commit 6f0951845f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/gtkmenutrackeritem.c
View File

@ -164,10 +164,10 @@ gtk_menu_tracker_item_get_property (GObject *object,
g_value_set_string (value, gtk_menu_tracker_item_get_label (self)); g_value_set_string (value, gtk_menu_tracker_item_get_label (self));
break; break;
case PROP_ICON: case PROP_ICON:
g_value_set_object (value, gtk_menu_tracker_item_get_icon (self)); g_value_take_object (value, gtk_menu_tracker_item_get_icon (self));
break; break;
case PROP_VERB_ICON: case PROP_VERB_ICON:
g_value_set_object (value, gtk_menu_tracker_item_get_verb_icon (self)); g_value_take_object (value, gtk_menu_tracker_item_get_verb_icon (self));
break; break;
case PROP_SENSITIVE: case PROP_SENSITIVE:
g_value_set_boolean (value, gtk_menu_tracker_item_get_sensitive (self)); g_value_set_boolean (value, gtk_menu_tracker_item_get_sensitive (self));
@ -199,6 +199,7 @@ gtk_menu_tracker_item_finalize (GObject *object)
GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (object); GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (object);
g_free (self->action_namespace); g_free (self->action_namespace);
g_free (self->action_and_target);
if (self->observable) if (self->observable)
g_object_unref (self->observable); g_object_unref (self->observable);