callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stack: skip first frame for animations

Browse Source 
Not the ideal solution for this problem, but in practice leads to
much better performance on lower end hardware.

Stack does a double draw on the first frame of its animation, of
both the old contents (into a cairo surface) and the new contents.
Homogeneous stacks only need to reallocate contents on the first
frame.

On lower powered hardware where our frames will be a good deal
slower than the refresh rate anyway, we can assure a smother
experience by waiting a frame to start tweening where frame duration
will be more consistent.
This commit is contained in:
Matt Watson 2016-03-01 17:19:50 -08:00
parent 3909f818c4
commit 62b224a8df
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/gtkstack.c
View File

@ -146,6 +146,7 @@ typedef struct {
GtkAllocation last_visible_surface_allocation; GtkAllocation last_visible_surface_allocation;
guint tick_id; guint tick_id;
GtkProgressTracker tracker; GtkProgressTracker tracker;
gboolean first_frame_skipped;
gint last_visible_widget_width; gint last_visible_widget_width;
gint last_visible_widget_height; gint last_visible_widget_height;
@ -924,8 +925,11 @@ gtk_stack_transition_cb (GtkWidget *widget,
GtkStack *stack = GTK_STACK (widget); GtkStack *stack = GTK_STACK (widget);
GtkStackPrivate *priv = gtk_stack_get_instance_private (stack); GtkStackPrivate *priv = gtk_stack_get_instance_private (stack);
if (priv->first_frame_skipped)
gtk_progress_tracker_advance_frame (&priv->tracker, gtk_progress_tracker_advance_frame (&priv->tracker,
gdk_frame_clock_get_frame_time (frame_clock)); gdk_frame_clock_get_frame_time (frame_clock));
else
priv->first_frame_skipped = TRUE;
/* Finish animation early if not mapped anymore */ /* Finish animation early if not mapped anymore */
if (!gtk_widget_get_mapped (widget)) if (!gtk_widget_get_mapped (widget))
@ -1017,6 +1021,7 @@ gtk_stack_start_transition (GtkStack *stack,
priv->last_visible_child != NULL) priv->last_visible_child != NULL)
{ {
priv->active_transition_type = effective_transition_type (stack, transition_type); priv->active_transition_type = effective_transition_type (stack, transition_type);
priv->first_frame_skipped = FALSE;
gtk_stack_schedule_ticks (stack); gtk_stack_schedule_ticks (stack);
gtk_progress_tracker_start (&priv->tracker, gtk_progress_tracker_start (&priv->tracker,
priv->transition_duration * 1000, priv->transition_duration * 1000,