From 5e6293e54f9d807869835dfbb8814819e1449401 Mon Sep 17 00:00:00 2001 From: Daniel Boles Date: Tue, 1 Aug 2017 19:31:20 +0100 Subject: [PATCH] cssbordervalue: Fix possible use of uninitialised If value->values[i] is NULL, then values[i] was left uninitialised. The code then reads each element of values[]. CID 1432029 (#1 of 1): Uninitialized pointer read (UNINIT) 11. uninit_use: Using uninitialized value values[i]. --- gtk/gtkcssbordervalue.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gtk/gtkcssbordervalue.c b/gtk/gtkcssbordervalue.c index 5140057289..d95196ca02 100644 --- a/gtk/gtkcssbordervalue.c +++ b/gtk/gtkcssbordervalue.c @@ -60,6 +60,10 @@ gtk_css_value_border_compute (GtkCssValue *value, values[i] = _gtk_css_value_compute (value->values[i], property_id, provider, style, parent_style); changed |= (values[i] != value->values[i]); } + else + { + values[i] = NULL; + } } if (!changed)