From 465d4be3cf52dba4c4da98bfcba72a543a11ff1f Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 19 Dec 2013 11:22:02 -0500 Subject: [PATCH] GtkPlacesSidebar: Don't show desktop if its home We go to extra length to set the desktop_uri to NULL when desktop == home, but then we were adding the (non-functional) place item anyway. Don't do that. --- gtk/gtkplacessidebar.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c index 979700fb98..9562dd8e76 100644 --- a/gtk/gtkplacessidebar.c +++ b/gtk/gtkplacessidebar.c @@ -838,14 +838,17 @@ update_places (GtkPlacesSidebar *sidebar) if (sidebar->show_desktop) { mount_uri = get_desktop_directory_uri (); - icon = g_themed_icon_new_with_default_fallbacks (ICON_NAME_DESKTOP); - add_place (sidebar, PLACES_BUILT_IN, - SECTION_COMPUTER, - _("Desktop"), icon, mount_uri, - NULL, NULL, NULL, 0, - _("Open the contents of your desktop in a folder")); - g_object_unref (icon); - g_free (mount_uri); + if (mount_uri) + { + icon = g_themed_icon_new_with_default_fallbacks (ICON_NAME_DESKTOP); + add_place (sidebar, PLACES_BUILT_IN, + SECTION_COMPUTER, + _("Desktop"), icon, mount_uri, + NULL, NULL, NULL, 0, + _("Open the contents of your desktop in a folder")); + g_object_unref (icon); + g_free (mount_uri); + } } /* XDG directories */