listbox: short-circuit if no sort function is set

do_sort will crash if sort_func is not defined. Instead of adding a check
there in the hot path, just check for sort_func before invalidating the
sort of the underlying GSequence.
This commit is contained in:
Christian Hergert 2016-06-20 15:17:00 -07:00
parent 49bd5a97ce
commit 3724592efb

View File

@ -1280,6 +1280,9 @@ gtk_list_box_invalidate_sort (GtkListBox *box)
g_return_if_fail (GTK_IS_LIST_BOX (box));
if (priv->sort_func == NULL)
return;
g_sequence_sort (priv->children, (GCompareDataFunc)do_sort, box);
g_sequence_foreach (priv->children, gtk_list_box_css_node_foreach, &previous);