callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GtkGestureZoom: Don't leak the list of sequences

Browse Source 
https://bugzilla.gnome.org/show_bug.cgi?id=789149
This commit is contained in:
Debarshi Ray
2017-10-18 15:35:19 +02:00
parent 45198d2312
commit 29c4d0a3ee
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gtk/gtkgesturezoom.c
View File

@ -79,17 +79,18 @@ _gtk_gesture_zoom_get_distance (GtkGestureZoom *zoom,
const GdkEvent *last_event; const GdkEvent *last_event;
gdouble x1, y1, x2, y2; gdouble x1, y1, x2, y2;
GtkGesture *gesture; GtkGesture *gesture;
GList *sequences; GList *sequences = NULL;
gdouble dx, dy; gdouble dx, dy;
gboolean retval = FALSE;
gesture = GTK_GESTURE (zoom); gesture = GTK_GESTURE (zoom);
if (!gtk_gesture_is_recognized (gesture)) if (!gtk_gesture_is_recognized (gesture))
return FALSE; goto out;
sequences = gtk_gesture_get_sequences (gesture); sequences = gtk_gesture_get_sequences (gesture);
if (!sequences) if (!sequences)
return FALSE; goto out;
last_event = gtk_gesture_get_last_event (gesture, sequences->data); last_event = gtk_gesture_get_last_event (gesture, sequences->data);
@ -104,18 +105,21 @@ _gtk_gesture_zoom_get_distance (GtkGestureZoom *zoom,
else else
{ {
if (!sequences->next) if (!sequences->next)
return FALSE; goto out;
gtk_gesture_get_point (gesture, sequences->data, &x1, &y1); gtk_gesture_get_point (gesture, sequences->data, &x1, &y1);
gtk_gesture_get_point (gesture, sequences->next->data, &x2, &y2); gtk_gesture_get_point (gesture, sequences->next->data, &x2, &y2);
g_list_free (sequences);
dx = x1 - x2; dx = x1 - x2;
dy = y1 - y2;; dy = y1 - y2;;
*distance = sqrt ((dx * dx) + (dy * dy)); *distance = sqrt ((dx * dx) + (dy * dy));
} }
return TRUE; retval = TRUE;
out:
g_list_free (sequences);
return retval;
} }
static gboolean static gboolean