From 28fc4de6aaed944d223c7a84ecb6ef3c6d340e3b Mon Sep 17 00:00:00 2001 From: Wouter Verhelst Date: Thu, 31 Mar 2016 11:09:41 +0200 Subject: [PATCH] Clarify that one cannot use the same variable A naive way to perform an action on all parent nodes of a given node could be to do: while(gtk_tree_model_iter_parent(model, &iter, &iter)) { /* perform some action on iter here */ } However, since gtk_tree_model_iter_parent() will initialize the iterator pointed to by the second parameter before performing the lookup, this will not work. Explicitly document this behaviour. Signed-off-by: Wouter Verhelst https://bugzilla.gnome.org/show_bug.cgi?id=573380 --- gtk/gtktreemodel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/gtktreemodel.c b/gtk/gtktreemodel.c index 5e447b9a2e..500658b5c1 100644 --- a/gtk/gtktreemodel.c +++ b/gtk/gtktreemodel.c @@ -1640,6 +1640,9 @@ gtk_tree_model_iter_nth_child (GtkTreeModel *tree_model, * @child will remain a valid node after this function has been * called. * + * @iter will be initialized before the lookup is performed, so @child + * and @iter cannot point to the same memory location. + * * Returns: %TRUE, if @iter is set to the parent of @child */ gboolean