callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

file chooser: Avoid doing excess work

Browse Source 
Whenever we change directories, we unset the model, and then
we set a new model. This causes several emissions of
GtkTreeSelection::changed, for each of which we do a bunch
of work to update the path bar, the location entry, etc.

We can savely ignore some of these signals, and do less work.
This commit is contained in:
Matthias Clasen
2015-07-08 21:06:58 -04:00
parent 72a8064c7d
commit 201d4c1101
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gtk/gtkfilechooserwidget.c
View File

@ -7584,6 +7584,9 @@ list_selection_changed (GtkTreeSelection *selection,
{ {
GtkFileChooserWidgetPrivate *priv = impl->priv; GtkFileChooserWidgetPrivate *priv = impl->priv;
if (gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view)) == NULL)
return;
/* See if we are in the new folder editable row for Save mode */ /* See if we are in the new folder editable row for Save mode */
if (priv->operation_mode == OPERATION_MODE_BROWSE && if (priv->operation_mode == OPERATION_MODE_BROWSE &&
priv->action == GTK_FILE_CHOOSER_ACTION_SAVE) priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)