Commit Graph

21606 Commits

Author SHA1 Message Date
4a61ca28b1 Fixed GtkLabel documentation on links
An escaped '<' wasn't complete, the 'lt' part was missing.
2013-12-21 15:54:29 +01:00
090159cec9 gdkwindow: Don't add the same window to "update_windows" twice
This prevents passing of such window to another GMainLoop.

https://bugzilla.gnome.org/show_bug.cgi?id=711552
2013-12-18 18:29:33 +01:00
c212cb8f32 gdkwindow: Handle references in "update_windows" list correctly
Since update_windows list is a static variable in GdkWindow.c which
contains pointers to windows which needs to be updated, it can happen
that it contains a pointer to a window even after quit from a gtk_main().
If another gtk_main() is called in the same process it tries to process
windows in the list which leads to a crash.
Correct reference count handling of added windows prevents such applications
from crash.

https://bugzilla.gnome.org/show_bug.cgi?id=711552
2013-12-16 18:15:50 +01:00
2c01e7e78d Bug 651224 - Potential NULL display ptr from quartz gtk_clipboard_wait_for_contents 2013-12-09 11:38:51 -06:00
b7ab0ed129 iconfactory: Initialize varibale to NULL in failure path
Otherwise we use random memory and that is not good.
2013-12-06 12:02:22 -05:00
e048de9cab ime: Add builtin handling of dead keys
The IME input method has been both ignoring keypresses of
non-spacing characters (ditching these as non displayable),
and not letting IME do anything about those.

Even though, the sparse documentation on IMM/IME seems to
hint that applications can't pipe non-spacing characters to
the input method manager, and experimentation shown that
those characters are indeed handled differently than how
it'd be expected.

Then, add basic handling of dead keys on the IME input method
itself , as it's not mutually exclusive with regular keymaps
with dead keys.

https://bugzilla.gnome.org/show_bug.cgi?id=704937
2013-12-05 10:12:24 -06:00
aa8704aa9f Bug 712536 - Themes with gap_(start|end)_file but no actual file crash
Code factorization in commit 34fd123 reintroduced bug fixed in 0d396ab
with non-equivalent factorized tests.
2013-12-05 01:08:18 +13:00
4f47aa6ef5 GtkFileChooser: avoid a memory leak
The directory enumeration code was leaking references to
GtkFolder objects.

https://bugzilla.gnome.org/show_bug.cgi?id=705367
2013-12-01 17:13:01 -05:00
9559c707d5 Avoid a crash in the pixbuf engine
This is fallout from e4c83bbfdb,
which removed a necessary check.
2013-12-01 17:12:08 -05:00
3d0abd5cb0 Remove an unused struct member
AsyncFuncData.folder was entirely unused. Drop it.
2013-12-01 16:56:54 -05:00
e4c83bbfdb pixbuf-engine: Clean up error conditions and destructors
Simplify the error checks and move all common behaviour into a utility
function.

https://bugzilla.gnome.org/show_bug.cgi?id=712536
2013-11-22 22:19:58 -05:00
e2aabc016a pixbuf-engine: Improve ThemePixbuf clean up functions
Make theme_pixbuf_destroy() NULL-safe like g_free(), and add a clear
function in the spirit of the g_clear_* family of functions.

https://bugzilla.gnome.org/show_bug.cgi?id=712536
2013-11-22 22:19:58 -05:00
c988a258cc Themes with specified gap images but no actual file crash.
https://bugzilla.gnome.org/show_bug.cgi?id=712536
2013-11-22 22:19:58 -05:00
e09719b12d Prevent a possible warning
When doing updates, gtk_progress_bar_real_update can calculate
compute a negative value for activity_pos.

If the allocation width is smaller than (xthickness + size),
pbar->activity_pos will be set to a negative value and this will
cause the drawing code to emit a warning about coordinates being
out of bounds.

Prevent this by keeping the value at least 0.

https://bugzilla.gnome.org/show_bug.cgi?id=701751
2013-11-09 23:51:50 -05:00
280fc402be Win32: Honor the geometry when GDK_HINT_MAX_SIZE is set.
The MINMAXINFO struct was being populated based upon geometry hints when
GDK_HINT_MAX_SIZE flag was enabled, then promptly having its values blown
away with default values.

https://bugzilla.gnome.org/show_bug.cgi?id=711110
2013-10-31 15:58:41 -05:00
352257a9c1 bgo#710936 - Fix typo in Japanese translation 2013-10-28 15:00:23 -06:00
fc201ba87c Bump version 2013-10-11 08:43:20 -04:00
d4538cf96c 2.24.22 2013-10-11 05:57:31 -04:00
b1813c9c79 Fix build 2013-10-06 00:48:50 -04:00
71560f2b55 Support automake 1.14
https://bugzilla.gnome.org/show_bug.cgi?id=709293
2013-10-05 23:25:59 -04:00
1b8d3b9210 Actually look in /usr/share/gtk-2.0 for default rc files
I managed to forget the 'share' component of the path.
2013-09-30 12:51:39 -04:00
88da0ce47f Updated Hungarian translation 2013-09-22 11:39:26 +02:00
13ffc6c71d Post-release version bump 2013-09-17 11:47:02 -04:00
51f4e42591 2.24.21 2013-09-17 10:45:29 -04:00
c915afe98c Disable filechooser test
It does't work in make distcheck.
2013-09-17 10:45:29 -04:00
b81e8de3ff Make filechooser test pass 2013-09-17 10:21:58 -04:00
4437ccb89f Updated Thai translation. 2013-09-11 17:32:28 +07:00
2eade26e68 [gdkcairo] Fix color premultiplication
https://bugzilla.gnome.org/show_bug.cgi?id=513812
2013-09-09 12:08:26 -04:00
956f5e3f6b Fix config dir <> data dir confusion
We added code to look for gtkrc in system config dirs,
and then proceeded to move it to /usr/share/gtk-2.0 :-(.
So, look in that location as well.
2013-09-06 09:49:54 -04:00
541aa72f86 Fix missing return from quartz_filter_keypress
(cherry picked from commit 0ae728e2424406f1dab3878a31942d9dd8862c1a)
2013-08-29 14:13:31 -07:00
eb3d9dc3dd combobox: Add missing Since tags for entry constructors 2013-08-22 20:26:39 +01:00
a2149a671a Bug 705750 Quartz input method doesn't work correctly for Chinese characters 2013-08-16 10:25:25 -07:00
36e26c8a03 Fix a crasher that was introduced by 9ca802161ec6387419d160f21fe477008a567477
due to preedit_str being initialized as an empty string rather than NULL.
2013-08-15 15:11:50 -05:00
5af66c3f0d Bug 705182 Reset Cocoa IME state when immodule is reset
Commits the pre-edit string on receipt of focus_out and reset
commands.
Patch refinements by Cody Russell <bratsche@gnome.org> and
Ek Kato <ek.kato@gmail.com>
2013-08-15 10:06:13 -07:00
cc2d29771d win32: avoid assertion when creating a GdkPixmap fails
If gdk_pixmap_new() fails (e.g. CreateDIBSection() failure) we end up
g_object_unref()-ing the temporary GdkPixmap, and we do this before having set
the drawable_impl->hdc and drawable_impl->hdc_count. Now, this could have just
been a couple of warnings being dumped, but instead it really crashes the
application because in win32-specific GdkDrawable's finalize() we assert if
drawable_impl->hdc_count is not zero:

Gdk:ERROR:gdkdrawable-win32.c:2047:_gdk_win32_drawable_finish: assertion failed: (impl->hdc_count == 0)

In order to avoid this crash, we make sure we don't decrement the hdc_count in
the GdkPixmap's finalize() unless we have it set first (i.e. we avoid hdc_count
going down to -1).

https://bugzilla.gnome.org/show_bug.cgi?id=699236
2013-08-14 10:31:36 +02:00
8fa5cf0554 Bug 705181 Annoying beep on arrow keys
Original patch was a bit excessive, just needed to not forward the command.
2013-08-13 11:14:29 -07:00
49fd2b2b46 Bug 701571 NSApp doesn't notice NSWindow destruction
Part 1 of the fix; part 2 awaits Glib developer approval (see
https://bugzilla.gnome.org/show_bug.cgi?id=704374) and is more
correctly associated with
https://bugzilla.gnome.org/show_bug.cgi?id=674108
2013-08-11 11:02:14 -07:00
80aabf4f1c Reset cursor when mouse leaves a toplevel window.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=692548
2013-08-08 09:36:28 -05:00
91bcca6f39 Bug 705181: Fix annoying beeping introduced by Mac IME
NSTextInputClient should not chain unhandled commands to super
2013-07-30 17:17:29 -07:00
4ecbef0791 win32: always recreate the cairo surface if requested to do so
When _gdk_windowing_create_cairo_surface() gets called, we should always create
a fully new cairo surface, instead of just referencing the available one, which
may already be finished (i.e. in CAIRO_STATUS_SURFACE_FINISHED state).

A new user_data key is added to the surface to explicitly release the acquired
DC when the surface is destroyed, independent to the user_data key added to
clear the impl->user_data pointer.

https://bugzilla.gnome.org/show_bug.cgi?id=695636
2013-07-30 00:10:53 -04:00
d33c1cf412 Limit includes in gtksignal.h
https://bugzilla.gnome.org/show_bug.cgi?id=536767
2013-07-29 22:34:53 -04:00
280cf4ca94 X11: Fix the cut-off for too large windows
We can only handle 2^15-1 pixels, not 2^16-1.
Pointed out by Morten Welinder.

http://bugzilla.gnome.org/show_bug.cgi?id=698758
2013-07-29 20:57:00 -04:00
12fe6a9a1a Bug Bug 703789 - gtk.immodules still referenced
After switch to immodules.cache
2013-07-28 13:59:55 -07:00
43ed68aa33 Bug 701332 - Patch for minor glitch in NSTextInput 2013-07-27 13:55:39 -07:00
c064e18894 imquartz: Fallback to slave IM context if no NSEvent exists.
When an application translates a key event and drop its native event
before passing to imquartz, it can't recognize the NSEvent. On this
case imquartz doesn't emit any signals such as "commit" signal so
that the application doesn't insert any text. To avoid no response,
at least imquartz should fallback to slave GtkIMContextSimple.

https://bugzilla.gnome.org/show_bug.cgi?id=694273#c27
2013-07-27 13:52:39 -07:00
71b73e04d5 build: fix --disable-man
The third argument to AC_ARG_ENABLE is the action done when
the argument is specified, not when it is enabled.
This resulted in --disable-man enabling those.

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
2013-07-26 13:58:21 +02:00
bbcde7e380 quartz: fix crashes that sometimes happened on the first key press
because nobody has called gdk_keymap_get_for_display() before.
Now we simply make sure the default display's keymap exists
if somebody calls any gdk_keymap_*() function with a NULL
keymap (which is an allowed value).
2013-07-25 16:44:21 +02:00
561d1c6358 gtkdialog - more informative warning when ordering unexisting response_id
(cherry picked from commit 0e4d9b7793c16fd98b396ffe6b8db48b8e09f1d2)
2013-07-21 21:59:03 +09:00
c8d52c018b Define INITGUID only for mingw.org compiler
Defining INITGUID causes a build failure with mingw-w64 > r5589.

https://bugzilla.gnome.org/show_bug.cgi?id=699673

(cherry picked from commit 6a71820ff399b32c4a95e7b17979513783c4e052)
2013-07-13 16:13:08 +02:00
158fc5d9e0 2.24.20 2013-07-04 10:02:29 -04:00