callisto-debian/gtk2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the unneeded setting of the storage file inside the constructor.

Browse Source 
2006-04-11  Emmanuele Bassi  <ebassi@cvs.gnome.org>

	* gtk/gtkrecentmanager.c (gtk_recent_manager_init)
	(gtk_recent_manager_new): Remove the unneeded setting of the
	storage file inside the constructor. (Murray Cumming)
	(build_recent_items_list): Reset the dirty bit when done rebuilding
	the list from the storage file.
This commit is contained in:
Emmanuele Bassi
2006-04-11 21:04:15 +00:00
committed by Emmanuele Bassi
parent 4e2069f779
commit 82cda93923
3 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2006-04-11 Emmanuele Bassi <ebassi@cvs.gnome.org>
* gtk/gtkrecentmanager.c (gtk_recent_manager_init)
(gtk_recent_manager_new): Remove the unneeded setting of the
storage file inside the constructor. (Murray Cumming)
(build_recent_items_list): Reset the dirty bit when done rebuilding
the list from the storage file.
2006-04-11 Matthias Clasen <mclasen@redhat.com> 2006-04-11 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkscale.c (gtk_scale_get_layout_offsets): Silence * gtk/gtkscale.c (gtk_scale_get_layout_offsets): Silence

8
ChangeLog.pre-2-10
View File

@ -1,3 +1,11 @@
2006-04-11 Emmanuele Bassi <ebassi@cvs.gnome.org>
* gtk/gtkrecentmanager.c (gtk_recent_manager_init)
(gtk_recent_manager_new): Remove the unneeded setting of the
storage file inside the constructor. (Murray Cumming)
(build_recent_items_list): Reset the dirty bit when done rebuilding
the list from the storage file.
2006-04-11 Matthias Clasen <mclasen@redhat.com> 2006-04-11 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkscale.c (gtk_scale_get_layout_offsets): Silence * gtk/gtkscale.c (gtk_scale_get_layout_offsets): Silence

25
gtk/gtkrecentmanager.c
View File

@ -272,6 +272,8 @@ gtk_recent_manager_init (GtkRecentManager *manager)
priv->read_in_progress = FALSE; priv->read_in_progress = FALSE;
priv->screen = NULL; priv->screen = NULL;
build_recent_items_list (manager);
} }
static void static void
@ -482,14 +484,17 @@ gtk_recent_manager_set_filename (GtkRecentManager *manager,
gtk_recent_manager_poll_timeout, gtk_recent_manager_poll_timeout,
manager); manager);
build_recent_items_list (manager); /* mark us clean, so that we can re-read the list
* of recently used resources
*/
priv->is_dirty = FALSE; priv->is_dirty = FALSE;
build_recent_items_list (manager);
} }
/* reads the recently used resources file and builds the items list. /* reads the recently used resources file and builds the items list.
* we keep the items list inside the parser object, and build the * we keep the items list inside the parser object, and build the
* RecentInfo object only on user's demand to avoid useless replication. * RecentInfo object only on user's demand to avoid useless replication.
* this function resets the dirty bit of the manager.
*/ */
static void static void
build_recent_items_list (GtkRecentManager *manager) build_recent_items_list (GtkRecentManager *manager)
@ -564,6 +569,7 @@ build_recent_items_list (GtkRecentManager *manager)
} }
priv->read_in_progress = FALSE; priv->read_in_progress = FALSE;
priv->is_dirty = FALSE;
} }
@ -591,20 +597,7 @@ build_recent_items_list (GtkRecentManager *manager)
GtkRecentManager * GtkRecentManager *
gtk_recent_manager_new (void) gtk_recent_manager_new (void)
{ {
GtkRecentManager *retval; return g_object_new (GTK_TYPE_RECENT_MANAGER, NULL);
gchar *filename;
filename = g_build_filename (g_get_home_dir (),
GTK_RECENTLY_USED_FILE,
NULL);
retval = g_object_new (GTK_TYPE_RECENT_MANAGER,
"filename", filename,
NULL);
g_free (filename);
return retval;
} }
/** /**