New function to help handle keeping things in sync.

Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
	function to help handle keeping things in sync.

ChangeLog

@@ -1,3 +1,8 @@
+Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>
+
+	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
+	function to help handle keeping things in sync.
+
 Fri Nov 10 12:10:34 2000  Jonathan Blandford  <jrb@redhat.com>
 
 	* gtk/gtkliststore.c (gtk_model_simple_class_init): use the new

ChangeLog.pre-2-0

@@ -1,3 +1,8 @@
+Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>
+
+	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
+	function to help handle keeping things in sync.
+
 Fri Nov 10 12:10:34 2000  Jonathan Blandford  <jrb@redhat.com>
 
 	* gtk/gtkliststore.c (gtk_model_simple_class_init): use the new

ChangeLog.pre-2-10

@@ -1,3 +1,8 @@
+Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>
+
+	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
+	function to help handle keeping things in sync.
+
 Fri Nov 10 12:10:34 2000  Jonathan Blandford  <jrb@redhat.com>
 
 	* gtk/gtkliststore.c (gtk_model_simple_class_init): use the new

ChangeLog.pre-2-2

@@ -1,3 +1,8 @@
+Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>
+
+	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
+	function to help handle keeping things in sync.
+
 Fri Nov 10 12:10:34 2000  Jonathan Blandford  <jrb@redhat.com>
 
 	* gtk/gtkliststore.c (gtk_model_simple_class_init): use the new

ChangeLog.pre-2-4

@@ -1,3 +1,8 @@
+Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>
+
+	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
+	function to help handle keeping things in sync.
+
 Fri Nov 10 12:10:34 2000  Jonathan Blandford  <jrb@redhat.com>
 
 	* gtk/gtkliststore.c (gtk_model_simple_class_init): use the new

ChangeLog.pre-2-6

@@ -1,3 +1,8 @@
+Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>
+
+	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
+	function to help handle keeping things in sync.
+
 Fri Nov 10 12:10:34 2000  Jonathan Blandford  <jrb@redhat.com>
 
 	* gtk/gtkliststore.c (gtk_model_simple_class_init): use the new

ChangeLog.pre-2-8

@@ -1,3 +1,8 @@
+Fri Nov 10 19:06:41 2000  Jonathan Blandford  <jrb@redhat.com>
+
+	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_insert_value): New
+	function to help handle keeping things in sync.
+
 Fri Nov 10 12:10:34 2000  Jonathan Blandford  <jrb@redhat.com>
 
 	* gtk/gtkliststore.c (gtk_model_simple_class_init): use the new

gtk/gtktreemodelsort.c

@@ -229,7 +229,7 @@ gtk_tree_model_sort_new (void)
 
 GtkTreeModel *
 gtk_tree_model_sort_new_with_model (GtkTreeModel      *model,
-				    GValueCompareFunc *func,
+				    GValueCompareFunc  func,
 				    gint               sort_col)
 {
   GtkTreeModel *retval;
@@ -407,29 +407,49 @@ gtk_tree_model_sort_changed (GtkTreeModel *s_model,
     gtk_tree_path_free (s_path);
 }
 
-#if 0
 static void
 gtk_tree_model_sort_insert_value (GtkTreeModelSort *sort,
-				  GtkTreeIter      *old_iter,
+				  GtkTreePath      *s_path,
-				  GtkTreePath      *path)
+				  GtkTreeIter      *s_iter)
 {
-  GtkTreePath *parent_path;
+  GtkTreePath *tmp_path;
   GArray *array;
   GtkTreeIter iter;
-  SortElt new_elt;
+  SortElt elt;
   SortElt *tmp_elt;
   gint high, low, middle;
-  GValueCompareFunc *func;
+  GValueCompareFunc func;
+  GValue s_value = {0, };
   GValue tmp_value = {0, };
-  GValue old_value = {0, };
 
-  parent_path = gtk_tree_path_copy (path);
+  elt.iter = *s_iter;
-  gtk_tree_path_up (parent_path);
+  elt.ref = 0;
-  gtk_tree_model_get_iter (GTK_TREE_MODEL (sort),
+  elt.children = NULL;
-			   &iter,
+
-			   parent_path);
+  tmp_path = gtk_tree_path_copy (s_path);
-  gtk_tree_path_free (parent_path);
+  if (gtk_tree_path_up (tmp_path))
+    {
+      GtkTreePath *parent_path;
+
+      parent_path = gtk_tree_model_sort_convert_path (sort, tmp_path);
+      gtk_tree_model_get_iter (GTK_TREE_MODEL (sort), &iter, parent_path);
+      elt.parent = ((SortElt *) iter.tree_node);
       array = ((SortElt *) iter.tree_node)->children;
+      if (array == NULL)
+	{
+	  ((SortElt *) iter.tree_node)->children = g_array_sized_new (FALSE, FALSE, sizeof (SortElt), 1);
+	  array = ((SortElt *) iter.tree_node)->children;
+	}
+      gtk_tree_path_free (parent_path);
+    }
+  else
+    {
+      if (sort->root == NULL)
+	sort->root = g_array_sized_new (FALSE, FALSE, sizeof (SortElt), 1);
+      array = sort->root;
+      elt.parent = NULL;
+    }
+  gtk_tree_path_free (tmp_path);
 
   if (sort->func)
     func = sort->func;
@@ -444,38 +464,44 @@ gtk_tree_model_sort_insert_value (GtkTreeModelSort *sort,
 	  func = &g_value_int_compare_func;
 	  break;
 	default:
-	  g_warning ("No comparison function for row %d\n", sort->sort_col);
+	  g_warning ("No comparison function for row %d (Type %s)\n",
+		     sort->sort_col,
+		     g_type_name (gtk_tree_model_get_column_type (sort->model, sort->sort_col)));
 	  return;
 	}
     }
 
-  new_elt.iter = iter;
+  gtk_tree_model_get_value (sort->model, s_iter, sort->sort_col, &s_value);
-  new_elt.ref = 0;
-  new_elt.parent = ((SortElt *) iter.tree_node);
-  new_elt.children = NULL;
 
   low = 0;
   high = array->len;
   middle = (low + high)/2;
 
   /* Insert the value into the array */
-  while (1)
+  while (low != high)
     {
       gint cmp;
       tmp_elt = &(g_array_index (array, SortElt, middle));
-      gtk_tree_model_get_value (sort->model, tmp_elt, sort->sort_col, &tmp_value);
+      gtk_tree_model_get_value (sort->model,
+				(GtkTreeIter *) tmp_elt,
+				sort->sort_col,
+				&tmp_value);
 
-      cmp = ((func) (&tmp_value, value));
+      cmp = ((func) (&tmp_value, &s_value));
-      if (retval < 0)
+      g_value_unset (&tmp_value);
-	;
+
-      else if (retval == 0)
+      if (cmp < 0)
-	g_array_insert_vals
+	high = middle;
-	;
+      else if (cmp > 0)
-      else if (retval > 0)
+	low = middle;
-	;
+      else if (cmp == 0)
+	break;
+      middle = (low + high)/2;
     }
+
+  g_array_insert_vals (array, middle, &elt, 1);
+  g_value_unset (&s_value);
 }
-#endif
 
 static void
 gtk_tree_model_sort_inserted (GtkTreeModel *s_model,
@@ -489,6 +515,9 @@ gtk_tree_model_sort_inserted (GtkTreeModel *s_model,
 
   g_return_if_fail (s_path != NULL || s_iter != NULL);
 
+  if (s_path == NULL)
+    s_path = gtk_tree_model_get_path (s_model, s_iter);
+
   if (!(tree_model_sort->flags & GTK_TREE_MODEL_ITERS_PERSIST))
     {
       gtk_tree_model_sort_free_level ((GArray *) tree_model_sort->root);
@@ -496,12 +525,18 @@ gtk_tree_model_sort_inserted (GtkTreeModel *s_model,
     }
   else
     {
+      GtkTreeIter real_s_iter;
+
+      if (s_iter == NULL)
+	gtk_tree_model_get_iter (s_model, &real_s_iter, s_path);
+      else
+	real_s_iter = *s_iter;
+
+      gtk_tree_model_sort_insert_value (tree_model_sort, s_path, &real_s_iter);
     }
 
-  if (s_path == NULL)
-    s_path = gtk_tree_model_get_path (s_model, s_iter);
-
   path = gtk_tree_model_sort_convert_path (tree_model_sort, s_path);
+
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
   gtk_signal_emit_by_name (GTK_OBJECT (data), "inserted", path, iter);
   gtk_tree_path_free (path);

gtk/gtktreemodelsort.h

@@ -48,7 +48,7 @@ struct _GtkTreeModelSort
   guint flags;
   GtkTreeModel *model;
   gint sort_col;
-  GValueCompareFunc *func;
+  GValueCompareFunc func;
 };
 
 struct _GtkTreeModelSortClass
@@ -74,7 +74,7 @@ struct _GtkTreeModelSortClass
 GtkType       gtk_tree_model_sort_get_type       (void);
 GtkTreeModel *gtk_tree_model_sort_new            (void);
 GtkTreeModel *gtk_tree_model_sort_new_with_model (GtkTreeModel      *model,
-						  GValueCompareFunc *func,
+						  GValueCompareFunc  func,
 						  gint               sort_col);
 void          gtk_tree_model_sort_set_model      (GtkTreeModelSort  *tree_model_sort,
 						  GtkTreeModel      *model);