d493f0537f
This fixes all our GObject Introspection issues with GimpUnit which was both an enum and an int-derived type of user-defined units *completing* the enum values. GIR clearly didn't like this! Now GimpUnit is a proper class and units are unique objects, allowing to compare them with an identity test (i.e. `unit == gimp_unit_pixel ()` tells us if unit is the pixel unit or not), which makes it easy to use, just like with int, yet adding also methods, making for nicer introspected API. As an aside, this also fixes #10738, by having all the built-in units retrievable even if libgimpbase had not been properly initialized with gimp_base_init(). I haven't checked in details how GIR works to introspect, but it looks like it loads the library to inspect and runs functions, hence triggering some CRITICALS because virtual methods (supposed to be initialized with gimp_base_init() run by libgimp) are not set. This new code won't trigger any critical because the vtable method are now not necessary, at least for all built-in units. Note that GimpUnit is still in libgimpbase. It could have been moved to libgimp in order to avoid any virtual method table (since we need to keep core and libgimp side's units in sync, PDB is required), but too many libgimpwidgets widgets were already using GimpUnit. And technically most of GimpUnit logic doesn't require PDB (only the creation/sync part). This is one of the reasons why user-created GimpUnit list is handled and stored differently from other types of objects. Globally this simplifies the code a lot too and we don't need separate implementations of various utils for core and libgimp, which means less prone to errors.
292 lines
10 KiB
C
292 lines
10 KiB
C
/* GIMP - The GNU Image Manipulation Program
|
|
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <string.h>
|
|
|
|
#include <gegl.h>
|
|
#include <gtk/gtk.h>
|
|
|
|
#include "libgimpbase/gimpbase.h"
|
|
#include "libgimpwidgets/gimpwidgets.h"
|
|
|
|
#include "dialogs-types.h"
|
|
|
|
#include "config/gimpguiconfig.h"
|
|
|
|
#include "core/gimp.h"
|
|
#include "core/gimpcontext.h"
|
|
#include "core/gimpimage.h"
|
|
#include "core/gimpimage-scale.h"
|
|
|
|
#include "widgets/gimphelp-ids.h"
|
|
#include "widgets/gimpmessagebox.h"
|
|
#include "widgets/gimpmessagedialog.h"
|
|
|
|
#include "scale-dialog.h"
|
|
|
|
#include "image-scale-dialog.h"
|
|
|
|
#include "gimp-intl.h"
|
|
|
|
|
|
typedef struct
|
|
{
|
|
GtkWidget *dialog;
|
|
|
|
GimpImage *image;
|
|
|
|
gint width;
|
|
gint height;
|
|
GimpUnit *unit;
|
|
GimpInterpolationType interpolation;
|
|
gdouble xresolution;
|
|
gdouble yresolution;
|
|
GimpUnit *resolution_unit;
|
|
|
|
GimpScaleCallback callback;
|
|
gpointer user_data;
|
|
} ImageScaleDialog;
|
|
|
|
|
|
/* local function prototypes */
|
|
|
|
static void image_scale_dialog_free (ImageScaleDialog *private);
|
|
static void image_scale_callback (GtkWidget *widget,
|
|
GimpViewable *viewable,
|
|
gint width,
|
|
gint height,
|
|
GimpUnit *unit,
|
|
GimpInterpolationType interpolation,
|
|
gdouble xresolution,
|
|
gdouble yresolution,
|
|
GimpUnit *resolution_unit,
|
|
gpointer data);
|
|
|
|
static GtkWidget * image_scale_confirm_dialog (ImageScaleDialog *private);
|
|
static void image_scale_confirm_large (ImageScaleDialog *private,
|
|
gint64 new_memsize,
|
|
gint64 max_memsize);
|
|
static void image_scale_confirm_small (ImageScaleDialog *private);
|
|
static void image_scale_confirm_response (GtkWidget *widget,
|
|
gint response_id,
|
|
ImageScaleDialog *private);
|
|
|
|
|
|
/* public functions */
|
|
|
|
GtkWidget *
|
|
image_scale_dialog_new (GimpImage *image,
|
|
GimpContext *context,
|
|
GtkWidget *parent,
|
|
GimpUnit *unit,
|
|
GimpInterpolationType interpolation,
|
|
GimpScaleCallback callback,
|
|
gpointer user_data)
|
|
{
|
|
ImageScaleDialog *private;
|
|
|
|
g_return_val_if_fail (GIMP_IS_IMAGE (image), NULL);
|
|
g_return_val_if_fail (GIMP_IS_CONTEXT (context), NULL);
|
|
g_return_val_if_fail (callback != NULL, NULL);
|
|
|
|
private = g_slice_new0 (ImageScaleDialog);
|
|
|
|
private->image = image;
|
|
private->callback = callback;
|
|
private->user_data = user_data;
|
|
|
|
private->dialog = scale_dialog_new (GIMP_VIEWABLE (image), context,
|
|
C_("dialog-title", "Scale Image"),
|
|
"gimp-image-scale",
|
|
parent,
|
|
gimp_standard_help_func,
|
|
GIMP_HELP_IMAGE_SCALE,
|
|
unit,
|
|
interpolation,
|
|
image_scale_callback,
|
|
private);
|
|
|
|
g_object_weak_ref (G_OBJECT (private->dialog),
|
|
(GWeakNotify) image_scale_dialog_free, private);
|
|
|
|
return private->dialog;
|
|
}
|
|
|
|
|
|
/* private functions */
|
|
|
|
static void
|
|
image_scale_dialog_free (ImageScaleDialog *private)
|
|
{
|
|
g_slice_free (ImageScaleDialog, private);
|
|
}
|
|
|
|
static void
|
|
image_scale_callback (GtkWidget *widget,
|
|
GimpViewable *viewable,
|
|
gint width,
|
|
gint height,
|
|
GimpUnit *unit,
|
|
GimpInterpolationType interpolation,
|
|
gdouble xresolution,
|
|
gdouble yresolution,
|
|
GimpUnit *resolution_unit,
|
|
gpointer data)
|
|
{
|
|
ImageScaleDialog *private = data;
|
|
GimpImage *image = GIMP_IMAGE (viewable);
|
|
GimpImageScaleCheckType scale_check;
|
|
gint64 max_memsize;
|
|
gint64 new_memsize;
|
|
|
|
private->width = width;
|
|
private->height = height;
|
|
private->unit = unit;
|
|
private->interpolation = interpolation;
|
|
private->xresolution = xresolution;
|
|
private->yresolution = yresolution;
|
|
private->resolution_unit = resolution_unit;
|
|
|
|
gtk_widget_set_sensitive (widget, FALSE);
|
|
|
|
max_memsize = GIMP_GUI_CONFIG (image->gimp->config)->max_new_image_size;
|
|
|
|
scale_check = gimp_image_scale_check (image,
|
|
width, height, max_memsize,
|
|
&new_memsize);
|
|
switch (scale_check)
|
|
{
|
|
case GIMP_IMAGE_SCALE_TOO_BIG:
|
|
image_scale_confirm_large (private, new_memsize, max_memsize);
|
|
break;
|
|
|
|
case GIMP_IMAGE_SCALE_TOO_SMALL:
|
|
image_scale_confirm_small (private);
|
|
break;
|
|
|
|
case GIMP_IMAGE_SCALE_OK:
|
|
private->callback (private->dialog,
|
|
GIMP_VIEWABLE (private->image),
|
|
private->width,
|
|
private->height,
|
|
private->unit,
|
|
private->interpolation,
|
|
private->xresolution,
|
|
private->yresolution,
|
|
private->resolution_unit,
|
|
private->user_data);
|
|
break;
|
|
}
|
|
}
|
|
|
|
static GtkWidget *
|
|
image_scale_confirm_dialog (ImageScaleDialog *private)
|
|
{
|
|
GtkWidget *widget;
|
|
|
|
widget = gimp_message_dialog_new (_("Confirm Scaling"),
|
|
GIMP_ICON_DIALOG_WARNING,
|
|
private->dialog,
|
|
GTK_DIALOG_DESTROY_WITH_PARENT,
|
|
gimp_standard_help_func,
|
|
GIMP_HELP_IMAGE_SCALE_WARNING,
|
|
|
|
_("_Cancel"), GTK_RESPONSE_CANCEL,
|
|
_("_Scale"), GTK_RESPONSE_OK,
|
|
|
|
NULL);
|
|
|
|
gimp_dialog_set_alternative_button_order (GTK_DIALOG (widget),
|
|
GTK_RESPONSE_OK,
|
|
GTK_RESPONSE_CANCEL,
|
|
-1);
|
|
|
|
g_signal_connect (widget, "response",
|
|
G_CALLBACK (image_scale_confirm_response),
|
|
private);
|
|
|
|
return widget;
|
|
}
|
|
|
|
static void
|
|
image_scale_confirm_large (ImageScaleDialog *private,
|
|
gint64 new_memsize,
|
|
gint64 max_memsize)
|
|
{
|
|
GtkWidget *widget = image_scale_confirm_dialog (private);
|
|
gchar *size;
|
|
|
|
size = g_format_size (new_memsize);
|
|
gimp_message_box_set_primary_text (GIMP_MESSAGE_DIALOG (widget)->box,
|
|
_("You are trying to create an image "
|
|
"with a size of %s."), size);
|
|
g_free (size);
|
|
|
|
size = g_format_size (max_memsize);
|
|
gimp_message_box_set_text (GIMP_MESSAGE_DIALOG (widget)->box,
|
|
_("Scaling the image to the chosen size will "
|
|
"make it use more memory than what is "
|
|
"configured as \"Maximum Image Size\" in the "
|
|
"Preferences dialog (currently %s)."), size);
|
|
g_free (size);
|
|
|
|
gtk_widget_show (widget);
|
|
}
|
|
|
|
static void
|
|
image_scale_confirm_small (ImageScaleDialog *private)
|
|
{
|
|
GtkWidget *widget = image_scale_confirm_dialog (private);
|
|
|
|
gimp_message_box_set_primary_text (GIMP_MESSAGE_DIALOG (widget)->box,
|
|
_("Scaling the image to the chosen size "
|
|
"will shrink some layers completely "
|
|
"away."));
|
|
gimp_message_box_set_text (GIMP_MESSAGE_DIALOG (widget)->box,
|
|
_("Is this what you want to do?"));
|
|
|
|
gtk_widget_show (widget);
|
|
}
|
|
|
|
static void
|
|
image_scale_confirm_response (GtkWidget *widget,
|
|
gint response_id,
|
|
ImageScaleDialog *private)
|
|
{
|
|
gtk_widget_destroy (widget);
|
|
|
|
if (response_id == GTK_RESPONSE_OK)
|
|
{
|
|
private->callback (private->dialog,
|
|
GIMP_VIEWABLE (private->image),
|
|
private->width,
|
|
private->height,
|
|
private->unit,
|
|
private->interpolation,
|
|
private->xresolution,
|
|
private->yresolution,
|
|
private->resolution_unit,
|
|
private->user_data);
|
|
}
|
|
else
|
|
{
|
|
gtk_widget_set_sensitive (private->dialog, TRUE);
|
|
}
|
|
}
|