16a2fc58ba
It was an equality because I think the conversion from palette format to "RGBA float" should go through the exact same babl code path, however it is done in the API. And that is the case on my machine where I get indeed perfect equality. But apparently not on the CI. Though I guess investigating further would not be a bad idea, let's consider this a minor issue (as a general rule, comparing float with epsilon is still a recommended software usage), and just add a comment.
149 lines
6.7 KiB
C
149 lines
6.7 KiB
C
#define GIMP_TEST_PALETTE "Bears"
|
|
#define GIMP_TEST_PALETTE_SIZE 256
|
|
#define GIMP_TEST_COLOR_IDX 3
|
|
#define GIMP_TEST_COLOR_FORMAT "R'G'B' u8"
|
|
#define GIMP_TEST_COLOR_R_U8 72
|
|
#define GIMP_TEST_COLOR_G_U8 56
|
|
#define GIMP_TEST_COLOR_B_U8 56
|
|
#define EPSILON 1e-6f
|
|
|
|
static GimpValueArray *
|
|
gimp_c_test_run (GimpProcedure *procedure,
|
|
GimpRunMode run_mode,
|
|
GimpImage *image,
|
|
gint n_drawables,
|
|
GimpDrawable **drawables,
|
|
GimpProcedureConfig *config,
|
|
gpointer run_data)
|
|
{
|
|
GimpPalette *palette;
|
|
GimpPalette *palette2;
|
|
GeglColor **colors;
|
|
gint n_colors;
|
|
guchar *colormap;
|
|
gfloat *fcolormap;
|
|
gint n_colormap_colors;
|
|
gsize n_bytes;
|
|
const Babl *format;
|
|
const Babl *format2;
|
|
gint format_bpp;
|
|
gint format2_bpp;
|
|
GeglColor *color;
|
|
guint8 rgb[3];
|
|
gfloat rgba[4];
|
|
GimpValueArray *retvals;
|
|
|
|
GIMP_TEST_START("gimp_palette_get_by_name()")
|
|
palette = gimp_palette_get_by_name (GIMP_TEST_PALETTE);
|
|
GIMP_TEST_END(GIMP_IS_PALETTE (palette))
|
|
|
|
GIMP_TEST_START("gimp_palette_get_by_name() is unique")
|
|
palette2 = gimp_palette_get_by_name (GIMP_TEST_PALETTE);
|
|
GIMP_TEST_END(GIMP_IS_PALETTE (palette2) && palette == palette2)
|
|
|
|
GIMP_TEST_START("gimp_palette_get_color_count()")
|
|
n_colors = gimp_palette_get_color_count (palette);
|
|
GIMP_TEST_END(n_colors == GIMP_TEST_PALETTE_SIZE)
|
|
|
|
GIMP_TEST_START("gimp_palette_get_colors()")
|
|
colors = gimp_palette_get_colors (palette);
|
|
GIMP_TEST_END(colors != NULL && gimp_color_array_get_length (colors) == GIMP_TEST_PALETTE_SIZE)
|
|
|
|
GIMP_TEST_START("Checking fourth palette color's format")
|
|
color = colors[GIMP_TEST_COLOR_IDX];
|
|
format = gegl_color_get_format (color);
|
|
GIMP_TEST_END(format == babl_format (GIMP_TEST_COLOR_FORMAT))
|
|
|
|
GIMP_TEST_START("Checking fourth palette color's RGB components")
|
|
gegl_color_get_pixel (color, format, rgb);
|
|
GIMP_TEST_END(rgb[0] == GIMP_TEST_COLOR_R_U8 && rgb[1] == GIMP_TEST_COLOR_G_U8 && rgb[2] == GIMP_TEST_COLOR_B_U8)
|
|
|
|
GIMP_TEST_START("gimp_palette_get_colormap()")
|
|
colormap = gimp_palette_get_colormap (palette, format, &n_colormap_colors, &n_bytes);
|
|
format_bpp = babl_format_get_bytes_per_pixel (format);
|
|
GIMP_TEST_END(colormap != NULL && n_colormap_colors == n_colors &&
|
|
n_colormap_colors * format_bpp == n_bytes)
|
|
|
|
GIMP_TEST_START("Comparing fourth palette color's RGB components from colormap")
|
|
GIMP_TEST_END(colormap[format_bpp * GIMP_TEST_COLOR_IDX] == GIMP_TEST_COLOR_R_U8 &&
|
|
colormap[format_bpp * GIMP_TEST_COLOR_IDX + 1] == GIMP_TEST_COLOR_G_U8 &&
|
|
colormap[format_bpp * GIMP_TEST_COLOR_IDX + 2]== GIMP_TEST_COLOR_B_U8)
|
|
|
|
g_free (colormap);
|
|
|
|
GIMP_TEST_START("gimp_palette_get_colormap() in \"R'G'B'A float\" format")
|
|
format2 = babl_format ("RGBA float");
|
|
format2_bpp = babl_format_get_bytes_per_pixel (format2);
|
|
fcolormap = (gfloat *) gimp_palette_get_colormap (palette, format2, &n_colormap_colors, &n_bytes);
|
|
GIMP_TEST_END(fcolormap != NULL && n_colormap_colors == n_colors &&
|
|
format2 != format &&
|
|
format2_bpp > format_bpp &&
|
|
n_colormap_colors * format2_bpp == n_bytes)
|
|
|
|
GIMP_TEST_START("Comparing fourth palette color's RGB components from colormap in float format")
|
|
gegl_color_get_pixel (color, format2, rgba);
|
|
/* XXX: whether to a colormap or to a GeglColor, I was expecting the
|
|
* conversion from palette format to target format to be done through
|
|
* exact same babl code path, hence equality to be perfect (i.e. no
|
|
* epsilon needed for float comparison). This is true on my machine,
|
|
* not on CI. Is it again some SSE2 inconsistency where sometimes
|
|
* conversion goes to SSE2, sometimes not, for the same run and same
|
|
* babl fish? Something else? To be further investigated.
|
|
*/
|
|
GIMP_TEST_END(fabsf (fcolormap[4 * GIMP_TEST_COLOR_IDX] - rgba[0]) < EPSILON &&
|
|
fabsf (fcolormap[4 * GIMP_TEST_COLOR_IDX + 1] - rgba[1]) < EPSILON &&
|
|
fabsf (fcolormap[4 * GIMP_TEST_COLOR_IDX + 2] - rgba[2]) < EPSILON)
|
|
|
|
g_free (fcolormap);
|
|
|
|
/* Run the same tests through PDB. */
|
|
|
|
GIMP_TEST_START("gimp-palette-get-by-name")
|
|
retvals = gimp_procedure_run (gimp_pdb_lookup_procedure (gimp_get_pdb (), "gimp-palette-get-by-name"),
|
|
"name", GIMP_TEST_PALETTE, NULL);
|
|
GIMP_TEST_END(g_value_get_enum (gimp_value_array_index (retvals, 0)) == GIMP_PDB_SUCCESS)
|
|
|
|
GIMP_TEST_START("gimp-palette-get-by-name and gimp_palette_get_by_name() get identical result")
|
|
palette2 = g_value_get_object (gimp_value_array_index(retvals, 1));
|
|
GIMP_TEST_END(GIMP_IS_PALETTE (palette2) && palette == palette2)
|
|
|
|
gimp_value_array_unref (retvals);
|
|
|
|
GIMP_TEST_START("gimp-palette-get-color-count")
|
|
retvals = gimp_procedure_run (gimp_pdb_lookup_procedure (gimp_get_pdb (), "gimp-palette-get-color-count"),
|
|
"palette", palette, NULL);
|
|
GIMP_TEST_END(g_value_get_enum (gimp_value_array_index (retvals, 0)) == GIMP_PDB_SUCCESS)
|
|
|
|
GIMP_TEST_START("gimp-palette-get-color-count returns the right number of colors")
|
|
n_colors = g_value_get_int (gimp_value_array_index (retvals, 1));
|
|
GIMP_TEST_END(n_colors == GIMP_TEST_PALETTE_SIZE)
|
|
|
|
gimp_value_array_unref (retvals);
|
|
|
|
GIMP_TEST_START("gimp-palette-get-colors")
|
|
retvals = gimp_procedure_run (gimp_pdb_lookup_procedure (gimp_get_pdb (), "gimp-palette-get-colors"),
|
|
"palette", palette, NULL);
|
|
GIMP_TEST_END(g_value_get_enum (gimp_value_array_index (retvals, 0)) == GIMP_PDB_SUCCESS)
|
|
|
|
GIMP_TEST_START("gimp-palette-get-colors returns GimpColorArray")
|
|
colors = g_value_get_boxed (gimp_value_array_index (retvals, 1));
|
|
GIMP_TEST_END(colors != NULL && gimp_color_array_get_length (colors) == GIMP_TEST_PALETTE_SIZE)
|
|
|
|
GIMP_TEST_START("gimp_value_array_get_color_array()")
|
|
colors = gimp_value_array_get_color_array (retvals, 1);
|
|
GIMP_TEST_END(colors != NULL && gimp_color_array_get_length (colors) == GIMP_TEST_PALETTE_SIZE)
|
|
|
|
GIMP_TEST_START("Checking fourth palette color's format (returned by PDB)")
|
|
color = colors[GIMP_TEST_COLOR_IDX];
|
|
format = gegl_color_get_format (color);
|
|
GIMP_TEST_END(format == babl_format (GIMP_TEST_COLOR_FORMAT))
|
|
|
|
GIMP_TEST_START("Checking fourth palette color's RGB values (returned by PDB)")
|
|
gegl_color_get_pixel (color, format, rgb);
|
|
GIMP_TEST_END(rgb[0] == GIMP_TEST_COLOR_R_U8 && rgb[1] == GIMP_TEST_COLOR_G_U8 && rgb[2] == GIMP_TEST_COLOR_B_U8)
|
|
|
|
gimp_value_array_unref (retvals);
|
|
|
|
GIMP_TEST_RETURN
|
|
}
|