Commit Graph

2 Commits

Author SHA1 Message Date
1437f52d63 make sure that all actions, even if they have no menu proxy, can be
2004-08-12  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpmenufactory.c (gimp_menu_factory_manager_new):
	make sure that all actions, even if they have no menu proxy, can
	be invoked by their accelerators. Fixes bug #149938.

	* app/widgets/gimpimagedock.c (gimp_image_dock_constructor):
	removed the same code here.

	* app/widgets/gimpactionview.[ch] (gimp_action_view_dispose): new
	function which disconnects from "accel_changed" of the accel_group
	before upchaining (== before emitting "destroy").

	The above changes make this one redundant, but since the crash in
	bug #149938 was triggered by "accel_changed" emitted in the middle
	of g_object_unref(tree_model), it feels better to be paranoic here
	(fiddling with objects in destruction is no fun).

	(gimp_action_view_accel_edited): don't warn if assigning the same
	accel to the same action again.

	(gimp_action_view_new): don't leak all accel_closures.
2004-08-12 20:04:19 +00:00
94fc8f15a1 app/widgets/gimpactionfactory.[ch] added "label" and "stock-id" properties
2004-07-20  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpactionfactory.[ch]
	* app/widgets/gimpactiongroup.[ch]: added "label" and "stock-id"
	properties to GtkActionGroup and allow to register them in the
	GimpActionFactory.

	* app/actions/actions.c: register user visible labels and icons
	with all action groups.

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpactionview.[ch]: new widget which shows a
	treeview of action groups and their actions & shortcuts.

	* app/widgets/gimpaction.[ch]: added gimp_action_name_compare()
	utility function.

	* app/widgets/gimpwidgets-utils.[ch]: added
	gimp_get_accel_string() utility function.

	* app/widgets/gimpcontrollers.[ch]: added
	gimp_controllers_get_ui_manager() which will be used for setting
	up the controller mapping dialog.

	* app/gui/preferences-dialog.c: added a "Configure Keyboard
	Shortcuts" button which pops up a GimpControllerView. Work in
	progress...
2004-07-20 18:50:20 +00:00