Commit Graph

56 Commits

Author SHA1 Message Date
e4eec5b5b1 check for lcms with PKG_CHECK_MODULES(). Remove check for <lcms.h> vs.
2008-08-11  Michael Natterer  <mitch@gimp.org>

	* configure.in: check for lcms with PKG_CHECK_MODULES(). Remove
	check for <lcms.h> vs. <lsmc/lsmc.h> because the pc file should
	give us the right location now.

	* modules/cdisplay_lcms.c
	* modules/cdisplay_proof.c
	* modules/colorsel_cmyk_lcms.c
	* plug-ins/file-jpeg/jpeg-load.c
	* plug-ins/common/lcms.c: #include <lcms.h> and nothing else.

	* modules/Makefile.am
	* plug-ins/file-jpeg/Makefile.am
	* plug-ins/common/plugin-defs.pl: add LCMS_CFLAGS where appropriate.

	* plug-ins/common/Makefile.am: regenerated.


svn path=/trunk/; revision=26503
2008-08-11 17:28:41 +00:00
9c9157039b fixed use of GChecksum.
2008-03-29  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_calculate_checksum): fixed use of
	GChecksum.


svn path=/trunk/; revision=25301
2008-03-29 16:46:17 +00:00
1a0db1b5bc gimp_md5_get_digest() is deprecated; using GChecksum instead.
2008-03-28  Mukund Sivaraman  <muks@mukund.org>

        * plug-ins/common/lcms.c: gimp_md5_get_digest() is deprecated;
        using GChecksum instead.


svn path=/trunk/; revision=25294
2008-03-29 02:28:39 +00:00
ce0734c83a fixed crash on missing profile (bug #512529).
2008-01-28  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_dialog): fixed crash on missing
	profile (bug #512529).

svn path=/trunk/; revision=24733
2008-01-28 17:27:50 +00:00
9c4ec2ec2f plug-ins/common/lcms.c (lcms_load_profile) fixed error messages.
2008-01-28  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_load_profile)
	* plug-ins/common/wmf.c (load_image): fixed error messages.

svn path=/trunk/; revision=24732
2008-01-28 17:04:46 +00:00
31a5214fd5 app/base/tile-manager.c use G_STRLOC instead of G_GNUC_FUNCTION (which is
2008-01-28  Michael Natterer  <mitch@gimp.org>

	* app/base/tile-manager.c
	* plug-ins/common/lcms.c: use G_STRLOC instead of
	G_GNUC_FUNCTION (which is now deprecated).


svn path=/trunk/; revision=24727
2008-01-28 13:19:42 +00:00
b4f812491f modules/cdisplay_lcms.c modules/cdisplay_proof.c
2007-10-04  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_lcms.c
	* modules/cdisplay_proof.c
	* modules/colorsel_cmyk_lcms.c
	* plug-ins/common/lcms.c 
	* plug-ins/jpeg/jpeg-load.c: use cmsFLAGS_BLACKPOINTCOMPENSATION
	instead of the equivalent cmsFLAGS_WHITEBLACKCOMPENSATION.

svn path=/trunk/; revision=23724
2007-10-04 14:21:55 +00:00
b6bc110c22 use the display rendering intent as set in the user's color management
2007-10-03  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: use the display rendering intent as 
set
	in the user's color management preferences as the default for 
the
	color conversion. Default to using black point compensation if 
the
	rendering intent is relative colorimetric (bug #475983).


svn path=/trunk/; revision=23719
2007-10-03 13:43:50 +00:00
85deee0aef don't create nested undo groups.
2007-09-26  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: don't create nested undo groups.


svn path=/trunk/; revision=23662
2007-09-26 19:29:54 +00:00
f1ce484ab2 marked blurbs as translatable.
2007-09-23  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: marked blurbs as translatable.


svn path=/trunk/; revision=23631
2007-09-23 18:30:31 +00:00
8c99fcc50e remember color conversion parameters (bug #475966).
2007-09-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: remember color conversion parameters
	(bug #475966).

svn path=/trunk/; revision=23507
2007-09-12 09:24:54 +00:00
471eed6bab fixed use of black-point-compensation parameter (bug #475952).
2007-09-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: fixed use of black-point-compensation
	parameter (bug #475952).


svn path=/trunk/; revision=23504
2007-09-12 06:21:05 +00:00
563bb6fe80 allow to specify rendering intent and black point compensation. Fixes bug
2007-09-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: allow to specify rendering intent and 
	black point compensation. Fixes bug #474787.

svn path=/trunk/; revision=23497
2007-09-11 09:37:38 +00:00
c35f4644da copy the alpha channel to the destination region. Fixes bug #473998.
2007-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_drawable_transform): copy the alpha
	channel to the destination region. Fixes bug #473998.

svn path=/trunk/; revision=23491
2007-09-10 13:26:02 +00:00
c53ed0aba8 gimp-selection-* procedures operate on the image_ID, not on the selection
2007-08-29  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/lcms.c (lcms_image_apply_profile):
	gimp-selection-* procedures operate on the image_ID, not on the
	selection drawable_ID itself. Fixes bug #470589. Also remove the
	saved selection channel after reloading it.


svn path=/trunk/; revision=23393
2007-08-29 11:42:38 +00:00
7cdc24d69e libgimpwidgets/gimpcolorprofilecombobox.[ch]
2007-08-14  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpcolorprofilecombobox.[ch]
	* libgimpwidgets/gimpcolorprofilestore.[ch]
	* libgimpwidgets/gimpcolorprofilestore-private.h: changed API to
	deal with filenames instead of URIs.

	* app/widgets/gimpprofilechooserdialog.[ch]: same here.

	* app/dialogs/preferences-dialog.c
	* plug-ins/common/lcms.c: changed accordingly.


svn path=/trunk/; revision=23260
2007-08-14 22:12:37 +00:00
dd7c014e09 set the URI of the profile, not the filename
svn path=/trunk/; revision=23255
2007-08-14 16:16:33 +00:00
e825b7ccb1 app/dialogs/preferences-dialog.c don't unref the file-chooser dialog.
2007-08-14  Sven Neumann  <sven@gimp.org>

	* app/dialogs/preferences-dialog.c
	* plug-ins/common/lcms.c: don't unref the file-chooser dialog.

svn path=/trunk/; revision=23254
2007-08-14 16:10:08 +00:00
f3675a45ad libgimpwidgets/Makefile.am libgimpwidgets/gimpwidgets.h
2007-08-14  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/Makefile.am
	* libgimpwidgets/gimpwidgets.h
	* libgimpwidgets/gimpwidgetstypes.h
	* libgimpwidgets/gimpcolorprofilecombobox.[ch]
	* libgimpwidgets/gimpcolorprofilestore.[ch]
	* libgimpwidgets/gimpcolorprofilestore-private.h: new widget to
	select color profiles.

	* libgimpwidgets/gimpwidgets.def: updated.

	* app/widgets/gimpprofilechooserdialog.[ch]: remember the name of
	the last previewed profile.

	* app/dialogs/preferences-dialog.c: use the new color profile
	combo-box.

	* plug-ins/common/lcms.c: use the new color profile combo-box.

svn path=/trunk/; revision=23253
2007-08-14 16:01:04 +00:00
9b7db4c28d further work on the dialog.
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: further work on the dialog.



svn path=/trunk/; revision=23219
2007-08-11 19:50:58 +00:00
52531a45a5 factored out code to a utility function.
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: factored out code to a utility 
function.


svn path=/trunk/; revision=23216
2007-08-11 19:30:12 +00:00
5a748730fd don't open the destination profile twice.
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: don't open the destination profile 
twice.


svn path=/trunk/; revision=23215
2007-08-11 19:14:11 +00:00
a211b4ffd4 if the image has a selection, save it, unset it and restore it after the
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_icc_apply): if the image has a
	selection, save it, unset it and restore it after the 
conversion.


svn path=/trunk/; revision=23214
2007-08-11 18:55:24 +00:00
3b2ed82ef5 plug-ins/common/lcms.c plug-ins/common/png.c plug-ins/common/tiff-load.c
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c
	* plug-ins/common/png.c
	* plug-ins/common/tiff-load.c
	* plug-ins/jpeg/jpeg-load.c: made the icc-profile undoable and
	persistent.
	
	* devel-docs/parasites.txt: document this.

	* plug-ins/common/lcms.c: made colorspace conversion undoable.
	
	* app/file/file-open.c: disable undo while doing the colorspace
	conversion on load.


svn path=/trunk/; revision=23213
2007-08-11 18:27:01 +00:00
7f5d403615 added "<Image>/Image/Mode/Color Profile" as a placeholder below the Image
2007-08-11  Sven Neumann  <sven@gimp.org>

	* menus/image-menu.xml.in: added "<Image>/Image/Mode/Color 
Profile"
	as a placeholder below the Image Mode radio items.

	* plug-ins/common/lcms.c (query): register menu entries to 
assign
	and apply color profiles. Dialog implementation is still 
missing...



svn path=/trunk/; revision=23211
2007-08-11 16:30:12 +00:00
abbd60c5e6 fixed a bug that I introduced earlier today.
2007-08-08  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_image_get_profile): fixed a bug
	that I introduced earlier today.


svn path=/trunk/; revision=23153
2007-08-08 18:03:29 +00:00
4ab3e92782 modules/cdisplay_lcms.c corrected memory handling. cmsOpenProfileFromMem()
2007-08-08  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_lcms.c
	* plug-ins/common/lcms.c: corrected memory handling.
	cmsOpenProfileFromMem() actually copies the data.

	* libgimpwidgets/gimpcolordisplay.c
	* libgimpwidgets/gimpcolordisplaystack.c: disconnect in dispose().

svn path=/trunk/; revision=23148
2007-08-08 12:27:11 +00:00
b53d51ca65 simplified.
2007-08-06  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (run): simplified.

svn path=/trunk/; revision=23123
2007-08-06 15:24:04 +00:00
25a71520b8 also calculate the checksum when loading the RGB profile from disk (bug
2007-07-29  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: also calculate the checksum when 
loading
	the RGB profile from disk (bug #456017).


svn path=/trunk/; revision=23060
2007-07-29 10:50:45 +00:00
137d4532bd added debug output so that we can find out if the new code does the
right thing

svn path=/trunk/; revision=22914
2007-07-11 20:54:10 +00:00
20e66d7ad8 improved debug output
svn path=/trunk/; revision=22913
2007-07-11 20:36:49 +00:00
2e359cca5a clarify which procedures work with RGB profiles and which accept profiles
2007-07-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: clarify which procedures work with RGB
	profiles and which accept profiles for other colorspaces.
	Calculate MD5 checksums of the profile data excluding the header
	and skip attempts to convert between identical profiles (bug #456017).


svn path=/trunk/; revision=22912
2007-07-11 20:31:18 +00:00
26855b3c55 added missing newline
svn path=/trunk/; revision=22462
2007-05-09 16:19:28 +00:00
ddbfbace2e improved handling of attached non-RGB profiles.
2007-05-09  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_icc_apply): improved handling of
	attached non-RGB profiles.

	* plug-ins/common/oilify.c: use GIMP_RGB_LUMINANCE() instead of
	the self-made INTENSITY macro.

	* plug-ins/common/tiff-load.c
	* plug-ins/common/tiff-save.c: reduced number of progress 
updates.


svn path=/trunk/; revision=22461
2007-05-09 16:14:18 +00:00
12aa2f8a4d added a button icon and fixed use of gtk_vbox_new().
2007-02-16  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: added a button icon and fixed use of
	gtk_vbox_new().


svn path=/trunk/; revision=21926
2007-02-16 09:31:38 +00:00
3f47350ed8 Fix mixup in retrieving the filename parameter.
2007-01-03  Tor Lillqvist  <tml@novell.com>

	* plug-ins/common/lcms.c (run): Fix mixup in retrieving the
	filename parameter.


svn path=/trunk/; revision=21626
2007-01-02 23:34:40 +00:00
fd2b9ce3e9 app/plug-in/plug-in-icc-profile.[ch] removed run-mode argument from
2006-12-18  Sven Neumann  <sven@gimp.org>

	* app/plug-in/plug-in-icc-profile.[ch]
	* plug-ins/common/lcms.c: removed run-mode argument from
	plug-in-icc-profile-info. Added new procedure to obtain
information
	about a color profile on disk.

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpprofilechooserdialog.[ch]: added a first draft
	of a file-chooser dialog for selecting a color profile.

	* app/dialogs/preferences-dialog.c: use it.
2006-12-18 08:15:56 +00:00
41237259c9 In all files, changed the standard copyright notice to say "GIMP - The GNU
2006-12-09  Sven Neumann  <sven@gimp.org>

        * In all files, changed the standard copyright notice to say
        "GIMP - The GNU Image Manipulation Program".
2006-12-09 21:33:38 +00:00
099bb0a811 update the configuration dialog when then color configuration is changed.
2006-11-03  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_lcms.c: update the configuration dialog when
	then color configuration is changed.

	* plug-ins/common/lcms.c: be even more robust.
2006-11-03 22:26:39 +00:00
c422b2b397 use gimp_any_to_utf8().
2006-11-03  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: use gimp_any_to_utf8().
2006-11-03 14:46:40 +00:00
e2dfb22cba plug-ins/common/flarefx.c (flare_center_create) don't expand the
2006-11-02  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/flarefx.c (flare_center_create)
	* plug-ins/common/nova.c (nova_center_create): don't expand the
	coordinates widget horizontally.

	* plug-ins/common/lcms.c: added padding.
2006-11-02 13:21:59 +00:00
b8742dc4ba improved wording.
2006-11-02  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: improved wording.
2006-11-02 09:22:43 +00:00
0370337796 always deal with embedded color profiles.
2006-11-01  Sven Neumann  <sven@gimp.org>

	* app/file/file-open.c: always deal with embedded color profiles.

	* app/dialogs/preferences-dialog.c: reordered items in Color
	Management section, added some spacing.

	* app/config/gimprc-blurbs.h
	* libgimpconfig/gimpcolorconfig.c
	* plug-ins/common/lcms.c: string changes for consistency.
2006-11-01 14:09:29 +00:00
7bdcd35ac8 redid the dialog without using markup.
2006-11-01  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: redid the dialog without using markup.
2006-11-01 12:25:55 +00:00
a16e7158db improved dialog.
2006-11-01  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: improved dialog.
2006-11-01 03:09:47 +00:00
e9a778e0e3 removed debugging output 2006-11-01 01:43:05 +00:00
40425620f2 in interactive mode, return an extra boolean indicating the choide for the
2006-11-01  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: in interactive mode, return an extra
	boolean indicating the choide for the "Don't ask me again"
toggle.

	* app/plug-in/plug-in-icc-profile.c: look for the extra return
	value and update the "color-profile-policy" in gimprc.
2006-11-01 00:30:46 +00:00
a25b00fcd9 plug-ins/common/plugin-defs.pl link lcms with libgimpui.
2006-10-31  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/plugin-defs.pl
	* plug-ins/common/Makefile.am: link lcms with libgimpui.

	* plug-ins/common/lcms.c: added a confirmation dialog, work in
	progress...
2006-10-31 22:54:13 +00:00
655ac187a1 app/plug-in/plug-in-icc-profile.c the plug-in doesn't handle GRAY* images.
2006-10-29  Sven Neumann  <sven@gimp.org>

	*  app/plug-in/plug-in-icc-profile.c
	*  plug-ins/common/lcms.c: the plug-in doesn't handle GRAY*
images.
2006-10-29 17:53:12 +00:00
d08399f645 update the profile information from an idle handler.
2006-10-26  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpimageprofileview.[ch]: update the profile
	information from an idle handler.

	* plug-ins/common/lcms.c: bug fixes and robustness.
2006-10-26 14:11:14 +00:00