Commit Graph

445 Commits

Author SHA1 Message Date
9331ef2456 libgimpwidgets: change GimpController's stock_id to icon_name
This API change is OK since the entire controller API is marked as
unstable and needs a special #define to be visible at all.
2014-05-09 09:19:06 +02:00
5ec413a5e8 Bug 729326 - Errors found using a static code analysis program cppcheck
Fixed some memory and file leaks. And removed some code and variables
that are not used.
2014-05-05 10:34:08 +02:00
b34fbb21fc modules: Add missing include.
614c61a3dd removed the #include <glib.h>,
which is needed for the #ifdef G_OS_WIN32 to work.
2014-04-15 19:17:57 -04:00
614c61a3dd Don't #include <glib.h> before <lcms.h>
The include claimed to be because of "inline" in the lcms header, but
that was probably lcms1, since there is no trace of inline in the
lcms2 header.
2014-04-10 20:48:22 +02:00
661317f74c libgimpwidgets: make using GimpColorProfileComboBox easier
If the passed dialog is a GimpColorProfileChooserDialog, handle its
"response" signal automatically and also destroy it when the combo box
is destroyed (before we leaked all dialogs). Remove the same callback
from all places using GimpColorProfileComboBox.
2014-04-04 17:09:54 +02:00
3f826d02fa libgimpwidgets: make GimpColorProfileComboBox use lcms
and improve gimp_color_profile_combo_box_set_active() to get the
profile's label from the ICC file if no label was provided. Simplifies
all its callers and removes code duplication.
2014-04-02 13:03:52 +02:00
d7037650df libgimpcolor: add gimp_lcms_profile_get_label()
which returns a string meant to label the profile in the GUI, it's
either the profile's description, its model, or "(unnamed profile)" as
a fallback. Use the function instead of duplicating that logic
inconsistently and imcompletely all over the place.
2014-03-30 03:12:42 +02:00
32e47cf70d libgimpcolor: add gimp_lcms_profile_is_equal()
and remove all of our own MD5 digest code and API. is_equal() uses
lcms' own MD5 API which I missed before. Thanks Elle for pointing that
out :)
2014-03-29 10:40:47 +01:00
b3395d989e libgimpcolor: return an optional MD5 digest from gimp_lcms_create_srgb_profile()
pass NULL in most places, use the feature in the lcms.c plu-gin.
2014-03-23 23:34:47 +01:00
191b2aa2e8 modules: verify that GimpColorConfig.rgb_profile is actually for RGB 2014-03-23 21:16:39 +01:00
251dd91395 modules: fix memory leaks in color-selector-cmyk.c
Also clean up a bit and make the profile label's tooltip show
the profile's summary.
2014-03-16 15:57:14 +01:00
ebc53672cb libgimpcolor: add gimp_lcms_profile_is_rgb() and _is_cmyk()
And change all lcms code to use it.
2014-03-15 21:47:13 +01:00
a277a5b66f modules: don't use CamelCase variable names in display-filter-proof.c 2014-03-15 21:47:13 +01:00
89b489b9bb modules, plug-ins: use GimpColorProfileChooserDialog
instead of selfmade file choosers for picking color profiles from
disk.
2014-03-14 23:02:14 +01:00
ceb31cc02e modules: use gimp_lcms_profile_get_summary() in the lcms display filter 2014-03-14 20:26:15 +01:00
eee6fa1e4b libgimpcolor: start adding profile utility functions to gimplcms.[ch]
Add functions to get a profile's description, manufacturer, model and
copyright, and use them instead of implementing the same 10 times.

Also add a GimpColorProfile typedef which avoids both having to
include lcms globally or using a gpointer instead (which looks bad and
non-descriptive in an API).
2014-03-14 01:48:39 +01:00
f078cc5992 modules: make display-filter-lcms.c find the right monitor...
...when its GimpColorManaged's GdkWindow exists but is hidden, which
happens for all but the active tab of a single window with multiple
images open.
2014-03-13 22:39:03 +01:00
05c5ca3216 Bug 723787 - Neutral sRGB profile matching Argyllcms sRGB.icm
Add gimp_lcms_create_srgb_profile() to libgimpcolor and use it where
we used to call cmsCreate_sRGBProfile().
2014-02-09 23:10:56 +01:00
84c132addc Bug 721553 - License text contains obsolete FSF postal address
These files were forgotten when changing license from GPL2 to GPL3.
2014-01-05 14:25:46 +01:00
a4821914d3 Bug 720045 - Add black point compensation to Preferences/Color Management
Make black point compensation configurable separately for both proof
and display.
2013-12-09 02:23:31 +01:00
1bb379c3f5 gimpcolorwheel: comment out ineffectual code 2013-11-07 12:20:34 +01:00
c028580ae0 color-selector-cmyk: avoid freeing uninitialized pointer 2013-11-07 12:20:33 +01:00
48582d4d6a modules: silence defined but not used warning in color-selector-water.c
by uselessly calling colorsel_water_get_type().
2013-11-04 22:09:57 +01:00
7027d3cb13 modules: include <gegl.h> in controller-dx-dinput.c
when we include "libgimpwidgets/gimpwidgets.h"
2013-11-04 21:25:22 +01:00
71b189e4da modules: rename color-selector-cmyk-lcms.c to color-selector-cmyk.c
overwriting the old color-selector-cmyk.c
2013-11-03 22:06:51 +01:00
7bd4d2678a configure, plug-ins, modules: make lcms a hard dependency 2013-11-03 21:19:51 +01:00
ae9d8c72bc modules: add GEGL_LIBS to display_filter_libadd 2013-11-03 15:33:40 +01:00
337c1fe4bf modules: port the proof display filter to convert_buffer() 2013-11-02 14:53:48 +01:00
73f5e2c21a modules: remove the old convert_surface() from gamma and high contrast 2013-11-02 14:47:54 +01:00
e96b1db023 modules: implement convert_buffer() in the color blind display filter 2013-11-02 14:43:47 +01:00
78706f7796 modules: implement convert_buffer() in the lcms display filter 2013-11-02 03:02:09 +01:00
fcd457e67b modules: implement convert_buffer() in the gamma display filter 2013-11-02 01:51:05 +01:00
a04c442e69 modules: implement convert_buffer() in the high contrast display filter 2013-11-02 01:38:50 +01:00
a5d4f3ae04 modules: also include <gegl.h> when we include "libgimpwidgets/gimpwidgets.h 2013-11-01 22:30:36 +01:00
3838a8cebb modules: small tabs replacement into spaces. 2013-09-21 18:17:34 +12:00
2cd25ec863 modules: turn GimpColorWheel into a proper dynamically loaded type
So it works with all GObject versions, until we determine how useful
it is generally, and what API it should get for possible
libgimpwidgets inclusion.
2013-07-14 13:41:29 +02:00
ec786816bb */Makefile.am: merge INCLUDES into AM_CPPFLAGS
automake-1.13 finally warns about this anachronism.
2013-06-05 20:48:37 +02:00
3c006d0a4f modules: make all get_type() functions static 2013-01-17 20:57:50 +01:00
9f610ef3cf modules: use G_DEFINE_DYNAMIC_TYPE() in color-selector-cmyk-lcms 2013-01-17 20:56:58 +01:00
632c577f18 Bug 689371 - GIMP uses deprecated GtkHSV widget
Swallow GtkHSV back into GIMP and call it GimpColorWheel. Keep it in
modules/ for the time being. Clean up and undeprecate it. Replace
set_metrics() API by set_ring_fraction() and make it follow the size
of its parent container, making its use straightforward. Kept it clean
of GIMP color types so it can be easily adapted by e.g. Inkscape.
2013-01-06 02:56:59 +01:00
2d6a880b12 Bug 662739 - Port to lcms2 for icc V4 profile support
Apply patch from Laurent Martelli which multiplies the out-of-gammut
color components by 256 to match the new 16 bit lcms data type.
2012-10-24 18:19:33 +02:00
3cb7f05e73 modules: mark new string for translation 2012-09-25 22:15:34 +02:00
e8b24abbf7 modules: say "(unnamed profile)" when a color profile provides no name
inatead of showing an empty label
2012-09-25 20:56:05 +02:00
a2e037fb00 Corrected spelling errors spotted by Ari Pollak (Mostly fixes bug #683694)
Still need to address the "allows to" grammatical error.
2012-09-10 12:22:12 -04:00
8bbfc9e5cf Bug 675558 - switch from lcms-1 to lcms-2
Applied modified patch from Hartmut Kuhse which ports to lcms-2.
2012-09-03 20:03:53 +02:00
9514cf4871 Avoid using CMFlattenProfile
This symbol is not available to 64-bit applications.  So put another
approach in place.

I can confirm that the code does not crash, but I do not know if it
works properly.  Mitch forced me to push anyway.
2012-06-09 22:47:01 +02:00
3ad73b3658 libgimpcolor: add GdkPixbuf <-> GeglBuffer utility functions
and update tons of includes in libgimp and app.
2012-05-03 03:37:20 +02:00
2b2315deea modules: forgot one #include <babl/babl.h> 2012-05-02 17:50:54 +02:00
3e119c5af7 libgimpcolor: add gimp_rgb[a]_set,get_pixel()
which converts from/to any pixel format using Babl. Added tons of
includes and CFLAGS now that libgimpcolor publically uses Babl.
2012-05-02 17:50:43 +02:00
056e09a6cb Remove the makefile.msc build system, it is unmaintained since 2008 2011-12-16 15:53:56 +01:00