Add a GTK+ patch that makes sure that list-style combo-box popups
are never narrower than their content. This fixes the popup width
when using the System theme on Windows, for combo-boxes whose popup
cell-layout is wider than the combo-box cell-layout. It is also
required for the next commit.
In all themes, fix the color of selected text, while editing a
tree-view's item text (such as when renaming a layer), by
overriding tree-view specific styling with the global text-entry
style, for nested text entries inside tree-views. The text would
previously use the same color as the selection background, making
it unreadable.
This issue affects the Dark and Gray themes, although this fix only
takes care of the Dark theme.
Apply the check/radio-button style to GtkTreeView, so that
GtkCellRendererToggle picks the right check/radio-button graphic.
Otherwise, it falls back to a graphic that depends on the system
theme, and which may not play well with the current theme colors.
Note that this only affects the Dark theme; in the Light and Gray
themes, one of the KDE-hack styles "takes care" of this, but this
commit applies the same change to these themes anyway.
Commit 6484e91f82 broke the arrow
color of menu items with a submenu in the Dark theme; it seems to
have always been broken in the Light and Gray themes.
Fix this, by applying the default style to the GtkMenuItem class.
... for applying the global style.
Last commit *might* have fixed the need to use "*" instead of
"GtkWidget", although it's hard to tell -- nothing seems to be
obviously wrong, anyway. Let's just try restoring this, and see if
anything breaks.
In the gtkrc files of the Dark and Light themes, replace a bunch of
"widget" selectors with "widget_class" selectors, which is what
they really should be (they should probably also use angle-bracket
notation for classes, but as long as it works...) This allows the
different styles to be merged correctly, and fixes the active layer
name color (more generally, the text color of selected rows of
focused tree-views inside dockables.) The Gray theme seems to be
double-broken in such a way that "fixing" it causes it to do the
"wrong" thing... I'm not touching that :)
... the python console.
It was using "selected text", which is most often inverted color (close
if not identical to the background color). As a consequence, it made
stdout output unreadable by default, forcing themes to always define a
style for the python console. Using "normal text" is a much better
choice to default to something readable from a parent style.
As a consequence, I also removed "python-fu-console" styling from the
System theme, where there should be as few theming as possible.
I mostly copy-pasted from Dark and Light theme which already had this
style set since previous commit. If anyone wants to finetune colors, be
my guest!
s/gtk-application-prefer-gimp-dark-theme/gtk-application-prefer-dark-theme/
I'm actually not sure if this property is supposed to be in the gtkrc
file. It looks like it is available only from GTK+3, and isn't it more
of an application settings in order to select the right theme variant,
rather than a specific theme settings?
Anyway let's at least set the right property name.
This is to be used as self-documentation code, so that people know
how to hack the font size since I am not sure GIMP will always provide
reasonable font display on every platform.
Since we have many themes now, this new name better indicates that it
is meant to follow your desktop theme settings.
Also it will likely not remain the default theme.
spin-fill-bg.png added in commit 0d692ea but not installed.
Fixes the following theme warning:
> Unable to locate image file in pixmap_path: "ui/spin-fill-bg.png"
Updates to copyright, some button contrast for TDSOG, TDLSOG. Added comment
for button focus area. Fixed selected text for TLSOG themes. Redid screenshots
to match changes. Fixed menu style name. Updated copyright year. Fixed menu
items for Ubuntu unity. Fixed prelight and fg for widget text. Updated to
v0.1.6.
Both new themes were outputting the following warning for gap_left.png:
"Invalid borders specified for theme pixmap"
"borders don't fit within the image"
The problem was that the sum of the left and right gap borders cannot be
more than the gap file width (2 px in our case).
All our new themes should now use a common gtkrc base. Colors only
should be different, as included from a colorrc. This way we ensure a
consistent behavior throughout all themes.
Also we should use meaningful color names to make maintenance easy.
entry-border-fill-active-item is not used anymore (commit 2144a7c).
gimp-arrow-right-prelight seems as well for some time.
Adding menuitem-prelight (commit 127fdff and 2144a7c).
Fixed display issues for The-Dark-Side-of-Gimp under KDE (QtCurves &
Oxygen-GTK) themes, and Gnome users (Ubuntu). Removed focus padding &
lines to bring look closer to the Default theme. Updated button look
to harmonize with possible future grey and light themes.
Initial version of our dark theme.
Additional credits for some of the UI images to horst3180 (Ceti-2 theme)
and Medhi Abhollahi (new CS6 II theme). All under GPLv3, as the rest
of GIMP.
