Adding patch by Massimo Valentini (@Massimo) for what is seemingly a bug
in GTK+2.24 in Windows.
The bug does not seem to happen on GIMP 3 (according to contributor
tests), so the bug/patch is likely not relevant anymore on GTK+3. So
let's just add this patch in our official GIMP build and be done with
it.
Unfortunately the dist target requires pygtk.
Note that even adding --disable-python to DISTCHECK_CONFIGURE_FLAGS
doesn't help as pygtk-codegen-2.0 is needed to generate various .defs
file added to the DIST.
Yet pygtk is absent from Debian testing nowadays because it is too old
and unmaintained. So let's build pygtk ourselves.
Among the few tricks to make pygtk build fine:
- force Python2 by setting PYTHON env variable (detect Python 3
otherwise).
- patch to allow building against latest Pango.
... by qualifying them with "extern", in addition to
"__declspec(dllexport)". Omitting "extern" happened to work in the
past, but recent GCC versions require it.
Our installer use Msys2 packages when possible. And Msys2 repository
provides version 0.3.9, released on March 2, which contains our patches.
No need for them here anymore, no need to make custom builds.
(cherry picked from commit 0aca033370)
Actual patch contributor wants confidentiality to avoid leaking
proprietary information or whatever (I am not sure either what to be
scared of as it's all good and harmless to me, but let's respect the
request). See also #4246 for more details.
(cherry picked from commit 370499676f)
Several of our own translations of the Windows installer are unused
because Inno Setup corresponding translations are marked "unofficial".
This mostly means that the language files for these are probably old and
unmaintained, hence outdated. And these files are not bundled together
with Inno Setup release (though still hosted in their repo).
Nevertheless it doesn't make sense that we would just waste the work of
our translators here. Maybe Inno Setup localization is not complete, so
what? At best it could even encourage translators to contribute upstream
to Inno Setup. Let's just enable all our current localizations of the
installer and see how it goes!
(cherry picked from commit 01f258faec)
Add a GTK+ patch providing a "popup-style" combo-box style
property, allowing to manually control the combo-box popup-style.
Use the LIST style for all combo-boxes in our system-wide gtkrc
file; this only has effect if GTK+ was built with the above patch.
Add a GTK+ patch that makes sure that list-style combo-box popups
are never narrower than their content. This fixes the popup width
when using the System theme on Windows, for combo-boxes whose popup
cell-layout is wider than the combo-box cell-layout. It is also
required for the next commit.
