Commit Graph

2487 Commits

Author SHA1 Message Date
cd5973a654 add a few strategically placed return TRUEs to stop event propagation.
2007-09-23  Simon Budig  <simon@gimp.org>

	* plug-ins/common/bumpmap.c: add a few strategically placed
	return TRUEs to stop event propagation.

	Fixes bug #479389


svn path=/trunk/; revision=23620
2007-09-23 01:15:28 +00:00
24c4243f28 General fix for bug #478657:
2007-09-21  Sven Neumann  <sven@gimp.org>

	General fix for bug #478657:

	* libgimp/gimpaspectpreview.c
	* libgimp/gimpdrawablepreview.c
	* libgimp/gimpzoompreview.c: let all preview widgets store the
	state of the Preview toggle. Declared "toggle" parameter as unused.

	* plug-ins/common/*.c: pass NULL for "toggle" to
	gimp_drawable_preview_new() and gimp_aspect_preview_new().

svn path=/trunk/; revision=23603
2007-09-21 13:27:33 +00:00
e2fcc1fc6e added placeholder Edit/Preferences and move the preferences and keyboard
2007-09-20  Michael Natterer  <mitch@gimp.org>

	* menus/image-menu.xml.in: added placeholder Edit/Preferences and
	move the preferences and keyboard shortcut dialogs there.

	* plug-ins/common/uniteditor.c (query): register the unit editor
	there too.


svn path=/trunk/; revision=23594
2007-09-20 11:39:32 +00:00
04b4982220 removed extra arguments that were added to the compose procedures in the
2007-09-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/compose.c: removed extra arguments that were
	added to the compose procedures in the 2.3 development cycle.
	Restores compatibility and fixes bug #477795.


svn path=/trunk/; revision=23590
2007-09-19 16:56:34 +00:00
88759a35e9 Applied slightly modified patch from John Marshall that drops adjustment
2007-09-17  Martin Nordholts  <martinn@svn.gnome.org>

	* plug-ins/common/psd-load.c (do_layer_record, load_image):
	Applied slightly modified patch from John Marshall that drops
	adjustment and layer group layers when loading PSD files. Fixes
	bug #474718.

svn path=/trunk/; revision=23576
2007-09-17 19:11:25 +00:00
b4c39928a6 verify that the bytesperline header field (number of bytes to allocate per
2007-09-17  Nils Philippsen  <nphilipp@redhat.com>
* plug-ins/common/pcx.c (load_image): verify that the bytesperline header
field (number of bytes to allocate per plane and line) isn't less than the
width of the image

svn path=/trunk/; revision=23574
2007-09-17 18:56:34 +00:00
046f0ef21e flush the displays at the end.
2007-09-17  Simon Budig  <simon@gimp.org>

	* plug-ins/common/decompose.c: flush the displays at the end.

	Fixes bug #477008.


svn path=/trunk/; revision=23570
2007-09-17 00:29:28 +00:00
ec11dbc1a1 remove FOO_DISABLE_DEPRECATED for only glib >= 2.15 and gtk+ >= 2.13, GIMP
2007-09-13  Michael Natterer  <mitch@gimp.org>

	* configure.in: remove FOO_DISABLE_DEPRECATED for only glib >= 2.15
	and gtk+ >= 2.13, GIMP builds fine against the 2.14 and 2.12 APIs
	apart from:

	* app/tools/gimpselectionoptions.c
	* libgimpwidgets/gimphelpui.c: undef GTK_DISABLE_DEPRECATED because
	GtkTooltips is deprecated in gtk+ 2.12.

	* libgimp/gimpui.c
	* plug-ins/common/pat.c: the address of an array is always
	non-NULL, no need to check for that. Fixes new gcc warnings.


svn path=/trunk/; revision=23522
2007-09-13 10:44:07 +00:00
8c99fcc50e remember color conversion parameters (bug #475966).
2007-09-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: remember color conversion parameters
	(bug #475966).

svn path=/trunk/; revision=23507
2007-09-12 09:24:54 +00:00
66b409c354 fixed loading of PGM files with maxval of 1 (bug #475991).
2007-09-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/pnm.c (pnm_load_ascii): fixed loading of PGM
	files with maxval of 1 (bug #475991).


svn path=/trunk/; revision=23505
2007-09-12 07:15:38 +00:00
471eed6bab fixed use of black-point-compensation parameter (bug #475952).
2007-09-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: fixed use of black-point-compensation
	parameter (bug #475952).


svn path=/trunk/; revision=23504
2007-09-12 06:21:05 +00:00
de5184c824 don't use "major" and "minor" as variable names, they may conflict with
2007-09-11  Manish Singh  <yosh@gimp.org>

        * plug-ins/common/psp.c: don't use "major" and "minor" as variable
        names, they may conflict with system symbols.

svn path=/trunk/; revision=23503
2007-09-11 22:48:03 +00:00
aeadf45cfa update the preview on "value-changed", instead of "refval-changed". Fixes
2007-09-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/spread.c (spread_dialog): update the preview on
	"value-changed", instead of "refval-changed". Fixes bug #469360.

svn path=/trunk/; revision=23500
2007-09-11 13:24:15 +00:00
563bb6fe80 allow to specify rendering intent and black point compensation. Fixes bug
2007-09-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: allow to specify rendering intent and 
	black point compensation. Fixes bug #474787.

svn path=/trunk/; revision=23497
2007-09-11 09:37:38 +00:00
a38de20058 applied patch from Aurimas Juška which simplifies the code by using
2007-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lens.c: applied patch from Aurimas Juška which
	simplifies the code by using GimpPixelFetcher and fixes handling
	of selections in the preview. Fixes the last aspect of bug #356716.

svn path=/trunk/; revision=23495
2007-09-10 16:05:40 +00:00
0567768821 applied patch from Nils Philippsen that fixes an endianess problem (bug
2007-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/psp.c: applied patch from Nils Philippsen that
	fixes an endianess problem (bug #475464).

svn path=/trunk/; revision=23492
2007-09-10 13:37:39 +00:00
c35f4644da copy the alpha channel to the destination region. Fixes bug #473998.
2007-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_drawable_transform): copy the alpha
	channel to the destination region. Fixes bug #473998.

svn path=/trunk/; revision=23491
2007-09-10 13:26:02 +00:00
e246544a92 convmatrix.c: oops, there was still an unused variable hanging around.
svn path=/trunk/; revision=23469
2007-09-06 11:29:31 +00:00
005badf3ac there is no need to mess with the selected channels within check_config().
2007-09-06  Simon Budig  <simon@gimp.org>

	* plug-ins/common/convmatrix.c: there is no need to mess
	with the selected channels within check_config(). Also fix
	bug with with copying its values into the chanmask
	in convolve_image()

	Fixes bug #472518


svn path=/trunk/; revision=23468
2007-09-06 10:00:21 +00:00
8642b014ca fixed subtle cut'n'paste bug, made the code a little bit more readable.
2007-08-31  Simon Budig  <simon@gimp.org>

	* plug-ins/common/antialias.c: fixed subtle cut'n'paste bug,
	made the code a little bit more readable.


svn path=/trunk/; revision=23421
2007-08-31 01:13:33 +00:00
3cb33d8721 plug-ins/common/illusion.c plug-ins/common/polar.c applied patches from
2007-08-30  Karine Delvare  <edhel@gimp.org>

	* plug-ins/common/illusion.c
	* plug-ins/common/polar.c
	* plug-ins/common/whirlpinch.c: applied patches from Aurimas Juška
	that fixes use of the GimpZoomPreview widget in those plug-ins (see
	bug #356716), and makes illusion handle selections properly.


svn path=/trunk/; revision=23416
2007-08-30 16:44:10 +00:00
e21b1dce84 applied modified patch from Nils Philippsen that adds more sanity checks
2007-08-30  Raphael Quinet  <raphael@gimp.org>

	* plug-ins/common/pcx.c: applied modified patch from Nils
	Philippsen that adds more sanity checks when loading and saving
	images.  Fixes the reopened bug #471189.

svn path=/trunk/; revision=23409
2007-08-30 11:49:52 +00:00
558bdfc4ed Randomizing hue of desaturated pixels before increasing saturation. Fixes
2007-08-30  Jakub Friedl  <jfriedl@suse.cz>

	* plug-ins/common/scatter_hsv.c: Randomizing hue of desaturated
	pixels before increasing saturation. Fixes #471476.


svn path=/trunk/; revision=23407
2007-08-30 10:09:51 +00:00
f935d6bd7a Calling randomize_value with max value 359 instead of 360 to fix off by 1
2007-08-29  Jakub Friedl  <jfriedl@suse.cz>

	* plug-ins/common/scatter_hsv.c: Calling randomize_value with
	max value 359 instead of 360 to fix off by 1 error when wrapping
        around.


svn path=/trunk/; revision=23397
2007-08-29 13:35:53 +00:00
d32c7ca45f Removes the fprint function. Values are printed using g_snprintf and "%g"
2007-08-29  Jakub Friedl  <jfriedl@suse.cz>

	* plug-ins/common/convmatrix.c: Removes the fprint function.
	Values are printed using g_snprintf and "%g" which supresses
	trailing zeroes. Fixes bug #471051.


svn path=/trunk/; revision=23396
2007-08-29 12:10:56 +00:00
24ad8c8200 applied modified patch from Nils Philippsen that uses the glib endianness
2007-08-29  Raphael Quinet  <raphael@gimp.org>

	* plug-ins/common/pcx.c: applied modified patch from Nils
	Philippsen that uses the glib endianness conversion macros instead
	of the ones provided in the old code (broken on S390/S390x).
	Fixes bug #471189.

svn path=/trunk/; revision=23394
2007-08-29 12:01:01 +00:00
c53ed0aba8 gimp-selection-* procedures operate on the image_ID, not on the selection
2007-08-29  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/lcms.c (lcms_image_apply_profile):
	gimp-selection-* procedures operate on the image_ID, not on the
	selection drawable_ID itself. Fixes bug #470589. Also remove the
	saved selection channel after reloading it.


svn path=/trunk/; revision=23393
2007-08-29 11:42:38 +00:00
4f4d1bf384 CLAMP()ing the red value so that it is in the 0-255 range. Fixes bug
2007-08-28  Jakub Friedl  <jfriedl@suse.cz>

	* plug-ins/common/redeye.c: CLAMP()ing the red value
	so that it is in the 0-255 range. Fixes bug #470914.


svn path=/trunk/; revision=23386
2007-08-28 11:16:50 +00:00
091b202065 stylistic cleanup.
2007-08-24  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/scatter_hsv.c: stylistic cleanup.


svn path=/trunk/; revision=23359
2007-08-24 13:49:05 +00:00
5669fb5da3 fixing bug #469519 and some cleanup.
2007-08-24  Jakub Friedl  <jfriedl@suse.cz>

  * plug-ins/common/scatter_hsv.c: fixing
    bug #469519 and some cleanup.


svn path=/trunk/; revision=23358
2007-08-24 12:46:48 +00:00
57ffb727f2 applied patch from Aurimas Juška to fix bug #467368.
2007-08-16  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/whirlpinch.c: applied patch from Aurimas Juška 
to
	fix bug #467368.


svn path=/trunk/; revision=23295
2007-08-16 19:12:37 +00:00
3b1795ab9d applied patch from Aurimas Juška to fix bug #467369.
2007-08-16  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/polar.c: applied patch from Aurimas Juška to 
fix
	bug #467369.


svn path=/trunk/; revision=23294
2007-08-16 19:10:55 +00:00
7cdc24d69e libgimpwidgets/gimpcolorprofilecombobox.[ch]
2007-08-14  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpcolorprofilecombobox.[ch]
	* libgimpwidgets/gimpcolorprofilestore.[ch]
	* libgimpwidgets/gimpcolorprofilestore-private.h: changed API to
	deal with filenames instead of URIs.

	* app/widgets/gimpprofilechooserdialog.[ch]: same here.

	* app/dialogs/preferences-dialog.c
	* plug-ins/common/lcms.c: changed accordingly.


svn path=/trunk/; revision=23260
2007-08-14 22:12:37 +00:00
dd7c014e09 set the URI of the profile, not the filename
svn path=/trunk/; revision=23255
2007-08-14 16:16:33 +00:00
e825b7ccb1 app/dialogs/preferences-dialog.c don't unref the file-chooser dialog.
2007-08-14  Sven Neumann  <sven@gimp.org>

	* app/dialogs/preferences-dialog.c
	* plug-ins/common/lcms.c: don't unref the file-chooser dialog.

svn path=/trunk/; revision=23254
2007-08-14 16:10:08 +00:00
f3675a45ad libgimpwidgets/Makefile.am libgimpwidgets/gimpwidgets.h
2007-08-14  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/Makefile.am
	* libgimpwidgets/gimpwidgets.h
	* libgimpwidgets/gimpwidgetstypes.h
	* libgimpwidgets/gimpcolorprofilecombobox.[ch]
	* libgimpwidgets/gimpcolorprofilestore.[ch]
	* libgimpwidgets/gimpcolorprofilestore-private.h: new widget to
	select color profiles.

	* libgimpwidgets/gimpwidgets.def: updated.

	* app/widgets/gimpprofilechooserdialog.[ch]: remember the name of
	the last previewed profile.

	* app/dialogs/preferences-dialog.c: use the new color profile
	combo-box.

	* plug-ins/common/lcms.c: use the new color profile combo-box.

svn path=/trunk/; revision=23253
2007-08-14 16:01:04 +00:00
611a104c34 plug-ins/common/dicom.c plug-ins/common/psd-load.c applied patch from Nils
2007-08-14  Raphael Quinet  <raphael@gimp.org>

	* plug-ins/common/dicom.c
	* plug-ins/common/psd-load.c
	* plug-ins/common/sunras.c: applied patch from Nils Philippsen
	that replaces several calls to g_error() by g_message() and
	gimp_quit() so that GIMP does not complain when a plug-in exits.
	Fixes bug #466610.

svn path=/trunk/; revision=23250
2007-08-14 14:15:03 +00:00
bb3fd269ac fixed calculation of alpha value (bug #466402).
2007-08-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/csource.c (save_image): fixed calculation of
	alpha value (bug #466402).

svn path=/trunk/; revision=23247
2007-08-14 09:04:01 +00:00
9b7db4c28d further work on the dialog.
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: further work on the dialog.



svn path=/trunk/; revision=23219
2007-08-11 19:50:58 +00:00
52531a45a5 factored out code to a utility function.
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: factored out code to a utility 
function.


svn path=/trunk/; revision=23216
2007-08-11 19:30:12 +00:00
5a748730fd don't open the destination profile twice.
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: don't open the destination profile 
twice.


svn path=/trunk/; revision=23215
2007-08-11 19:14:11 +00:00
a211b4ffd4 if the image has a selection, save it, unset it and restore it after the
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_icc_apply): if the image has a
	selection, save it, unset it and restore it after the 
conversion.


svn path=/trunk/; revision=23214
2007-08-11 18:55:24 +00:00
3b2ed82ef5 plug-ins/common/lcms.c plug-ins/common/png.c plug-ins/common/tiff-load.c
2007-08-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c
	* plug-ins/common/png.c
	* plug-ins/common/tiff-load.c
	* plug-ins/jpeg/jpeg-load.c: made the icc-profile undoable and
	persistent.
	
	* devel-docs/parasites.txt: document this.

	* plug-ins/common/lcms.c: made colorspace conversion undoable.
	
	* app/file/file-open.c: disable undo while doing the colorspace
	conversion on load.


svn path=/trunk/; revision=23213
2007-08-11 18:27:01 +00:00
7f5d403615 added "<Image>/Image/Mode/Color Profile" as a placeholder below the Image
2007-08-11  Sven Neumann  <sven@gimp.org>

	* menus/image-menu.xml.in: added "<Image>/Image/Mode/Color 
Profile"
	as a placeholder below the Image Mode radio items.

	* plug-ins/common/lcms.c (query): register menu entries to 
assign
	and apply color profiles. Dialog implementation is still 
missing...



svn path=/trunk/; revision=23211
2007-08-11 16:30:12 +00:00
abbd60c5e6 fixed a bug that I introduced earlier today.
2007-08-08  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (lcms_image_get_profile): fixed a bug
	that I introduced earlier today.


svn path=/trunk/; revision=23153
2007-08-08 18:03:29 +00:00
4ab3e92782 modules/cdisplay_lcms.c corrected memory handling. cmsOpenProfileFromMem()
2007-08-08  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_lcms.c
	* plug-ins/common/lcms.c: corrected memory handling.
	cmsOpenProfileFromMem() actually copies the data.

	* libgimpwidgets/gimpcolordisplay.c
	* libgimpwidgets/gimpcolordisplaystack.c: disconnect in dispose().

svn path=/trunk/; revision=23148
2007-08-08 12:27:11 +00:00
ce4675a17d don't write the sRGB chunk if the user asked for the gAMA chunk
svn path=/trunk/; revision=23136
2007-08-07 14:25:40 +00:00
80e10f9200 in the absence of an embedded color profile, write the sRGB chunk.
2007-08-07  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/png.c (save_image): in the absence of an
	embedded color profile, write the sRGB chunk.

svn path=/trunk/; revision=23135
2007-08-07 14:15:48 +00:00
a90b367210 added the typedef here.
* plug-ins/common/poppler.c: added the typedef here.

svn path=/trunk/; revision=23131
2007-08-07 09:44:23 +00:00
b53d51ca65 simplified.
2007-08-06  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c (run): simplified.

svn path=/trunk/; revision=23123
2007-08-06 15:24:04 +00:00