callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Issue #5267: Cage transform tool causes artifacts.

Browse Source 
I somewhat bisected GEGL commits between 0.4.20 and 0.4.24 and found
that the one that introduced the env var GEGL_OPERATION_INIT_OUTPUT is
the first showing the problem.

Reviewer (Jehan) note: so it would be commit 6e9610e65c on GEGL repo.
This fix makes sense as it means that since this commit, the output
buffer could have random values. It's not a problem for any operation
where we fill every value, but I guess it's not the case for
"gimp:cage-coef-calc" which was likely relying on the old behavior of
being 0-initialized.

(cherry picked from commit 3b2a8f79f0)
This commit is contained in:
Massimo Valentini
2021-08-05 16:58:55 +02:00
committed by Jehan
parent 75871f0418
commit fcefb409e5
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/operations/gimpoperationcagecoefcalc.c
View File

@ -212,18 +212,18 @@ gimp_operation_cage_coef_calc_process (GeglOperation *operation,
n_cage_vertices = gimp_cage_config_get_n_points (config); n_cage_vertices = gimp_cage_config_get_n_points (config);
it = gegl_buffer_iterator_new (output, roi, 0, format, it = gegl_buffer_iterator_new (output, roi, 0, format,
GEGL_ACCESS_READWRITE, GEGL_ABYSS_NONE, 1); GEGL_ACCESS_WRITE, GEGL_ABYSS_NONE, 1);
while (gegl_buffer_iterator_next (it)) while (gegl_buffer_iterator_next (it))
{ {
/* iterate inside the roi */ /* iterate inside the roi */
gfloat *coef = it->items[0].data;
gint n_pixels = it->length; gint n_pixels = it->length;
gint x = it->items[0].roi.x; /* initial x */ gint x = it->items[0].roi.x; /* initial x */
gint y = it->items[0].roi.y; /* and y coordinates */ gint y = it->items[0].roi.y; /* and y coordinates */
gint j; gint j;
gfloat *coef = it->items[0].data; memset (coef, 0, sizeof * coef * n_pixels * 2 * n_cage_vertices);
while(n_pixels--) while(n_pixels--)
{ {
if (gimp_cage_config_point_inside(config, x, y)) if (gimp_cage_config_point_inside(config, x, y))