From d0fdff7117ffa0ebf9b7fa4f21b47c92f176afdc Mon Sep 17 00:00:00 2001 From: Ell Date: Wed, 10 Oct 2018 09:58:29 -0400 Subject: [PATCH] app: in GimpBacktrace Windows backend, avoid bogus symbol addresses In the GimpBacktrace Windows backend, avoid reporting meaningless symbol addresses when failing to retrieve meaningful ones. Unfortunately, it seems that we never get symbol addresses for symbols that have debug information, which negatively affects the log viewer's call graph. We're going to have to work around this. (cherry picked from commit 52772cf3ff0bb8cf6554c782cfb78af587545f83) --- app/core/gimpbacktrace-windows.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/core/gimpbacktrace-windows.c b/app/core/gimpbacktrace-windows.c index dceb8834a6..9b9e0ee67c 100644 --- a/app/core/gimpbacktrace-windows.c +++ b/app/core/gimpbacktrace-windows.c @@ -668,7 +668,7 @@ gimp_backtrace_get_address_info (guintptr address, g_strlcpy (info->symbol_name, symbol_info->Name, sizeof (info->symbol_name)); - info->symbol_address = address - offset; + info->symbol_address = offset ? address - offset : 0; result = TRUE; }