Cppcheck fixes

(cherry picked from commit 3e35fe4d80)

# Conflicts:
#	app/widgets/gimpcolordialog.c
#	libgimpwidgets/gimpchainbutton.c

app/widgets/gimpspinscale.c

@@ -382,7 +382,7 @@ pattern_to_attrs (const gchar *text,
 
   while (TRUE)
     {
-      while (*p && *q && *q != '_')
+      while (*p && q && *q != '_')
         {
           p = g_utf8_next_char (p);
           q++;

plug-ins/file-fli/fli.c

@@ -884,8 +884,8 @@ fli_write_lc (FILE          *f,
       while (xc < fli_header->width)
         {
           sc = 0;
-          while ((linebuf[xc] == old_linebuf[xc]) &&
-                 (xc < fli_header->width)         &&
+          while ((xc < fli_header->width)         &&
+                 (linebuf[xc] == old_linebuf[xc]) &&
                  (sc < 255))
             {
               xc++;

plug-ins/gfig/gfig-circle.c

@@ -147,7 +147,7 @@ d_paint_circle (GfigObject *obj)
       gdouble       angle = 0;
       gint          i = 0;
 
-      while (i < 362)
+      while (i < 361)
         {
           static const gdouble step = 2 * G_PI / 180;