From af42b25372cd9d1e3da7c8eb9b5b3b45e76ec4d6 Mon Sep 17 00:00:00 2001 From: David Odin Date: Mon, 25 Oct 2004 13:45:58 +0000 Subject: [PATCH] removed debugging g_print and remove my memory fix, since it was buggy and * plug-ins/common/newsprint.c: removed debugging g_print and remove my memory fix, since it was buggy and shouldn't be done. My fix just broke this plug-in (reported by Joao S. O. Bueno Calligaris) --- ChangeLog | 7 +++++++ plug-ins/common/newsprint.c | 12 +++++------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index f067eb87c1..091703be6c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2004-10-25 DindinX + + * plug-ins/common/newsprint.c: removed debugging g_print and + remove my memory fix, since it was buggy and shouldn't be done. + My fix just broke this plug-in (reported by Joao S. O. Bueno + Calligaris) + 2004-10-25 Simon Budig * app/tools/gimpvectortool.c: Switch to design mode when diff --git a/plug-ins/common/newsprint.c b/plug-ins/common/newsprint.c index 02cb5b6560..f5acefb412 100644 --- a/plug-ins/common/newsprint.c +++ b/plug-ins/common/newsprint.c @@ -880,8 +880,6 @@ lpi_callback (GtkAdjustment *adjustment, gimp_double_adjustment_update (adjustment, &pvals_ui.output_lpi); - g_print ("lpi (%g / %g = %d)\n", pvals_ui.input_spi, pvals_ui.output_lpi, pvals.cell_width); - g_signal_handlers_block_by_func (st->cellsize, cellsize_callback, data); @@ -902,7 +900,6 @@ spi_callback (GtkAdjustment *adjustment, gimp_double_adjustment_update (adjustment, &pvals_ui.input_spi); - g_print ("spi (%g / %g = %d)\n", pvals_ui.input_spi, pvals_ui.output_lpi, pvals.cell_width); g_signal_handlers_block_by_func (st->output_lpi, lpi_callback, data); @@ -923,7 +920,6 @@ cellsize_callback (GtkAdjustment *adjustment, gimp_int_adjustment_update (adjustment, &pvals.cell_width); - g_print ("cell (%g / %g = %d)\n", pvals_ui.input_spi, pvals_ui.output_lpi, pvals.cell_width); g_signal_handlers_block_by_func (st->output_lpi, lpi_callback, data); @@ -2063,9 +2059,11 @@ do { \ g_timer_destroy (timer); #endif - for (b = 0; b < 4; b++) - if (thresh[b]) - g_free (thresh[b]); + /* + * Note: the tresh array should *NOT* be freed. + * Its values will be reused anyway so this is NOT a memory leak. + * Well it is, but only the first time, so it doesn't matter. + */ if (preview) {