callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Issue #2685: Crash when distributing layers horizontally.

Browse Source 
Make the returned values of g_list_length() a gint to avoid implicit
type conversion converting a possibly negative integer numberator into
unsigned int (which ends as a huge unsigned int instead of being
negative).

Found by Massimo!
This commit is contained in:
Jehan
2019-07-10 17:15:12 +02:00
parent b3f7f36bda
commit a6ad02a60a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/core/gimpimage-arrange.c
View File

@ -158,14 +158,14 @@ gimp_image_arrange_objects (GimpImage *image,
(reference, "align-width")); (reference, "align-width"));
/* The offset parameter works as an internal margin */ /* The offset parameter works as an internal margin */
fill_offset = (distr_width - 2 * offset) / fill_offset = (distr_width - 2 * offset) /
g_list_length (object_list); (gint) g_list_length (object_list);
} }
if (reference_alignment == GIMP_ARRANGE_VFILL) if (reference_alignment == GIMP_ARRANGE_VFILL)
{ {
distr_height = GPOINTER_TO_INT (g_object_get_data distr_height = GPOINTER_TO_INT (g_object_get_data
(reference, "align-height")); (reference, "align-height"));
fill_offset = (distr_height - 2 * offset) / fill_offset = (distr_height - 2 * offset) /
g_list_length (object_list); (gint) g_list_length (object_list);
} }
/* FIXME: undo group type is wrong */ /* FIXME: undo group type is wrong */