callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 739003 - Crashes in file_save_dialog_response()

Browse Source 
Ref/unref the dialog around saving the image insatead of connecting to
"destroy" and NULLifying the local dialog variable on destruction,
which has caused weird crashes on fedora.
This commit is contained in:
Michael Natterer
2015-07-14 13:22:06 +02:00
parent 597a438f07
commit a0e48ad29e
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/dialogs/file-save-dialog.c
View File

@ -159,7 +159,6 @@ file_save_dialog_response (GtkWidget *save_dialog,
GFile *file;
gchar *basename;
GimpPlugInProcedure *save_proc;
gulong handler_id;
if (! dialog->export)
{
@ -182,9 +181,7 @@ file_save_dialog_response (GtkWidget *save_dialog,
return;
}
handler_id = g_signal_connect (dialog, "destroy",
G_CALLBACK (gtk_widget_destroyed),
&dialog);
g_object_ref (dialog);
switch (file_save_dialog_check_file (save_dialog, gimp,
&file, &basename, &save_proc))
@ -247,9 +244,7 @@ file_save_dialog_response (GtkWidget *save_dialog,
g_object_unref (file);
g_free (basename);
if (dialog)
gimp_file_dialog_set_sensitive (dialog, TRUE);
gimp_file_dialog_set_sensitive (dialog, TRUE);
break;
case CHECK_URI_SWITCH_DIALOGS:
@ -261,8 +256,7 @@ file_save_dialog_response (GtkWidget *save_dialog,
break;
}
if (dialog)
g_signal_handler_disconnect (dialog, handler_id);
g_object_unref (dialog);
}
/* IMPORTANT: When changing this function, keep