From 9f25f8608b9c48240b51c6a4745ae768b7f397fc Mon Sep 17 00:00:00 2001 From: Sven Neumann Date: Tue, 6 Jul 2004 22:58:33 +0000 Subject: [PATCH] adapt the arrow key velocity to the display scale factor. Please test and 2004-07-07 Sven Neumann * app/tools/gimpeditselectiontool.c (gimp_edit_selection_tool_key_press): adapt the arrow key velocity to the display scale factor. Please test and complain if you dislike this behaviour. * themes/Default/images/Makefile.am * themes/Default/images/stock-color-pick-from-screen-16.png: new icon drawn by Jimmac. * libgimpwidgets/gimpstock.[ch]: register the new icon. * libgimpwidgets/gimppickbutton.c: use it for the screen color picker instead of reusing the color picker tool icon. --- ChangeLog | 16 +++++++++ app/tools/gimpeditselectiontool.c | 34 ++++++++++-------- devel-docs/ChangeLog | 5 +++ .../libgimpwidgets-sections.txt | 2 ++ devel-docs/libgimpwidgets/tmpl/gimpstock.sgml | 14 ++++++++ libgimpwidgets/gimppickbutton.c | 2 +- libgimpwidgets/gimpstock.c | 2 ++ libgimpwidgets/gimpstock.h | 1 + themes/Default/images/Makefile.am | 1 + .../stock-color-pick-from-screen-16.png | Bin 0 -> 608 bytes 10 files changed, 62 insertions(+), 15 deletions(-) create mode 100644 themes/Default/images/stock-color-pick-from-screen-16.png diff --git a/ChangeLog b/ChangeLog index 3a76f4de4f..5e528f8bcf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,19 @@ +2004-07-07 Sven Neumann + + * app/tools/gimpeditselectiontool.c + (gimp_edit_selection_tool_key_press): adapt the arrow key velocity + to the display scale factor. Please test and complain if you + dislike this behaviour. + + * themes/Default/images/Makefile.am + * themes/Default/images/stock-color-pick-from-screen-16.png: new + icon drawn by Jimmac. + + * libgimpwidgets/gimpstock.[ch]: register the new icon. + + * libgimpwidgets/gimppickbutton.c: use it for the screen color + picker instead of reusing the color picker tool icon. + 2004-07-06 Bill Skaggs * plug-ins/gfig/*.[ch]: a bunch of code clean-up and diff --git a/app/tools/gimpeditselectiontool.c b/app/tools/gimpeditselectiontool.c index a2a475383c..8b1d86941d 100644 --- a/app/tools/gimpeditselectiontool.c +++ b/app/tools/gimpeditselectiontool.c @@ -976,7 +976,8 @@ process_event_queue_keys (GdkEventKey *kevent, va_start (argp, kevent); - while (n_keys < FILTER_MAX_KEYS && (keys[n_keys] = va_arg (argp, guint)) != 0) + while (n_keys < FILTER_MAX_KEYS && + (keys[n_keys] = va_arg (argp, guint)) != 0) { modifiers[n_keys] = va_arg (argp, GdkModifierType); values[n_keys] = va_arg (argp, gint); @@ -1061,8 +1062,9 @@ gimp_edit_selection_tool_key_press (GimpTool *tool, EditType edit_type = EDIT_MASK_TRANSLATE; GimpUndoType undo_type = GIMP_UNDO_GROUP_MASK; const gchar *undo_desc = NULL; + gint velocity; - /* Bail out early if it is not an arrow key event */ + /* bail out early if it is not an arrow key event */ if (kevent->keyval != GDK_Left && kevent->keyval != GDK_Right && @@ -1070,19 +1072,23 @@ gimp_edit_selection_tool_key_press (GimpTool *tool, kevent->keyval != GDK_Down) return FALSE; + /* adapt arrow velocity to the zoom factor */ + velocity = ARROW_VELOCITY / GIMP_DISPLAY_SHELL (gdisp->shell)->scale; + velocity = MAX (1, velocity); + /* check for mask translation first because the translate_layer * modifiers match the translate_mask ones... */ inc_x = process_event_queue_keys (kevent, GDK_Left, (GDK_MOD1_MASK | GDK_SHIFT_MASK), - -1 * ARROW_VELOCITY, + -1 * velocity, GDK_Left, GDK_MOD1_MASK, -1, GDK_Right, (GDK_MOD1_MASK | GDK_SHIFT_MASK), - 1 * ARROW_VELOCITY, + 1 * velocity, GDK_Right, GDK_MOD1_MASK, 1, @@ -1092,13 +1098,13 @@ gimp_edit_selection_tool_key_press (GimpTool *tool, inc_y = process_event_queue_keys (kevent, GDK_Up, (GDK_MOD1_MASK | GDK_SHIFT_MASK), - -1 * ARROW_VELOCITY, + -1 * velocity, GDK_Up, GDK_MOD1_MASK, -1, GDK_Down, (GDK_MOD1_MASK | GDK_SHIFT_MASK), - 1 * ARROW_VELOCITY, + 1 * velocity, GDK_Down, GDK_MOD1_MASK, 1, @@ -1116,13 +1122,13 @@ gimp_edit_selection_tool_key_press (GimpTool *tool, { inc_x = process_event_queue_keys (kevent, GDK_Left, (GDK_CONTROL_MASK | GDK_SHIFT_MASK), - -1 * ARROW_VELOCITY, + -1 * velocity, GDK_Left, GDK_CONTROL_MASK, -1, GDK_Right, (GDK_CONTROL_MASK | GDK_SHIFT_MASK), - 1 * ARROW_VELOCITY, + 1 * velocity, GDK_Right, GDK_CONTROL_MASK, 1, @@ -1131,13 +1137,13 @@ gimp_edit_selection_tool_key_press (GimpTool *tool, inc_y = process_event_queue_keys (kevent, GDK_Up, (GDK_CONTROL_MASK | GDK_SHIFT_MASK), - -1 * ARROW_VELOCITY, + -1 * velocity, GDK_Up, GDK_CONTROL_MASK, -1, GDK_Down, (GDK_CONTROL_MASK | GDK_SHIFT_MASK), - 1 * ARROW_VELOCITY, + 1 * velocity, GDK_Down, GDK_CONTROL_MASK, 1, @@ -1155,13 +1161,13 @@ gimp_edit_selection_tool_key_press (GimpTool *tool, { inc_x = process_event_queue_keys (kevent, GDK_Left, GDK_SHIFT_MASK, - -1 * ARROW_VELOCITY, + -1 * velocity, GDK_Left, 0, -1, GDK_Right, GDK_SHIFT_MASK, - 1 * ARROW_VELOCITY, + 1 * velocity, GDK_Right, 0, 1, @@ -1170,13 +1176,13 @@ gimp_edit_selection_tool_key_press (GimpTool *tool, inc_y = process_event_queue_keys (kevent, GDK_Up, GDK_SHIFT_MASK, - -1 * ARROW_VELOCITY, + -1 * velocity, GDK_Up, 0, -1, GDK_Down, GDK_SHIFT_MASK, - 1 * ARROW_VELOCITY, + 1 * velocity, GDK_Down, 0, 1, diff --git a/devel-docs/ChangeLog b/devel-docs/ChangeLog index 0c1521410e..7de5dbcc5e 100644 --- a/devel-docs/ChangeLog +++ b/devel-docs/ChangeLog @@ -1,3 +1,8 @@ +2004-07-07 Sven Neumann + + * libgimpwidgets/libgimpwidgets-sections.txt + * libgimpwidgets/tmpl/gimpstock.sgml: added new icons. + 2004-07-05 Sven Neumann * libgimp/libgimp-docs.sgml: oops, gimpenums.xml used to be there diff --git a/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt b/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt index ff0ff9a544..aef6f48118 100644 --- a/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt +++ b/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt @@ -489,6 +489,7 @@ GIMP_STOCK_COLOR_PICKER_BLACK GIMP_STOCK_COLOR_PICKER_GRAY GIMP_STOCK_COLOR_PICKER_WHITE GIMP_STOCK_COLOR_TRIANGLE +GIMP_STOCK_COLOR_PICK_FROM_SCREEN GIMP_STOCK_CONVERT_GRAYSCALE GIMP_STOCK_CONVERT_INDEXED GIMP_STOCK_CONVERT_RGB @@ -550,6 +551,7 @@ GIMP_STOCK_FONT GIMP_STOCK_GRADIENT GIMP_STOCK_PALETTE GIMP_STOCK_PATTERN +GIMP_STOCK_ZOOM_FOLLOW_WINDOW
diff --git a/devel-docs/libgimpwidgets/tmpl/gimpstock.sgml b/devel-docs/libgimpwidgets/tmpl/gimpstock.sgml index 4181bbc4ba..dd20fd29a9 100644 --- a/devel-docs/libgimpwidgets/tmpl/gimpstock.sgml +++ b/devel-docs/libgimpwidgets/tmpl/gimpstock.sgml @@ -848,6 +848,13 @@ RTL variant + + + + + + + @@ -1317,3 +1324,10 @@ RTL variant + + + + + + + diff --git a/libgimpwidgets/gimppickbutton.c b/libgimpwidgets/gimppickbutton.c index 1eaa60bc35..6c26fe1c14 100644 --- a/libgimpwidgets/gimppickbutton.c +++ b/libgimpwidgets/gimppickbutton.c @@ -132,7 +132,7 @@ gimp_pick_button_init (GimpPickButton *button) { GtkWidget *image; - image = gtk_image_new_from_stock (GIMP_STOCK_TOOL_COLOR_PICKER, + image = gtk_image_new_from_stock (GIMP_STOCK_COLOR_PICK_FROM_SCREEN, GTK_ICON_SIZE_BUTTON); gtk_container_add (GTK_CONTAINER (button), image); gtk_widget_show (image); diff --git a/libgimpwidgets/gimpstock.c b/libgimpwidgets/gimpstock.c index d17d83d2e5..d98098e6ad 100644 --- a/libgimpwidgets/gimpstock.c +++ b/libgimpwidgets/gimpstock.c @@ -163,6 +163,7 @@ static GtkStockItem gimp_stock_items[] = { GIMP_STOCK_COLOR_PICKER_GRAY, NULL, 0, 0, LIBGIMP_DOMAIN }, { GIMP_STOCK_COLOR_PICKER_WHITE, NULL, 0, 0, LIBGIMP_DOMAIN }, { GIMP_STOCK_COLOR_TRIANGLE, NULL, 0, 0, LIBGIMP_DOMAIN }, + { GIMP_STOCK_COLOR_PICK_FROM_SCREEN, NULL, 0, 0, LIBGIMP_DOMAIN }, { GIMP_STOCK_CHAR_PICKER, NULL, 0, 0, LIBGIMP_DOMAIN }, { GIMP_STOCK_LETTER_SPACING, N_("L_etter Spacing"), 0, 0, LIBGIMP_DOMAIN }, @@ -335,6 +336,7 @@ gimp_stock_button_pixbufs[] = { GIMP_STOCK_COLOR_PICKER_GRAY, stock_color_picker_gray_18 }, { GIMP_STOCK_COLOR_PICKER_WHITE, stock_color_picker_white_18 }, { GIMP_STOCK_COLOR_TRIANGLE, stock_color_triangle_16 }, + { GIMP_STOCK_COLOR_PICK_FROM_SCREEN, stock_color_pick_from_screen_16 }, { GIMP_STOCK_CHAR_PICKER, stock_char_picker_22 }, { GIMP_STOCK_LETTER_SPACING, stock_letter_spacing_22 }, diff --git a/libgimpwidgets/gimpstock.h b/libgimpwidgets/gimpstock.h index 3c3a3af301..b89251efa2 100644 --- a/libgimpwidgets/gimpstock.h +++ b/libgimpwidgets/gimpstock.h @@ -84,6 +84,7 @@ G_BEGIN_DECLS #define GIMP_STOCK_COLOR_PICKER_GRAY "gimp-color-picker-gray" #define GIMP_STOCK_COLOR_PICKER_WHITE "gimp-color-picker-white" #define GIMP_STOCK_COLOR_TRIANGLE "gimp-color-triangle" +#define GIMP_STOCK_COLOR_PICK_FROM_SCREEN "gimp-color-pick-from-screen" #define GIMP_STOCK_CHAR_PICKER "gimp-char-picker" #define GIMP_STOCK_LETTER_SPACING "gimp-letter-spacing" diff --git a/themes/Default/images/Makefile.am b/themes/Default/images/Makefile.am index 87cb10d626..ebab1536a2 100644 --- a/themes/Default/images/Makefile.am +++ b/themes/Default/images/Makefile.am @@ -134,6 +134,7 @@ STOCK_BUTTON_IMAGES = \ stock-color-picker-black-18.png \ stock-color-picker-gray-18.png \ stock-color-picker-white-18.png \ + stock-color-pick-from-screen-16.png \ stock-color-triangle-16.png \ stock-curve-free-16.png \ stock-curve-smooth-16.png \ diff --git a/themes/Default/images/stock-color-pick-from-screen-16.png b/themes/Default/images/stock-color-pick-from-screen-16.png new file mode 100644 index 0000000000000000000000000000000000000000..12b65175aa2f950a4289306d7b5a82bca2c9d8d1 GIT binary patch literal 608 zcmV-m0-ybfP)WFU8GbZ8({Xk{QrNlj4iWF>9@00G2FL_t(|+Le+|NK{c2 z#((ef7)O}J6WpjNQwKZayYF5X&I~ioGxURRb2;a`zjM!p)9E~5t9) zh#kvbE{B|0ZGc^Pea~jnoz)aPI)WAJ$D;!_lkT*)uU)7)cL2MwzD_cg#C2T&wAN_R zXsyZR78tmCgN{~@?Oj2NA;tZuOw|Ek^Z6~Sl&Z7iI2N$K|85^8YA+`^fZf^2<9W?Y zKl@x6czNr;FJ)({;6O zT!2!F;p{EmEv|5>_Z$E%XIf}#@=!`)jG=}=MCw9by;!6_(@l2dArs@XG$tAeLrz9e z*7L~^HI*j%_y2$=PqU>%7tvB#X%Ga62%DQ5@d4kz<@h*1LsS~gM4GU;4?q}2NU?wk zBlaXbCg8_cR#$yoEtQ)^1g$k9hXg4v6+5N_3@N2v4h~)+oxVuYbr5ZlLIDvW2m&+_ u{@PF8&V9lda~-JL=MWJ48>?NatI+`{>E|2@@bU`)0000