callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

plug-ins: get rid of "Show this dialog" checkbox in file-dds.

Browse Source 
None of our load plug-ins have such a checkbox, so this is not
consistent. Moreover one you uncheck it, you just can't get back the
dialog until next GIMP restart. That's very bad usability.
This commit is contained in:
Jehan
2019-01-02 19:34:40 +01:00
parent 7e68aa37c1
commit 948608e658
3 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plug-ins/file-dds/dds.c
View File

@ -62,7 +62,7 @@ DDSWriteVals dds_write_vals =
DDSReadVals dds_read_vals = DDSReadVals dds_read_vals =
{ {
1, 1, 1 1, 1
}; };
static GimpParamDef load_args[] = static GimpParamDef load_args[] =
@ -218,7 +218,6 @@ static void run(const gchar *name, gint nparams, const GimpParam *param,
break; break;
case GIMP_RUN_NONINTERACTIVE: case GIMP_RUN_NONINTERACTIVE:
interactive_dds = 0; interactive_dds = 0;
dds_read_vals.show_dialog = 0;
dds_read_vals.mipmaps = param[3].data.d_int32; dds_read_vals.mipmaps = param[3].data.d_int32;
dds_read_vals.decode_images = param[4].data.d_int32; dds_read_vals.decode_images = param[4].data.d_int32;
if(nparams != G_N_ELEMENTS(load_args)) if(nparams != G_N_ELEMENTS(load_args))

1
plug-ins/file-dds/ddsplugin.h
View File

@ -52,7 +52,6 @@ typedef struct
typedef struct typedef struct
{ {
int show_dialog;
int mipmaps; int mipmaps;
int decode_images; int decode_images;
} DDSReadVals; } DDSReadVals;

9
plug-ins/file-dds/ddsread.c
View File

@ -93,7 +93,7 @@ GimpPDBStatusType read_dds(gchar *filename, gint32 *imageID)
GimpImageBaseType type; GimpImageBaseType type;
int i, j; int i, j;
if(interactive_dds && dds_read_vals.show_dialog) if (interactive_dds)
{ {
if(!load_dialog()) if(!load_dialog())
return(GIMP_PDB_CANCEL); return(GIMP_PDB_CANCEL);
@ -1241,13 +1241,6 @@ static int load_dialog(void)
gtk_box_pack_start(GTK_BOX(vbox), check, 1, 1, 0); gtk_box_pack_start(GTK_BOX(vbox), check, 1, 1, 0);
gtk_widget_show(check); gtk_widget_show(check);
check = gtk_check_button_new_with_label(_("Show this dialog"));
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(check), dds_read_vals.show_dialog);
g_signal_connect(check, "clicked",
G_CALLBACK (toggle_clicked), &dds_read_vals.show_dialog);
gtk_box_pack_start(GTK_BOX(vbox), check, 1, 1, 0);
gtk_widget_show(check);
gtk_widget_show(dlg); gtk_widget_show(dlg);
runme = 0; runme = 0;