callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ref/unref the view around the calls to gimp_container_view_item_selected()

Browse Source 
2004-08-03  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcontainergridview.c
	(gimp_container_grid_view_item_context): ref/unref the view around
	the calls to gimp_container_view_item_selected() and _item_context()
	because the former may destroy the view which leads to a crash
	when trying the latter. Fixes bug #148955.
This commit is contained in:
Michael Natterer
2004-08-03 14:55:31 +00:00
committed by Michael Natterer
parent b909c2b2ee
commit 8260cd69ce
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2004-08-03 Michael Natterer <mitch@gimp.org>
* app/widgets/gimpcontainergridview.c
(gimp_container_grid_view_item_context): ref/unref the view around
the calls to gimp_container_view_item_selected() and _item_context()
because the former may destroy the view which leads to a crash
when trying the latter. Fixes bug #148955.
2004-08-03 Michael Natterer <mitch@gimp.org> 2004-08-03 Michael Natterer <mitch@gimp.org>
* app/core/gimpimage-undo.[ch] (gimp_image_undo_can_compress): * app/core/gimpimage-undo.[ch] (gimp_image_undo_can_compress):

7
app/widgets/gimpcontainergridview.c
View File

@ -576,12 +576,19 @@ static void
gimp_container_grid_view_item_context (GtkWidget *widget, gimp_container_grid_view_item_context (GtkWidget *widget,
gpointer data) gpointer data)
{ {
/* ref the view because calling gimp_container_view_item_selected()
* may destroy the widget
*/
g_object_ref (data);
if (gimp_container_view_item_selected (GIMP_CONTAINER_VIEW (data), if (gimp_container_view_item_selected (GIMP_CONTAINER_VIEW (data),
GIMP_PREVIEW (widget)->viewable)) GIMP_PREVIEW (widget)->viewable))
{ {
gimp_container_view_item_context (GIMP_CONTAINER_VIEW (data), gimp_container_view_item_context (GIMP_CONTAINER_VIEW (data),
GIMP_PREVIEW (widget)->viewable); GIMP_PREVIEW (widget)->viewable);
} }
g_object_unref (data);
} }
static void static void