Default all strings to validate UTF-8, use no_validate to disable. Also

2003-08-18  Manish Singh  <yosh@gimp.org>

        * tools/pdbgen/app.pl: Default all strings to validate UTF-8, use
        no_validate to disable. Also added a null_ok parameter which does
        validate UTF-8, but allows NULL.

        * tools/pdbgen/pdb/brush_select.pdb
        * tools/pdbgen/pdb/brushes.pdb
        * tools/pdbgen/pdb/channel.pdb
        * tools/pdbgen/pdb/convert.pdb
        * tools/pdbgen/pdb/fileops.pdb
        * tools/pdbgen/pdb/font_select.pdb
        * tools/pdbgen/pdb/gimprc.pdb
        * tools/pdbgen/pdb/gradient_select.pdb
        * tools/pdbgen/pdb/gradients.pdb
        * tools/pdbgen/pdb/help.pdb
        * tools/pdbgen/pdb/image.pdb
        * tools/pdbgen/pdb/layer.pdb
        * tools/pdbgen/pdb/message.pdb
        * tools/pdbgen/pdb/palette_select.pdb
        * tools/pdbgen/pdb/palettes.pdb
        * tools/pdbgen/pdb/parasite.pdb
        * tools/pdbgen/pdb/paths.pdb
        * tools/pdbgen/pdb/pattern_select.pdb
        * tools/pdbgen/pdb/patterns.pdb
        * tools/pdbgen/pdb/plug_in.pdb
        * tools/pdbgen/pdb/procedural_db.pdb
        * tools/pdbgen/pdb/text_tool.pdb
        * tools/pdbgen/pdb/unit.pdb: removed utf8, added no_validate and
        null_ok where appropriate.

        * app/pdb/brush_select_cmds.c
        * app/pdb/font_select_cmds.c
        * app/pdb/gradient_select_cmds.c
        * app/pdb/layer_cmds.c
        * app/pdb/palette_select_cmds.c
        * app/pdb/pattern_select_cmds.c
        * app/pdb/plug_in_cmds.c: regenerated.

ChangeLog

@@ -1,3 +1,42 @@
+2003-08-18  Manish Singh  <yosh@gimp.org>
+
+	* tools/pdbgen/app.pl: Default all strings to validate UTF-8, use
+	no_validate to disable. Also added a null_ok parameter which does
+	validate UTF-8, but allows NULL.
+
+	* tools/pdbgen/pdb/brush_select.pdb
+	* tools/pdbgen/pdb/brushes.pdb
+	* tools/pdbgen/pdb/channel.pdb
+	* tools/pdbgen/pdb/convert.pdb
+	* tools/pdbgen/pdb/fileops.pdb
+	* tools/pdbgen/pdb/font_select.pdb
+	* tools/pdbgen/pdb/gimprc.pdb
+	* tools/pdbgen/pdb/gradient_select.pdb
+	* tools/pdbgen/pdb/gradients.pdb
+	* tools/pdbgen/pdb/help.pdb
+	* tools/pdbgen/pdb/image.pdb
+	* tools/pdbgen/pdb/layer.pdb
+	* tools/pdbgen/pdb/message.pdb
+	* tools/pdbgen/pdb/palette_select.pdb
+	* tools/pdbgen/pdb/palettes.pdb
+	* tools/pdbgen/pdb/parasite.pdb
+	* tools/pdbgen/pdb/paths.pdb
+	* tools/pdbgen/pdb/pattern_select.pdb
+	* tools/pdbgen/pdb/patterns.pdb
+	* tools/pdbgen/pdb/plug_in.pdb
+	* tools/pdbgen/pdb/procedural_db.pdb
+	* tools/pdbgen/pdb/text_tool.pdb
+	* tools/pdbgen/pdb/unit.pdb: removed utf8, added no_validate and
+	null_ok where appropriate.
+
+	* app/pdb/brush_select_cmds.c
+	* app/pdb/font_select_cmds.c
+	* app/pdb/gradient_select_cmds.c
+	* app/pdb/layer_cmds.c
+	* app/pdb/palette_select_cmds.c
+	* app/pdb/pattern_select_cmds.c
+	* app/pdb/plug_in_cmds.c: regenerated.
+
 2003-08-19  Sven Neumann  <sven@gimp.org>
 
 	* app/gui/toolbox-menu.c: use the new icons here as well.

app/pdb/brush_select_cmds.c

@@ -70,6 +70,8 @@ brushes_popup_invoker (Gimp     *gimp,
     success = FALSE;
 
   initial_brush = (gchar *) args[2].value.pdb_pointer;
+  if (initial_brush && !g_utf8_validate (initial_brush, -1, NULL))
+    success = FALSE;
 
   opacity = args[3].value.pdb_float;
   if (opacity < 0.0 || opacity > 100.0)

app/pdb/font_select_cmds.c

@@ -65,6 +65,8 @@ fonts_popup_invoker (Gimp     *gimp,
     success = FALSE;
 
   initial_font = (gchar *) args[2].value.pdb_pointer;
+  if (initial_font && !g_utf8_validate (initial_font, -1, NULL))
+    success = FALSE;
 
   if (success)
     {

app/pdb/gradient_select_cmds.c

@@ -68,6 +68,8 @@ gradients_popup_invoker (Gimp     *gimp,
     success = FALSE;
 
   initial_gradient = (gchar *) args[2].value.pdb_pointer;
+  if (initial_gradient && !g_utf8_validate (initial_gradient, -1, NULL))
+    success = FALSE;
 
   sample_size = args[3].value.pdb_int;
   if (sample_size <= 0 || sample_size > 10000)

app/pdb/layer_cmds.c

@@ -142,6 +142,8 @@ layer_new_invoker (Gimp     *gimp,
     success = FALSE;
 
   name = (gchar *) args[4].value.pdb_pointer;
+  if (name && !g_utf8_validate (name, -1, NULL))
+    success = FALSE;
 
   opacity = args[5].value.pdb_float;
   if (opacity < 0.0 || opacity > 100.0)

app/pdb/palette_select_cmds.c

@@ -66,6 +66,8 @@ palettes_popup_invoker (Gimp     *gimp,
     success = FALSE;
 
   initial_palette = (gchar *) args[2].value.pdb_pointer;
+  if (initial_palette && !g_utf8_validate (initial_palette, -1, NULL))
+    success = FALSE;
 
   if (success)
     {

app/pdb/pattern_select_cmds.c

@@ -66,6 +66,8 @@ patterns_popup_invoker (Gimp     *gimp,
     success = FALSE;
 
   initial_pattern = (gchar *) args[2].value.pdb_pointer;
+  if (initial_pattern && !g_utf8_validate (initial_pattern, -1, NULL))
+    success = FALSE;
 
   if (success)
     {

app/pdb/plug_in_cmds.c

@@ -73,21 +73,26 @@ static Argument *
 progress_init_invoker (Gimp     *gimp,
                        Argument *args)
 {
-  gboolean success = FALSE;
+  gboolean success = TRUE;
   gchar *message;
   gint32 gdisplay;
 
   message = (gchar *) args[0].value.pdb_pointer;
+  if (message && !g_utf8_validate (message, -1, NULL))
+    success = FALSE;
 
   gdisplay = args[1].value.pdb_int;
 
+  if (success)
+    {
       if (gimp->current_plug_in && gimp->current_plug_in->open)
 	{
-      success = TRUE;
-
 	  if (! gimp->no_interface)
 	    plug_in_progress_start (gimp->current_plug_in, message, gdisplay);
 	}
+      else
+	success = FALSE;
+    }
 
   return procedural_db_return_args (&progress_init_proc, success);
 }
@@ -440,12 +445,12 @@ static ProcArg plugin_domain_register_inargs[] =
   {
     GIMP_PDB_STRING,
     "domain_name",
-    "The name of the textdomain (must be unique)."
+    "The name of the textdomain (must be unique)"
   },
   {
     GIMP_PDB_STRING,
     "domain_path",
-    "The absolute path to the compiled message catalog (may be NULL)."
+    "The absolute path to the compiled message catalog (may be NULL)"
   }
 };
 

tools/pdbgen/app.pl

@@ -257,19 +257,22 @@ sub marshal_inargs {
 		my ($reverse, $test, $utf8, $utf8testvar);
 
 		$test = "$var == NULL";
+                $utf8 = 1;
 
 		if ($pdbtype eq 'parasite') {
 		    $test .= " || $var->name == NULL";
-
-                    $utf8 = 1;
 		    $utf8testvar = "$var->name";
 		}
 		else {
-                    $utf8 = exists $_->{utf8} && $_->{utf8};
+		    $utf8 = !exists $_->{no_validate};
 		    $utf8testvar = "$var";
 		}
 
-		if ($utf8) {
+		if (exists $_->{null_ok}) {
+		    $reverse = sub { ${$_[0]} =~ s/!//; };
+		    $test = "$var && !g_utf8_validate ($var, -1, NULL)";
+		}
+		elsif ($utf8) {
 		    $reverse = sub { ${$_[0]} =~ s/!//;
 				     ${$_[0]} =~ s/||/&&/g;
 				     ${$_[0]} =~ s/==/!=/g };

tools/pdbgen/pdb/brush_select.pdb

@@ -43,13 +43,13 @@ sub brushes_popup {
 
     @inargs = (
 	{ name => 'brush_callback', type => 'string',
-	  desc => 'The callback PDB proc to call when brush selection is made',
+	  desc => 'The callback PDB proc to call when brush selection is
-          utf8 => 1 },
+		   made' },
 	{ name => 'popup_title', type => 'string',
-	  desc => 'Title to give the brush popup window', utf8 => 1 },
+	  desc => 'Title to give the brush popup window' },
 	{ name => 'initial_brush', type => 'string',
 	  desc => 'The name of the brush to set as the first selected',
-	  no_success => 1, utf8 => 1 },
+	  null_ok => 1 },
 	&brush_args
     );
 
@@ -85,8 +85,7 @@ sub brushes_close_popup {
 
     @inargs = (
 	{ name => 'brush_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' }
-          utf8 => 1 }
     );
 
     %invoke = (
@@ -117,10 +116,9 @@ sub brushes_set_popup {
 
     @inargs = (
 	{ name => 'brush_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' },
-          utf8 => 1 },
 	{ name => 'brush_name', type => 'string',
-	  desc => 'The name of the brush to set as selected', utf8 => 1 },
+	  desc => 'The name of the brush to set as selected' },
 	&brush_args
     );
 

tools/pdbgen/pdb/brushes.pdb

@@ -20,8 +20,7 @@
 sub brush_arg () {{
     name => 'name',
     type => 'string',
-    desc => 'The brush name',
+    desc => 'The brush name'
-    utf8 => 1
 }}
 
 sub dim_args () {

tools/pdbgen/pdb/channel.pdb

@@ -88,10 +88,6 @@ sub channel_set_prop_proc {
 	$inargs[1]->{desc} .= ' (%%desc%%)';
     }
 
-    if ($type =~ /string/) {
-	$inargs[1]->{utf8} = 1;
-    }
-
     $invoke{code} = $undo ? "gimp_${core_type}_set_$prop ($core_var, $prop, TRUE);"
 			  : "gimp_${core_type}_set_$prop ($core_var, $prop);";
 
@@ -156,7 +152,7 @@ HELP
 	{ name => 'height', type => '0 < int32',
 	  desc => 'The channel height: (%%desc%%)' },
 	{ name => 'name', type => 'string',
-	  desc => 'The channel name', utf8 => 1 },
+	  desc => 'The channel name' },
 	{ name => 'opacity', type => '0 <= float <= 100',
 	  desc => 'The channel opacity: (%%desc%%)' },
 	{ name => 'color', type => 'color',

tools/pdbgen/pdb/convert.pdb

@@ -99,7 +99,7 @@ HELP
 	{ name => 'palette', type => 'string',
 	  desc => 'The name of the custom palette to use, ignored unless
 		   (palette_type == GIMP_CUSTOM_PALETTE)',
-	  alias => 'palette_name', utf8 => 1 }
+	  alias => 'palette_name' }
     );
 
     %invoke = (

tools/pdbgen/pdb/fileops.pdb

@@ -39,7 +39,7 @@ sub handler_args {
 
     push @inargs, { name => 'procedure_name', type => 'string',
 		    desc => "The name of the procedure to be used for $action",
-		    alias => 'name', utf8 => 1 };
+		    alias => 'name' };
 
     foreach ([ 'extensions', 'jpg,jpeg' ], [ 'prefixes', 'http:,ftp:' ]) {
 	&list_arg($type, $_->[0], @$_);
@@ -66,9 +66,9 @@ HELP
 	{ name => 'run_mode',
 	  type => 'enum GimpRunMode (no GIMP_RUN_WITH_LAST_VALS)',
 	  desc => 'The run mode: %%desc%%' },
-	{ name => 'filename', type => 'string',
+	{ name => 'filename', type => 'string', no_validate => 1,
 	  desc => 'The name of the file to load' },
-	{ name => 'raw_filename', type => 'string',
+	{ name => 'raw_filename', type => 'string', no_validate => 1,
 	  desc => 'The name as entered by the user' }
     );
 
@@ -123,9 +123,9 @@ HELP
 	  desc => 'Input image' },
 	{ name => 'drawable', type => 'drawable',
 	  desc => 'Drawable to save' },
-	{ name => 'filename', type => 'string',
+	{ name => 'filename', type => 'string', no_validate => 1,
 	  desc => 'The name of the file to save the image in' },
-	{ name => 'raw_filename', type => 'string',
+	{ name => 'raw_filename', type => 'string', no_validate => 1,
 	  desc => 'The name as entered by the user' }
     );
 
@@ -188,7 +188,7 @@ HELP
     $date = '1999-2003';
 
     @inargs = (
-	{ name => 'filename', type => 'string',
+	{ name => 'filename', type => 'string', no_validate => 1,
 	  desc => 'The name of the file that owns the thumbnail to load' },
     );
 
@@ -300,7 +300,7 @@ HELP
 
     @inargs = (
 	&std_image_arg,
-	{ name => 'filename', type => 'string',
+	{ name => 'filename', type => 'string', no_validate => 1,
 	  desc => 'The name of the file the thumbnail belongs to' },
     );
 
@@ -349,7 +349,7 @@ HELP
     &pdb_misc;
 
     @inargs = (
-	{ name => 'extension', type => 'string',
+	{ name => 'extension', type => 'string', no_validate => 1,
 	  desc => 'The extension the file will have' }
     );
 

tools/pdbgen/pdb/font_select.pdb

@@ -32,13 +32,13 @@ sub fonts_popup {
 
     @inargs = (
 	{ name => 'font_callback', type => 'string',
-	  desc => 'The callback PDB proc to call when font selection is made',
+	  desc => 'The callback PDB proc to call when font selection is
-          utf8 => 1 },
+		   made' },
 	{ name => 'popup_title', type => 'string',
-	  desc => 'Title to give the font popup window', utf8 => 1 },
+	  desc => 'Title to give the font popup window' },
 	{ name => 'initial_font', type => 'string',
 	  desc => 'The name of the font to set as the first selected',
-	  no_success => 1, utf8 => 1 }
+	  null_ok => 1 }
     );
 
     %invoke = (
@@ -68,8 +68,7 @@ sub fonts_close_popup {
 
     @inargs = (
 	{ name => 'font_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' }
-          utf8 => 1 }
     );
 
     %invoke = (
@@ -100,10 +99,9 @@ sub fonts_set_popup {
 
     @inargs = (
 	{ name => 'font_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' },
-          utf8 => 1 },
 	{ name => 'font_name', type => 'string',
-	  desc => 'The name of the font to set as selected', utf8 => 1 }
+	  desc => 'The name of the font to set as selected' }
     );
 
     %invoke = (

tools/pdbgen/pdb/gimprc.pdb

@@ -42,7 +42,7 @@ HELP
 
     @inargs = (
 	{ name => 'token', type => 'string',
-	  desc => 'The token to query for', utf8 => 1 }
+	  desc => 'The token to query for' }
     );
 
     @outargs = (
@@ -82,8 +82,8 @@ HELP
 	
     @inargs = (
 	{ name => 'token', type => 'string',
-	  desc => 'The token to modify', utf8 => 1 },
+	  desc => 'The token to modify' },
-	{ name => 'value', type => 'string',
+	{ name => 'value', type => 'string', no_validate => 1,
 	  desc => 'The value to set the token to' }
     );
 

tools/pdbgen/pdb/gradient_select.pdb

@@ -41,12 +41,12 @@ sub gradients_popup {
     @inargs = (
 	{ name => 'gradient_callback', type => 'string',
 	  desc => 'The callback PDB proc to call when gradient selection is
-		   made', utf8 => 1 },
+		   made' },
 	{ name => 'popup_title', type => 'string',
-	  desc => 'Title to give the gradient popup window', utf8 => 1 },
+	  desc => 'Title to give the gradient popup window' },
 	{ name => 'initial_gradient', type => 'string',
 	  desc => 'The name of the pattern to set as the first selected',
-	  no_success => 1, utf8 => 1 },
+	  null_ok => 1 },
 	&sample_size_arg
     );
 
@@ -80,8 +80,7 @@ sub gradients_close_popup {
 
     @inargs = (
 	{ name => 'gradient_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' }
-          utf8 => 1 }
     );
 
     %invoke = (
@@ -112,10 +111,9 @@ sub gradients_set_popup {
 
     @inargs = (
 	{ name => 'gradient_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' },
-          utf8 => 1 },
 	{ name => 'gradient_name', type => 'string',
-	  desc => 'The name of the gradient to set as selected', utf8 => 1 }
+	  desc => 'The name of the gradient to set as selected' }
     );
 
     %invoke = (

tools/pdbgen/pdb/gradients.pdb

@@ -118,7 +118,7 @@ HELP
 
     @inargs = (
 	{ name => 'name', type => 'string',
-	  desc => 'The name of the gradient to set', utf8 => 1 }
+	  desc => 'The name of the gradient to set' }
     );
 
     %invoke = (
@@ -284,8 +284,7 @@ HELP
 
     @inargs = (
 	{ name => 'name', type => 'string',
-	  desc => 'The gradient name ("" means current active gradient)',
+	  desc => 'The gradient name ("" means current active gradient)' },
-          utf8 => 1 },
 	&sample_size_arg,
 	&reverse_arg
     );

tools/pdbgen/pdb/help.pdb

@@ -38,9 +38,9 @@ HELP
     &pdb_misc;
 
     @inargs = (
-	{ name => 'prog_name', type => 'string',
+	{ name => 'prog_name', type => 'string', no_validate => 1,
-	  desc => 'The plug-in\'s executable name or an empty string' },
+	  desc => "The plug-in's executable name or an empty string" },
-	{ name => 'help_page', type => 'string',
+	{ name => 'help_page', type => 'string', no_validate => 1,
 	  desc => 'The location of the help page' }
     );
 

tools/pdbgen/pdb/image.pdb

@@ -1252,14 +1252,17 @@ CODE2
 }
 
 &image_accessors('filename', 'string', 'filename', 1,
-		 [ <<'CODE', undef ]);
+		 [ <<'CODE1', <<'CODE2' ]);
     $help =~ s/\. $//;
     $help .= <<'HELP';
  -- if it was loaded or has since been saved. Otherwise, returns NULL.
 HELP
 
     $outargs[0]->{alias} =~ s/g_strdup \((.*)\)/$1/;
-CODE
+CODE1
+
+    $inargs[1]->{no_validate} = 1;
+CODE2
 
 &image_accessors('name', 'string', 'name', 1,
 		 [ <<'CODE1', undef ]);

tools/pdbgen/pdb/layer.pdb

@@ -166,10 +166,6 @@ sub layer_set_prop_proc {
 	$inargs[1]->{desc} .= ' (%%desc%%)';
     }
 
-    if ($type =~ /string/) {
-	$inargs[1]->{utf8} = 1;
-    }
-
     $invoke{code} = $undo ? "gimp_${core_type}_set_$prop ($core_var, $prop, TRUE);"
                           : "gimp_${core_type}_set_$prop ($core_var, $prop);";
 
@@ -241,7 +237,7 @@ HELP
 	{ name => 'type', type => 'enum GimpImageType',
 	  desc => 'The layer type: { %%desc%% }' },
 	{ name => 'name', type => 'string',
-	  desc => 'The layer name', no_success => 1, utf8 => 1 },
+	  desc => 'The layer name', null_ok => 1 },
 	{ name => 'opacity', type => '0 <= float <= 100',
 	  desc => 'The layer opacity: (%%desc%%)' },
 	{ name => 'mode', type => 'enum GimpLayerModeEffects',

tools/pdbgen/pdb/message.pdb

@@ -34,7 +34,7 @@ HELP
 
     @inargs = (
 	{ name => 'message', type => 'string', const => 1,
-	  desc => 'Message to display in the dialog', utf8 => 1 }
+	  desc => 'Message to display in the dialog' }
     );
 
     %invoke = (

tools/pdbgen/pdb/palette_select.pdb

@@ -33,12 +33,12 @@ sub palettes_popup {
     @inargs = (
 	{ name => 'palette_callback', type => 'string',
 	  desc => 'The callback PDB proc to call when palette selection is
-		   made', utf8 => 1 },
+		   made' },
 	{ name => 'popup_title', type => 'string',
-	  desc => 'Title to give the palette popup window', utf8 => 1 },
+	  desc => 'Title to give the palette popup window' },
 	{ name => 'initial_palette', type => 'string',
 	  desc => 'The name of the palette to set as the first selected',
-	  no_success => 1, utf8 => 1 },
+	  null_ok => 1 },
     );
 
     %invoke = (
@@ -70,8 +70,7 @@ sub palettes_close_popup {
 
     @inargs = (
 	{ name => 'palette_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' }
-          utf8 => 1 }
     );
 
     %invoke = (
@@ -102,10 +101,9 @@ sub palettes_set_popup {
 
     @inargs = (
 	{ name => 'palette_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' },
-          utf8 => 1 },
 	{ name => 'palette_name', type => 'string',
-	  desc => 'The name of the palette to set as selected', utf8 => 1 },
+	  desc => 'The name of the palette to set as selected' },
     );
 
     %invoke = (

tools/pdbgen/pdb/palettes.pdb

@@ -32,8 +32,7 @@ sub adrian_pdb_misc {
 sub palette_arg () {{
     name => 'name',
     type => 'string',
-    desc => 'The palette name',
+    desc => 'The palette name'
-    utf8 => 1
 }}
 
 sub dim_args () {

tools/pdbgen/pdb/parasite.pdb

@@ -25,8 +25,7 @@ sub pdb_misc {
 sub name_arg {{
     name => 'name',
     type => 'string',
-    desc => "The name of the parasite to $_[0]",
+    desc => "The name of the parasite to $_[0]"
-    utf8 => 1
 }}
 
 sub parasite_outarg {{

tools/pdbgen/pdb/paths.pdb

@@ -80,8 +80,7 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'the name of the path whose points should be listed',
+	  desc => 'the name of the path whose points should be listed' }
-          utf8 => 1 }
     );
     $inargs[0]->{desc} = 'The ID of the image to list the paths from';
 
@@ -194,8 +193,7 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'The name of the path to set the current path to',
+	  desc => 'The name of the path to set the current path to' }
-          utf8 => 1 }
     );
     $inargs[0]->{desc} = 'The ID of the image to list set the paths in';
 
@@ -230,7 +228,7 @@ HELP
 		   name will be created - query the list of paths if you want
 		   to make sure that the name of the path you create is 
 		   unique. This will be set as the current path.',
-	  init => 1, utf8 => 1 },
+	  init => 1 },
 	{ name => 'ptype', type => 'int32',
 	  desc => 'The type of the path. Currently only one type (1 = Bezier)
 		   is supported' },
@@ -413,8 +411,7 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'the name of the path whose tattoo should be obtained',
+	  desc => 'the name of the path whose tattoo should be obtained' }
-          utf8 => 1 }
     );
 
     @outargs = (
@@ -450,7 +447,7 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'the name of the path whose tattoo should be set', utf8 => 1 },
+	  desc => 'the name of the path whose tattoo should be set' },
         { name => 'tattovalue', type => 'int32',
 	  desc => 'The tattoo associated with the name path. Only values returned from \'path_get_tattoo\' should be used here', init => 1  }
     );
@@ -519,7 +516,7 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'The name of the path to delete', utf8 => 1 }
+	  desc => 'The name of the path to delete' }
     );
     $inargs[0]->{desc} = 'The ID of the image to list delete the paths from';
 
@@ -551,8 +548,8 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'the name of the path whose locked status should be obtained',
+	  desc => 'the name of the path whose locked status should be
-          utf8 => 1 }
+		   obtained' }
     );
 
     @outargs = (
@@ -588,10 +585,11 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'the name of the path whose locked status should be set',
+	  desc => 'the name of the path whose locked status should be set' },
-          utf8 => 1 },
 	{ name => 'lockstatus', type => 'int32',
-	  desc => 'The lock status associated with the name path. 0 if the path is not locked. 1 if the path is to be locked', init => 1  }
+	  desc => 'The lock status associated with the name path. 0 if the
+		   path is not locked. 1 if the path is to be locked',
+	  init => 1 }
     );
 
     %invoke = (
@@ -624,8 +622,7 @@ HELP
     @inargs = (
 	&std_image_arg,
 	{ name => 'name', type => 'string',
-	  desc => 'The name of the path which should be made into selection',
+	  desc => 'The name of the path which should be made into selection' },
-          utf8 => 1 },
         { name => 'op', type => 'enum GimpChannelOps',
 	  desc => 'The desired operation with current selection' },
 	{ name => 'antialias', type => 'boolean',

tools/pdbgen/pdb/pattern_select.pdb

@@ -32,12 +32,12 @@ sub patterns_popup {
     @inargs = (
 	{ name => 'pattern_callback', type => 'string',
 	  desc => 'The callback PDB proc to call when pattern selection is
-		   made', utf8 => 1 },
+		   made' },
 	{ name => 'popup_title', type => 'string',
-	  desc => 'Title to give the pattern popup window', utf8 => 1 },
+	  desc => 'Title to give the pattern popup window' },
 	{ name => 'initial_pattern', type => 'string',
 	  desc => 'The name of the pattern to set as the first selected',
-	  no_success => 1, utf8 => 1 },
+	  null_ok => 1 }
     );
 
     %invoke = (
@@ -69,8 +69,7 @@ sub patterns_close_popup {
 
     @inargs = (
 	{ name => 'pattern_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' }
-          utf8 => 1 }
     );
 
     %invoke = (
@@ -101,10 +100,9 @@ sub patterns_set_popup {
 
     @inargs = (
 	{ name => 'pattern_callback', type => 'string',
-	  desc => 'The name of the callback registered for this popup',
+	  desc => 'The name of the callback registered for this popup' },
-          utf8 => 1 },
 	{ name => 'pattern_name', type => 'string',
-	  desc => 'The name of the pattern to set as selected', utf8 => 1 },
+	  desc => 'The name of the pattern to set as selected' }
     );
 
     %invoke = (

tools/pdbgen/pdb/patterns.pdb

@@ -20,8 +20,7 @@
 sub pattern_arg () {{
     name => 'name',
     type => 'string',
-    desc => 'The pattern name',
+    desc => 'The pattern name'
-    utf8 => 1
 }}
 
 sub dim_args () {

tools/pdbgen/pdb/plug_in.pdb

@@ -45,8 +45,8 @@ HELP
     &std_pdb_misc;
 
     @inargs = (
-	{ name => 'message', type => 'string', no_success => 1,
+	{ name => 'message', type => 'string', null_ok => 1,
-	  desc => 'Message to use in the progress dialog', utf8 => 1 },
+	  desc => 'Message to use in the progress dialog' },
 	{ name => 'gdisplay', type => 'int32',
 	  desc => 'GimpDisplay to update progressbar in, or -1 for a seperate
 		   window',
@@ -54,16 +54,15 @@ HELP
     );
 
     %invoke = (
-	success => 'FALSE',
 	code => <<'CODE'
 {
   if (gimp->current_plug_in && gimp->current_plug_in->open)
     {
-      success = TRUE;
-
       if (! gimp->no_interface)
 	plug_in_progress_start (gimp->current_plug_in, message, gdisplay);
     }
+  else
+    success = FALSE;
 }
 CODE
     );
@@ -134,7 +133,7 @@ sub plugins_query {
     @inargs = (
 	{ name  => 'search_string', type => 'string',
 	  desc  => 'If not an empty string then use this as a search pattern',
-	  alias => 'search_str', no_success => 1, utf8 => 1 }
+	  alias => 'search_str', no_success => 1 }
     );
 
     @outargs = (
@@ -266,9 +265,10 @@ HELP
 
     @inargs = (
 	{ name => 'domain_name', type => 'string',
-	  desc => 'The name of the textdomain (must be unique).', utf8 => 1 },
+	  desc => 'The name of the textdomain (must be unique)' },
 	{ name => 'domain_path', type => 'string',
-	  desc => 'The absolute path to the compiled message catalog (may be NULL).',
+	  desc => 'The absolute path to the compiled message catalog (may be
+		   NULL)',
 	  no_success => 1 },
     );
 
@@ -301,7 +301,7 @@ HELP
     &mitch_misc;
 
     @inargs = (
-	{ name => 'help_path', type => 'string',
+	{ name => 'help_path', type => 'string', no_validate => 1,
 	  desc => 'The rootdir of the plug-in\'s help pages' }
     );
 

tools/pdbgen/pdb/procedural_db.pdb

@@ -21,15 +21,13 @@ sub proc_name_arg () {{
     name  => 'procedure',
     type  => 'string',
     desc  => 'The procedure name',
-    alias => 'proc_name',
+    alias => 'proc_name'
-    utf8  => 1
 }}
 
 sub data_ident_arg () {{
     name => 'identifier',
     type => 'string',
-    desc => 'The identifier associated with data',
+    desc => 'The identifier associated with data'
-    utf8 => 1
 }}
 
 sub data_bytes_arg () {{
@@ -110,7 +108,7 @@ HELP
     $copyright = $author . ' & Peter Mattis';
 
     @inargs = (
-	{ name => 'filename', type => 'string',
+	{ name => 'filename', type => 'string', no_validate => 1,
 	  desc => 'The dump filename' }
     );
 
@@ -155,7 +153,7 @@ HELP
 
     my $regcomp = ""; my $free = ""; $once = 0;
     foreach (qw(name blurb help author copyright date proc_type)) {
-	push @inargs, { name => $_, type => 'string',
+	push @inargs, { name => $_, type => 'string', no_validate => 1,
 			desc => "The regex for procedure $_" };
 
 	$regcomp .= ' ' x 2 if $once;

tools/pdbgen/pdb/text_tool.pdb

@@ -28,15 +28,13 @@ sub pdb_misc {
 sub text_arg () {{
     name => 'text',
     type => 'string',
-    desc => 'The text to generate',
+    desc => 'The text to generate'
-    utf8 => 1
 }}
 
 sub fontname_arg () {{
     name => 'fontname',
     type => 'string',
-    desc => 'The name of the font',
+    desc => 'The name of the font'
-    utf8 => 1
 }}
 
 sub size_args () {(
@@ -68,7 +66,7 @@ sub font_prop_args {
    my @result;
    foreach (@props) {
 	(my $desc = $_) =~ s/_/-/g;
-	push @result, { name => $_, type => 'string',
+	push @result, { name => $_, type => 'string', no_validate => 1,
 			desc => qq/The font $desc/ }
    }
    @result;

tools/pdbgen/pdb/unit.pdb

@@ -96,19 +96,19 @@ HELP
 
     @inargs = (
 	{ name => 'identifier', type => 'string', wrap => 1,
-	  desc => "The new unit's identifier", utf8 => 1 },
+	  desc => "The new unit's identifier" },
 	{ name => 'factor', type => 'float',
 	  desc => "The new unit's factor" },
 	{ name => 'digits', type => 'int32',
 	  desc => "The new unit's digits" },
 	{ name => 'symbol', type => 'string',
-	  desc => "The new unit's symbol", utf8 => 1 },
+	  desc => "The new unit's symbol" },
 	{ name => 'abbreviation', type => 'string',
-	  desc => "The new unit's abbreviation", utf8 => 1 },
+	  desc => "The new unit's abbreviation" },
 	{ name => 'singular', type => 'string',
-	  desc => "The new unit's singular form", utf8 => 1 },
+	  desc => "The new unit's singular form" },
 	{ name => 'plural', type => 'string',
-	  desc => "The new unit's plural form", utf8 => 1 }
+	  desc => "The new unit's plural form" }
     );
 
     @outargs = ( &unit_arg );