callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app, devel-docs, libgimpbase: s/gimp_parasite_name/gimp_parasite_get_name/…

Browse Source 
… and s/gimp_parasite_flags/gimp_parasite_get_flags/

It is better to have a consistent API and the fact is that most
getter/setter functions use the _get|set_ naming, but these didn't.

I wondered if this was such a great idea to rename these anyway because
even though we are breaking API in GIMP 3, is it the best idea to rename
when no functional change happened? After discussing with Wormnest, we
still agreed it was still better to go for consistency rather than
regret later (and be stuck with these names for many more years).

Also this fixes these warnings:

> [649/1205] Generating gimp-3.0.vapi with a custom command
> Gimp-3.0.gir:24162.7-24162.56: warning: Field `Gimp.Parasite.flags' conflicts with method of the same name
> Gimp-3.0.gir:24318.7-24318.52: warning: Field `Gimp.Parasite.name' conflicts with method of the same name
This commit is contained in:
Jehan
2021-04-05 18:36:44 +02:00
parent b83988539b
commit 70a9576f27
14 changed files with 36 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
devel-docs/libgimpbase/libgimpbase3-sections.txt
View File

@ -411,8 +411,8 @@ gimp_parasite_is_type
gimp_parasite_is_persistent
gimp_parasite_is_undoable
gimp_parasite_has_flag
gimp_parasite_flags
gimp_parasite_name
gimp_parasite_get_flags
gimp_parasite_get_name
gimp_parasite_data
gimp_parasite_data_size
GIMP_PARASITE_PERSISTENT