callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: layers_text_tool_cmd_callback() is not supposed to be run on...

Browse Source 
... non-text layers.
Since commit 10099bd, the action will be non-sensitive with non-text
layers, so if it happens, there is a bug somewhere. Therefore
g_return_if_fail() on this condition.
Moreover opening the edit attributes dialog was absolutely confusing on
what this action is supposed to do. We should not have these kind of
random behaviors.
This commit is contained in:
Jehan
2017-05-13 00:01:56 +02:00
parent 10099bdaf7
commit 526918b26c
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/actions/layers-commands.c
View File

@ -186,11 +186,7 @@ layers_text_tool_cmd_callback (GtkAction *action,
return_if_no_layer (image, layer, data);
return_if_no_widget (widget, data);
if (! gimp_item_is_text_layer (GIMP_ITEM (layer)))
{
layers_edit_attributes_cmd_callback (action, data);
return;
}
g_return_if_fail (gimp_item_is_text_layer (GIMP_ITEM (layer)));
active_tool = tool_manager_get_active (image->gimp);