callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Issue #12712: non-configured filter throws CRITICAL when updating.

Browse Source
This commit is contained in:
Jehan
2025-01-13 20:05:07 +01:00
parent 40d38b0f9f
commit 51e719191d
1 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
libgimp/gimpdrawablefilter.c
View File

@ -385,38 +385,37 @@ gimp_drawable_filter_update (GimpDrawableFilter *filter)
GStrv auxnames; GStrv auxnames;
const GimpDrawable **auxinputs; const GimpDrawable **auxinputs;
guint n_aux; guint n_aux;
GObjectClass *klass;
GParamSpec **pspecs;
guint n_pspecs;
if (filter->config) if (! filter->config)
gimp_drawable_filter_get_config (filter);
g_return_if_fail (filter->config != NULL);
klass = G_OBJECT_GET_CLASS (filter->config);
pspecs = g_object_class_list_properties (klass, &n_pspecs);
values = gimp_value_array_new (n_pspecs);
for (guint i = 0; i < n_pspecs; i++)
{ {
GObjectClass *klass; GParamSpec *pspec = pspecs[i];
GParamSpec **pspecs; GValue value = G_VALUE_INIT;
guint n_pspecs;
klass = G_OBJECT_GET_CLASS (filter->config); g_value_init (&value, pspec->value_type);
pspecs = g_object_class_list_properties (klass, &n_pspecs); g_object_get_property (G_OBJECT (filter->config), pspec->name, &value);
values = gimp_value_array_new (n_pspecs);
for (guint i = 0; i < n_pspecs; i++) if (g_param_value_defaults (pspec, &value))
{ {
GParamSpec *pspec = pspecs[i];
GValue value = G_VALUE_INIT;
g_value_init (&value, pspec->value_type);
g_object_get_property (G_OBJECT (filter->config), pspec->name, &value);
if (g_param_value_defaults (pspec, &value))
{
g_value_unset (&value);
continue;
}
g_strv_builder_add (builder, pspec->name);
gimp_value_array_append (values, &value);
g_value_unset (&value); g_value_unset (&value);
continue;
} }
g_free (pspecs); g_strv_builder_add (builder, pspec->name);
gimp_value_array_append (values, &value);
g_value_unset (&value);
} }
propnames = g_strv_builder_end (builder); propnames = g_strv_builder_end (builder);
@ -431,6 +430,7 @@ gimp_drawable_filter_update (GimpDrawableFilter *filter)
filter->composite_mode, filter->composite_space, filter->composite_mode, filter->composite_space,
(const gchar **) auxnames, auxinputs); (const gchar **) auxnames, auxinputs);
g_free (pspecs);
g_strfreev (propnames); g_strfreev (propnames);
g_strv_builder_unref (builder); g_strv_builder_unref (builder);
gimp_value_array_unref (values); gimp_value_array_unref (values);