callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: serialize signals from gimpoperationtilesink

Browse Source 
These signals fire from threads while the mainloop is blocked by GEGL, since
the callbacks of the signals expect exclusive access a mutex works for
serializing.
This commit is contained in:
Øyvind Kolås
2010-12-17 03:20:01 +00:00
parent 4609bab1dd
commit 44ceeb246e
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/gegl/gimpoperationtilesink.c
View File

@ -187,12 +187,14 @@ gimp_operation_tile_sink_set_property (GObject *object,
} }
} }
static gboolean static gboolean
gimp_operation_tile_sink_process (GeglOperation *operation, gimp_operation_tile_sink_process (GeglOperation *operation,
GeglBuffer *input, GeglBuffer *input,
const GeglRectangle *result) const GeglRectangle *result)
{ {
GimpOperationTileSink *self = GIMP_OPERATION_TILE_SINK (operation); GimpOperationTileSink *self = GIMP_OPERATION_TILE_SINK (operation);
static GStaticMutex mutex = G_STATIC_MUTEX_INIT;
const Babl *format; const Babl *format;
PixelRegion destPR; PixelRegion destPR;
gpointer pr; gpointer pr;
@ -218,7 +220,13 @@ gimp_operation_tile_sink_process (GeglOperation *operation,
1.0, &rect, format, destPR.data, destPR.rowstride); 1.0, &rect, format, destPR.data, destPR.rowstride);
} }
g_static_mutex_lock (&mutex);
/* a lock here serializes all fired signals, this emit gets called from
* different worker threads, but the main loop will be blocked by GEGL
* when it happens
*/
g_signal_emit (operation, tile_sink_signals[DATA_WRITTEN], 0, result); g_signal_emit (operation, tile_sink_signals[DATA_WRITTEN], 0, result);
g_static_mutex_unlock (&mutex);
return TRUE; return TRUE;
} }