callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: fix cast bug.

Browse Source 
When building (at least on 32-bit), fixes this warning:
> app/widgets/gimpdashboard.c:3840:58: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Unsigned long long is specified in the C99 standard to be at least
64-bit. So it's normal that the compiler complains, as a cast from
unsigned long long to a pointer has chances to go very wrong.
Yet gimp_backtrace_get_frame_address() actually returns a guintptr which
is type-compatible with gpointer so let's not give the compiler false
information and just use this type. Then cast it to unsigned long long
just for printing to dashboard log.

(cherry picked from commit 8caef4ea0b)
This commit is contained in:
Jehan 2020-04-20 01:21:22 +02:00
parent a6c095b02d
commit 2335d5590d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/widgets/gimpdashboard.c
View File

@ -3858,14 +3858,14 @@ gimp_dashboard_log_sample (GimpDashboard *dashboard,
for (frame = n_head; frame < n_frames - n_tail; frame++)
{
unsigned long long address;
guintptr address;
address = gimp_backtrace_get_frame_address (backtrace,
thread, frame);
gimp_dashboard_log_printf (dashboard,
"<frame address=\"0x%llx\" />\n",
address);
(unsigned long long) address);
g_hash_table_add (priv->log_addresses, (gpointer) address);
}