callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Wee!!! No more curves crash! (Hopefully ;) Watch for this kind of stuff

Browse Source 
in other dialog code.  Widget event handlers get called before the data that
they reference gets initialized.  Move all that init code inside the dialog
creation.

-Matt
This commit is contained in:
Matt Wilson
1998-04-28 01:01:34 +00:00
parent 333356ec28
commit 010dc35e8a
5 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
Mon Apr 27 20:57:26 1998 EDT Matthew Wilson <msw@gimp.org>
* app/curves: Initialize data that is referenced in event handlers
in the curves_new_dialog function. Be on the look out for this
kind of stuff in other dialogs.
Tue Apr 28 00:16:31 1998 Tim Janik <timj@gtk.org>
* app/channels_dialog.c (channels_dialog_create): adjust the scrolled

6
app/base/curves.c
View File

@ -437,12 +437,16 @@ curves_new_dialog ()
GtkWidget *channel_hbox;
GtkWidget *menu;
GtkWidget *table;
int i;
int i, j;
cd = g_malloc (sizeof (CurvesDialog));
cd->preview = TRUE;
cd->curve_type = SMOOTH;
cd->pixmap = NULL;
cd->channel = HISTOGRAM_VALUE;
for (i = 0; i < 5; i++)
for (j = 0; j < 256; j++)
cd->curve[i][j] = j;
for (i = 0; i < 5; i++)
channel_items [i].user_data = (gpointer) cd;

6
app/curves.c
View File

@ -437,12 +437,16 @@ curves_new_dialog ()
GtkWidget *channel_hbox;
GtkWidget *menu;
GtkWidget *table;
int i;
int i, j;
cd = g_malloc (sizeof (CurvesDialog));
cd->preview = TRUE;
cd->curve_type = SMOOTH;
cd->pixmap = NULL;
cd->channel = HISTOGRAM_VALUE;
for (i = 0; i < 5; i++)
for (j = 0; j < 256; j++)
cd->curve[i][j] = j;
for (i = 0; i < 5; i++)
channel_items [i].user_data = (gpointer) cd;

6
app/tools/curves.c
View File

@ -437,12 +437,16 @@ curves_new_dialog ()
GtkWidget *channel_hbox;
GtkWidget *menu;
GtkWidget *table;
int i;
int i, j;
cd = g_malloc (sizeof (CurvesDialog));
cd->preview = TRUE;
cd->curve_type = SMOOTH;
cd->pixmap = NULL;
cd->channel = HISTOGRAM_VALUE;
for (i = 0; i < 5; i++)
for (j = 0; j < 256; j++)
cd->curve[i][j] = j;
for (i = 0; i < 5; i++)
channel_items [i].user_data = (gpointer) cd;

6
app/tools/gimpcurvestool.c
View File

@ -437,12 +437,16 @@ curves_new_dialog ()
GtkWidget *channel_hbox;
GtkWidget *menu;
GtkWidget *table;
int i;
int i, j;
cd = g_malloc (sizeof (CurvesDialog));
cd->preview = TRUE;
cd->curve_type = SMOOTH;
cd->pixmap = NULL;
cd->channel = HISTOGRAM_VALUE;
for (i = 0; i < 5; i++)
for (j = 0; j < 256; j++)
cd->curve[i][j] = j;
for (i = 0; i < 5; i++)
channel_items [i].user_data = (gpointer) cd;