Commit Graph

1857 Commits

Author SHA1 Message Date
7 7796aa195e Setup global corba_storage variable. (mls_get_folder): Set 'update
2001-09-17    <NotZed@Ximian.com>

        * mail-local.c (storage_listener_startup): Setup global
        corba_storage variable.
        (mls_get_folder): Set 'update lstorage' on the newly opened
        folder.

svn path=/trunk/; revision=12915
2001-09-17 22:21:16 +00:00
Jeffrey Stedfast 23583a50aa Do nothing if the selection is NULL? Maybe this is the cause of bug #6817.
2001-09-17  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-display.c (invisible_selection_get_callback): Do nothing if
	the selection is NULL? Maybe this is the cause of bug #6817.

svn path=/trunk/; revision=12910
2001-09-17 21:02:30 +00:00
Jeffrey Stedfast 45edb0148a Go back to generating the cachename ourselves, but continue doing it the
2001-09-17  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (mail_config_folder_to_cachename): Go back to
	generating the cachename ourselves, but continue doing it the way
	the dfault implementation of camel_folder_get_uri worked.

svn path=/trunk/; revision=12908
2001-09-17 20:38:38 +00:00
Christopher James Lahey 67b6c40da6 Updated required version of gal to 0.11.99.4.
2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* configure.in: Updated required version of gal to 0.11.99.4.

From calendar/ChangeLog:

2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* gui/dialogs/meeting-page.c (build_etable): Updated this to match
	the new ETableSimple interface.

From mail/ChangeLog:

2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* message-list.c (ml_get_node_by_id): Made save_id const here.

From shell/ChangeLog:

2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* e-storage-set-view.c (etree_get_node_by_id): Made save_id const
	here.

svn path=/trunk/; revision=12870
2001-09-17 04:00:31 +00:00
Jeffrey Stedfast a913c0c896 Don;t destroy the pixbuf loader, unref it instead.
2001-09-16  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-display.c (pixbuf_gen_idle): Don;t destroy the pixbuf
	loader, unref it instead.

	* mail-config.c (mail_config_folder_to_cachename): Use
	camel_folder_get_uri().

svn path=/trunk/; revision=12863
2001-09-16 20:55:38 +00:00
Jeffrey Stedfast 0143519961 Use camel_folder_get_uri().
2001-09-16  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (mail_config_folder_to_cachename): Use
	camel_folder_get_uri().

svn path=/trunk/; revision=12861
2001-09-16 20:32:06 +00:00
5 c2a0bf66ba Major rewrite of most of the guts, handle changes based on signals and
2001-09-15    <NotZed@Ximian.com>

        * mail-vfolder.c: Major rewrite of most of the guts, handle
        changes based on signals and events, etc.  Use the main storage
        handling code that imap uses, etc.

        * mail-tools.c (mail_tool_uri_to_folder): Dont special case
        vfolder: anymore.

        * component-factory.c (owner_set_cb): use vfolder_load_storage(),
        new function to setup vfolder storage, after interaction has been
        enabled only.  This might need some tweaking ...
        (storage_remove_folder): Removed all the folder lookup stuff.
        Just delete the folder based on the path passed in.  There should
        be no reason this wouldn't work, right?

2001-09-14    <NotZed@Ximian.com>

        * mail-ops.c (get_folderinfo_get): Only add vtrash folder info, if
        store supports vtrash.

        * component-factory.c (mail_load_storage_by_uri): Let 'vfolder'
        stores show up too.

2001-09-13    <NotZed@Ximian.com>

        * mail-vfolder.c (vfolder_uri_to_folder): Open a vfolder then set
        its expression, since name?query open method is removed.

svn path=/trunk/; revision=12856
2001-09-15 08:13:41 +00:00
Jeffrey Stedfast f463844fdb Return the cached value of camel_service_get_name so that we don't leak
2001-09-14  Jeffrey Stedfast  <fejj@ximian.com>

	* subscribe-dialog.c (fe_root_value_at): Return the cached value
	of camel_service_get_name so that we don't leak memory.
	(fe_real_value_at): Don't strdup the node's name.
	(folder_etree_construct): Set the service_name.
	(fe_destroy): Free the service_name.

svn path=/trunk/; revision=12849
2001-09-15 00:55:22 +00:00
Jeffrey Stedfast 346bdd86b9 fixed a small memory leak
svn path=/trunk/; revision=12848
2001-09-15 00:11:40 +00:00
Jeffrey Stedfast 02add12fb6 Added a refcount variable so set the refcount to 1. (sd_got_store): Unref
2001-09-14  Jeffrey Stedfast  <fejj@ximian.com>

	* subscribe-dialog.c (store_data_new): Added a refcount variable
	so set the refcount to 1.
	(sd_got_store): Unref the store-data.
	(store_data_async_get_store): Ref the store-data.
	(store_data_ref): New function.
	(store_data_unref): New function.
	(subscribe_dialog_destroy): Instead of freeing the store-data
	here, unref it instead. We may just have an async function
	running. Set the callback function to NULL so that when the
	(remaining) async functions finish, they become no-ops.

svn path=/trunk/; revision=12847
2001-09-15 00:00:32 +00:00
Jeffrey Stedfast f711960d88 Revert my bar_destroy code and replace it with dialog_destroy instead.
2001-09-14  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-send-recv.c (build_dialogue): Revert my bar_destroy code
	and replace it with dialog_destroy instead.

svn path=/trunk/; revision=12832
2001-09-14 22:19:57 +00:00
Jeffrey Stedfast bc38f72b7c Append a message to any exception we get appending to any folders after
2001-09-14  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-ops.c (mail_send_message): Append a message to any
	exception we get appending to any folders after having sent the
	message successfully saying that the message was sent successfully
	so the user doesn't misinterpret the error.

svn path=/trunk/; revision=12830
2001-09-14 19:53:12 +00:00
Jon Trowbridge b68e1162c4 Fixed double-freeing of EDestination vector when sending html mail to
2001-09-13  Jon Trowbridge  <trow@ximian.com>

	* mail-callbacks.c (composer_get_message): Fixed double-freeing of
	EDestination vector when sending html mail to people who don't
	necessarily want it.  Fixes bug #9848.

svn path=/trunk/; revision=12821
2001-09-14 02:22:37 +00:00
Jeffrey Stedfast 492b362c56 Modified to take a FolderETree instead of a CamelStore (since the
2001-09-13  Jeffrey Stedfast  <fejj@ximian.com>

	* subscribe-dialog.c (get_short_folderinfo_desc):
	(get_short_folderinfo_get):
	(get_short_folderinfo_got):
	(get_short_folderinfo_free):
	(subscribe_get_short_folderinfo): Modified to take a FolderETree
	instead of a CamelStore (since the CamelStore is inside the
	FolderETree anyway) so that we could ref the ETree to prevent a
	race condition. Should fix bug #9827.

svn path=/trunk/; revision=12808
2001-09-13 20:33:47 +00:00
Jeffrey Stedfast 04bb635647 Make sure that the charset_filter is non-NULL before using it since iconv
2001-09-13  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-format.c (try_inline_pgp_sig): Make sure that the
	charset_filter is non-NULL before using it since iconv may fail.

svn path=/trunk/; revision=12801
2001-09-13 17:42:25 +00:00
Larry Ewing a44e494e2d free the credits string.
2001-09-13  Larry Ewing  <lewing@ximian.com>

	* mail-tools.c (mail_tool_quote_message): free the credits string.

svn path=/trunk/; revision=12795
2001-09-13 08:28:21 +00:00
2 8be7f276a2 Fixed the remove callback prototype, and return the result properly using
2001-09-12    <NotZed@Ximian.com>

        * mail-vfolder.c (vfolder_remove_cb): Fixed the remove callback
        prototype, and return the result properly using the listener.

svn path=/trunk/; revision=12786
2001-09-12 21:50:00 +00:00
Jeffrey Stedfast 76538defb6 Save transport passwords too. This fixes bug #3020.
2001-09-12  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (mail_config_write_on_exit): Save transport
	passwords too. This fixes bug #3020.

svn path=/trunk/; revision=12777
2001-09-12 19:37:20 +00:00
Dan Winship d0196161ec Don't set the folderinfo's unread count to 0 when camel reports -1, since
* mail-folder-cache.c (mail_folder_cache_note_folderinfo): Don't
	set the folderinfo's unread count to 0 when camel reports -1,
	since that may overwrite a valid unread count from before.
	(get_folder_info): Do it here instead when first creating a new
	folderinfo structure.
	Should fix bug #1756.

svn path=/trunk/; revision=12768
2001-09-11 19:29:13 +00:00
Larry Ewing 44968e072f call menu_file_save_error when there is an exception while saving.
2001-09-11  Larry Ewing  <lewing@ximian.com>

	* mail-account-gui.c (menu_file_save_cb): call menu_file_save_error
	when there is an exception while saving.
	(menu_file_save_error): pop up a dialog telling the user the file
	has not been saved.

svn path=/trunk/; revision=12765
2001-09-11 06:02:43 +00:00
0 c7e1b2cbb0 Dynamically create the folder type list from camel. (reconfigure_clicked):
2001-09-10    <NotZed@Ximian.com>

        * mail-local.c (mail_local_reconfigure_folder): Dynamically create
        the folder type list from camel.
        (reconfigure_clicked): And change code to handle changes.

2001-09-10    <NotZed@Ximian.com>

        * merged mail_local patch from peterw.  Many changes.

svn path=/trunk/; revision=12759
2001-09-11 00:32:20 +00:00
Iain Holmes a580c92e17 Handle empty accounts
svn path=/trunk/; revision=12756
2001-09-11 00:05:52 +00:00
Jeffrey Stedfast f431da35f7 Don't use new_with_sig_file, that function no longer exists.
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Don't use
	new_with_sig_file, that function no longer exists.
	(forward_get_composer): Same here.

svn path=/trunk/; revision=12754
2001-09-10 23:52:14 +00:00
Chyla Zbigniew 9e1498b952 Marked string for translation. (new_source_created): Ditto.
* mail-config.c
(add_shortcut_entry): Marked string for translation.
(new_source_created): Ditto.

* mail-send-recv.c
(format_url): Marked strings for translation.
(build_dialogue): Ditto.

svn path=/trunk/; revision=12752
2001-09-10 23:17:25 +00:00
Jeffrey Stedfast 1bb96b143e Hide the S/MIME frame if we don't support S/MIME.
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-account-gui.c (mail_account_gui_new): Hide the S/MIME frame
	if we don't support S/MIME.

svn path=/trunk/; revision=12743
2001-09-10 20:08:15 +00:00
Jeffrey Stedfast c738d45344 Attach to the destroy event for each progressbar using bar_destroyed as
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-send-recv.c (build_dialogue): Attach to the destroy event
	for each progressbar using bar_destroyed as the callback.
	(bar_destroyed): New callback to unregister the timeout and set
	the send-info's bar member to NULL so we don't try to update a
	destroyed progressbar.

	* mail-callbacks.c (mail_generate_reply): Pass along the right
	string, this fixes bug #9518.

svn path=/trunk/; revision=12738
2001-09-10 19:44:43 +00:00
Jeffrey Stedfast 6ec30840a8 Pass along the right string, this fixes bug #9518.
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Pass along the right
	string, this fixes bug #9518.

svn path=/trunk/; revision=12736
2001-09-10 18:50:32 +00:00
Jeffrey Stedfast 3aeaca9fa9 Don't save the authmech if the username doesn't exist. Fixes bug #9474.
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-account-gui.c (save_service): Don't save the authmech if
	the username doesn't exist. Fixes bug #9474.

svn path=/trunk/; revision=12735
2001-09-10 17:17:43 +00:00
Jeffrey Stedfast 731a90ea4a Remove some mailer-set headers. Fixes bug #9462.
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (do_edit_messages): Remove some mailer-set
	headers. Fixes bug #9462.

svn path=/trunk/; revision=12734
2001-09-10 17:11:59 +00:00
Dan Winship 0ef4bba698 Fix obvious dumb mistake in previous commit that made it *always* complain
* mail-callbacks.c (composer_get_message): Fix obvious dumb
	mistake in previous commit that made it *always* complain you had
	invalid recipients.

svn path=/trunk/; revision=12733
2001-09-10 17:03:42 +00:00
Jon Trowbridge e9b0430629 Complain if we are trying to send to invalid recipients. (Bug #8875)
2001-09-09  Jon Trowbridge  <trow@ximian.com>

	* mail-callbacks.c (composer_get_message): Complain if we are
	trying to send to invalid recipients. (Bug #8875)

svn path=/trunk/; revision=12721
2001-09-10 00:01:37 +00:00
Jeffrey Stedfast f5fec6d071 We need to initialize all of the struct fields or else god knows what will
2001-09-09  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config-druid.c (evolution_mail_config_wizard_factory_fn):
	We need to initialize all of the struct fields or else god knows
	what will happen later when we try to use 'em. Also set a destroy
	function for the MailConfigWizard so we don't leak it.

svn path=/trunk/; revision=12719
2001-09-09 23:32:31 +00:00
Jon Trowbridge 04a9f382c3 s/gnu.org/ximian.com/. I should change that default at some point...
svn path=/trunk/; revision=12713
2001-09-09 04:11:42 +00:00
Jon Trowbridge 56b6ad0e51 Added. Shows a (hopefully) informative dialog warning you that some
2001-09-08  Jon Trowbridge  <trow@gnu.org>

	* mail-callbacks.c (ask_confirm_for_unwanted_html_mail): Added.
	Shows a (hopefully) informative dialog warning you that some
	recipients might not want HTML mail (who are listed), and gives
	the option to cancel sending.  (FIXME: The wording of this dialog
	could use some work.)
	(composer_get_message): Check if we are sending HTML to someone
	who might not want it, and raise the dialog if we are.  Use our
	new destination-vector based api when talking to the composer.
	Touch our destinations here, boosting their use scores.  This is
	the right place for this to happen --- closer to the end of the
	sending process, where incorrect/artificial use score inflation is
	less likely to occur.

	* mail-config.c (config_read): Added
	/Mail/Format/confirm_unwanted_html key.  This flag determines
	whether or not we want to see the warning dialog when we send HTML
	mail to contacts who don't want it.  Default is TRUE.
	(mail_config_write_on_exit): Write out the confirm_unwanted_html
	key.
	(mail_config_get_confirm_unwanted_html): Added.
	(mail_config_set_confirm_unwanted_html): Added.

svn path=/trunk/; revision=12712
2001-09-09 04:11:15 +00:00
Dan Winship 1cf0994cec Unref the invisible, don't just destroy it.
* mail-display.c (mail_display_destroy): Unref the invisible,
        don't just destroy it.

svn path=/trunk/; revision=12704
2001-09-08 16:32:24 +00:00
Michael Zucci c010132a3b Change some words.
svn path=/trunk/; revision=12698
2001-09-08 00:39:40 +00:00
Jeffrey Stedfast 8e92271ad5 kill off some warnings
svn path=/trunk/; revision=12697
2001-09-08 00:14:17 +00:00
Jeffrey Stedfast aecfa56f02 Give the full path of the wax-seal icons. (try_inline_pgp_sig): Convert
2001-09-07  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-format.c (mail_write_authenticity): Give the full path of
	the wax-seal icons.
	(try_inline_pgp_sig): Convert the charset from UTF-8 to whatever
	charset it should be. Now takes a CamelMimePart argument as well.
	(try_uudecoding): Now takes a part argument as well.
	(try_inline_pgp): Here too.
	(try_binhex): And finally here.
	(handle_text_plain): Pass along the mime part to the try_*
	functions.

svn path=/trunk/; revision=12688
2001-09-07 21:30:58 +00:00
Jeffrey Stedfast c0ea8aa685 Give the full path of the wax-seal icons.
2001-09-07  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-format.c (mail_write_authenticity): Give the full path of
	the wax-seal icons.

svn path=/trunk/; revision=12684
2001-09-07 20:46:08 +00:00
Chris Toshok 5bfc457407 new function, to notify the bonobo listener in
2001-09-06  Chris Toshok  <toshok@ximian.com>

	* component-factory.c (notify_listener): new function, to notify
	the bonobo listener in remove_folder/create_folder.
	(storage_create_folder): match EvolutionStorage create_folder
	signal's signature.
	(storage_remove_folder): match EvolutionStorage remove_folder
	signal's signature.

svn path=/trunk/; revision=12671
2001-09-07 06:47:18 +00:00
Dan Winship e243f47a72 Fix a bunch of replying/forwarding-related formatting bugs.
2749 - Message text not included in reply, but html attachment is
	4294 - "forward inline" should quote the same headers as the
	       normal mail display
	6100 - Reply to a forwarded email displays email headers
	7255 - Replying to HTML message
	7527 - replying to forwarded message w/ attachments does the wrong
	       thing

	* mail-format.c (mail_get_message_rfc822): New function to get
	message headers and body together, for inline forwards, or replies
	containing attached messages.
	(mail_get_message_body): Redo this to always return HTML, but keep
	the "want_plain" flag, to decide whether to return HTML that looks
	like HTML or HTML that looks like plain text. Use
	mail_get_message_rfc822 to handle attached message/rfc822 parts.
	Don't include the text of vcard or icalendar attachments. Don't
	fail to include text parts just because we found an HTML part.
	(Since we're always returning HTML now, this doesn't cause
	problems any more.)

	* mail-tools.c (mail_tool_quote_message): Simplify greatly.
	mail_get_message_body always returns HTML now, and we let it take
	care of prepending "> "s too. We then let GtkHTML deal with
	converting the HTML to plain text if the user wants to reply in
	plain text.
	(mail_tool_forward_message): Simplify this a ton too: parts of it
	are moved into mail_get_message_rfc822 and parts are now
	unnecessary.

	* mail-callbacks.c (do_forward_non_attached): Call
	mail_tool_forward_message here always, and let it do the "> "
	quoting in the "quoted" case, so that we get the headers too when
	forwarding quoted. Related to bug #4294.

svn path=/trunk/; revision=12657
2001-09-06 20:10:02 +00:00
Dan Winship 35f6d96029 the "command" of a GnomeVFSMimeApplication can include arguments as well.
* mail-display.c (launch_cb): the "command" of a
	GnomeVFSMimeApplication can include arguments as well. Deal with
	that. Fixes support for CodeWeavers' CrossOver Plugin.

svn path=/trunk/; revision=12643
2001-09-05 23:34:03 +00:00
Jeffrey Stedfast 56e5135e5a removed conflict stuff
svn path=/trunk/; revision=12641
2001-09-05 23:04:56 +00:00
Jeffrey Stedfast de4c391ec2 Adjust the default_account index correctly.
2001-09-05  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (mail_config_remove_account): Adjust the
	default_account index correctly.

2001-09-05  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (mail_config_get_accounts): Added a g_assert to
	make sure that config wasn't NULL. This is meant to help debug bug
	#4911 and friends.

	* component-factory.c (owner_set_cb): Do not mail_config_init()
	here as we've already called this in main() in main.c.

svn path=/trunk/; revision=12640
2001-09-05 23:04:33 +00:00
Ettore Perazzoli 86de708aac [Fix #958, ShellComponents should not be created by factories, for
the mailer case.]

* GNOME_Evolution_Mail.oaf.in: Remove the
GNOME_Evolution_Mail_ShellComponentFactory.

* component-factory.c: Changed to not use a factory.
(COMPONENT_FACTORY_ID): Removed.
(COMPONENT_ID): New.
(idle_quit): Don't unref the component_factory.
(create_component): Renamed from `component_fn'.  Take no args.
(component_factory_init): Create the component with
`create_component' and register it on OAF.

svn path=/trunk/; revision=12637
2001-09-05 22:46:53 +00:00
Radek Doulik 0320961855 This patch should avoid flashing when loading images into mail view, credits
go to Dan, Larry and me ;)
(fixes ximian #6680)

2001-09-06  Radek Doulik  <rodo@ximian.com>

	* everywhere updated for new mail_content_loaded definition
	(prototype)

2001-09-05  Radek Doulik  <rodo@ximian.com>

	* mail-display.c (mail_display_redisplay): increase
	redisplay_counter
	(try_part_urls): new helper function
	(try_data_urls): ditto
	(load_content_loaded): if it has stream handle available and if
	it's still valid, it writes to this stream instead of
	redisplaying, uses try_part_urls and try_data_urls

	* mail-display.h: added redisplay_counter to MailDisplay, I use
	it in load_content_loaded to be sure that there wasn't any
	redisplay and that remembered handle is still valid

	* mail-display.c (on_url_requested): don't end stream with error
	if part is not loaded yet
	(on_url_requested): don't end stream in cases when we are going to
	load image using http
	(stream_write_or_redisplay_when_loaded): new helper function,
	which is extracted from mail_display_redisplay_when_loaded. it's
	extended to handle gtkhtml stream writting
	(mail_display_redisplay_when_loaded): use
	stream_write_or_redisplay_when_loaded
	(mail_display_stream_write_when_loaded): new function, uses
	stream_write_or_redisplay_when_loaded
	struct _load_content_msg: added handle, url and redisplay_counter
	fields

	* mail-format.c (mail_content_loaded): added redisplay, url and
	handle parameter for case when we are loading image content and
	want it write to stream instead of redisplaying

svn path=/trunk/; revision=12633
2001-09-05 22:13:05 +00:00
Ettore Perazzoli 000b01e9a1 Replace "Evolution" with "Ximian Evolution" in a bunch of user-visible
places.

svn path=/trunk/; revision=12625
2001-09-05 19:27:03 +00:00
Ettore Perazzoli 1e251f23e6 [Fix #7542, "Crash Afer Closing".]
* component-factory.c (owner_unset_cb): NULL the
global_shell_client as the first thing here.  Otherwise we might
get into a slight race that causes the shell to crash.  [Still, of
course the shell shouldn't crash, but I haven't been able to track
that down yet.]

svn path=/trunk/; revision=12605
2001-09-04 21:52:00 +00:00
Chyla Zbigniew 159c872ddf Fixes #7251
* mail-ops.c (add_vtrash_info): Mark "Trash" with U_(), not _().

svn path=/trunk/; revision=12604
2001-09-04 21:49:43 +00:00
Jeffrey Stedfast ca52e80ea8 Unref the source folder here because it might be a POP folder. We do this
2001-09-04  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-ops.c (fetch_mail_fetch): Unref the source folder here
	because it might be a POP folder. We do this because on store
	finalize, we now try to disconnect cleanly which means that we may
	block.

svn path=/trunk/; revision=12602
2001-09-04 21:32:57 +00:00