Commit Graph

121 Commits

Author SHA1 Message Date
0b342f2c84 do not set position, it's already done in .glade, call set_transient_for
2004-08-02  Radek Doulik  <rodo@ximian.com>

	* e-table-config.c (e_table_config_construct): do not set
	position, it's already done in .glade, call set_transient_for
	always (passing NULL is valid as well)

	* e-table-config.glade: * e-table-config-no-group.glade: center
	window on parent, don't let it resize and most importan make it
	dialog window so that set_transient_for works against define views
	dialog

	Fixes #61936

2004-08-02  Radek Doulik  <rodo@ximian.com>

	* gal-define-views-dialog.c: save collection on exit

	Fixes #61936

svn path=/trunk/; revision=26819
2004-08-04 09:16:19 +00:00
1b01e8ccc0 watch for selection changes and set Delete button sensitivity according to
2004-07-23  Radek Doulik  <rodo@ximian.com>

	* gal-define-views-dialog.c: watch for selection changes and set
	Delete button sensitivity according to view collection item
	built-in flag

	Fixes #57914

svn path=/trunk/; revision=26717
2004-07-23 16:58:02 +00:00
cf6965aac2 clone view before saving it to avoid problems with setting current_view_id
2004-06-21  Radek Doulik  <rodo@ximian.com>

	* gal-view-instance-save-as-dialog.c
	(gal_view_instance_save_as_dialog_save): clone view before saving
	it to avoid problems with setting current_view_id

	Fixes #57354

svn path=/trunk/; revision=26437
2004-06-21 13:55:38 +00:00
617cf62b8b prepend label " " before the ETable
2004-06-14  Radek Doulik  <rodo@ximian.com>

	* gal-view-instance-save-as-dialog.glade: prepend label " " before
	the ETable

	* gal-view-instance-save-as-dialog.c
	(gal_view_instance_save_as_dialog_set_instance): select first row
	(gal_view_instance_save_as_dialog_init): show the etable

svn path=/trunk/; revision=26338
2004-06-14 17:43:12 +00:00
8cdc82ce8c HIGified, updated as suggested in #46236
2004-06-10  Radek Doulik  <rodo@ximian.com>

	* gal-view-instance-save-as-dialog.glade: HIGified, updated as
	suggested in #46236

	* gal-view-instance-save-as-dialog.c (gvisad_setup_radio_buttons):
	removed notebook with help text switching
	(gal_view_instance_save_as_dialog_init): set dialog title

	Fixes #46236

svn path=/trunk/; revision=26292
2004-06-10 20:10:13 +00:00
2463928c90 remove defunct Revert button and replace OK/Cancel buttons with a Close
2004-06-08  Jon Oberheide  <jon@focalhost.com>

	* gal-define-views-dialog.c (gal_define_views_dialog_init),
	gal-define-views.glade: remove defunct Revert button and replace
	OK/Cancel buttons with a Close button.  Fixes bug #48131.

svn path=/trunk/; revision=26279
2004-06-10 11:11:12 +00:00
c353f10796 Fixes #48129
2004-05-10  Jon Oberheide  <jon@focalhost.com>

	Fixes #48129

	* gal-view-new-dialog.c (gal_view_new_dialog_init): set dialog
	title

svn path=/trunk/; revision=25837
2004-05-10 13:13:18 +00:00
d12f139ad4 don't issue the display view signal a second time, connect_view does this
2004-04-05  JP Rosevear <jpr@ximian.com>

	* gal-view-instance.c (gal_view_instance_set_current_view_id):
	don't issue the display view signal a second time, connect_view
	does this for us

svn path=/trunk/; revision=25324
2004-04-05 21:12:21 +00:00
c074252e4f NULL out priv->instance when we unref it. Bug #51713.
2003-12-10  Not Zed  <NotZed@Ximian.com>

        * menus/gal-view-menus.c (remove_instance): NULL out
        priv->instance when we unref it.  Bug #51713.

svn path=/trunk/; revision=23895
2003-12-10 01:12:42 +00:00
1a80fb97d5 shared object looks for wrong mo file"
2003-10-28  Suresh Chandrasekharan  <suresh.chandrasekharan@sun.com>


	* Fix for "50258 libgal: shared object looks for wrong mo file"

svn path=/trunk/; revision=23163
2003-11-03 02:06:02 +00:00
2bebec36f0 fix string duplication and refcounting problems.
2003-06-23  Larry Ewing  <lewing@ximian.com>

	* gal-define-views-dialog.c (gdvd_button_new_dialog_callback): fix
	string duplication and refcounting problems.

2003-06-20  Larry Ewing  <lewing@ximian.com>

	* gal-view-etable.c (config_changed): unref after g_object_get
	adds a ref.

svn path=/trunk/; revision=21516
2003-06-23 19:11:46 +00:00
d09737dec4 block the signal that got us here until we're done to stop an infinite
2003-05-16  Mike Kestner  <mkestner@ximian.com>

	* gal-view-collection.c (view_changed): block the signal
	that got us here until we're done to stop an infinite
	recursion.  Fixes 43153.

2003-05-16  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (invisible_finalize): kill
	(ect_stop_editing): destroy the invisible, not weak_unref
	(e_cell_text_view_get_invisible): don't weak_ref the invisible
	since we own its ref.

2003-05-16  Mike Kestner  <mkestner@ximian.com>

	* e-table-item.c (eti_event): fix a couple timer checks
	* e-tree-table-adapter.c (update_node): Traverse POST order
	so that the parent nodes are at the head of the prepended list.
	Don't restore expanded state to nodes that aren't in the tree
	any longer.  Hopefully fixes #42856.

svn path=/trunk/; revision=21229
2003-05-16 21:58:33 +00:00
2679330687 Make sure the galview.xml file exists before trying to parse it with
2003-05-16  Jeffrey Stedfast  <fejj@ximian.com>

	* gal-view-collection.c (load_single_dir): Make sure the
	galview.xml file exists before trying to parse it with
	xmlParseFile() to avoid warning spewage from libxml2.

svn path=/trunk/; revision=21219
2003-05-16 18:27:37 +00:00
7e7b7f49e8 Disable debugging messages.
* gal-view-collection.c (d): Disable debugging messages.

* gal-view-instance.c (d): Disable debugging messages.

svn path=/trunk/; revision=21198
2003-05-15 21:56:40 +00:00
d49d8a2f15 guard against multiple destroys
2003-05-14  JP Rosevear  <jpr@ximian.com>

	* e-combo-button.c (impl_destroy): guard against multiple destroys

2003-05-14  JP Rosevear  <jpr@ximian.com>

	* menus/gal-view-menus.c (gvm_finalize): unref the component

svn path=/trunk/; revision=21178
2003-05-14 18:42:38 +00:00
990d1ba48a (gal_view_menus_unmerge): Guard against
the BonoboUIComponent not having a container to prevent a warning.

svn path=/trunk/; revision=21155
2003-05-13 16:11:26 +00:00
8910fc09d9 Don't convert the label charset from UTF-8 into the locale charset.
2003-04-23  Jeffrey Stedfast  <fejj@ximian.com>

	* menus/gal-view-menus.c (build_menus): Don't convert the label
	charset from UTF-8 into the locale charset.

svn path=/trunk/; revision=20985
2003-04-28 17:48:02 +00:00
960163b188 Try stat'ing the file before loading it with xmlParseFile() to avoid
2003-04-23  Jeffrey Stedfast  <fejj@ximian.com>

	* gal-view-instance.c (load_current_view): Try stat'ing the file
	before loading it with xmlParseFile() to avoid warnign spewage
	from libxml2 saying that the file doesn't exist.

svn path=/trunk/; revision=20955
2003-04-24 16:46:50 +00:00
bd5da6d3e1 Free the id when we're done with it.
2003-04-15  Hans Petter Jansson  <hpj@ximian.com>

	* gal-view-instance.c (gal_view_instance_get_popup_menu): Free the
	id when we're done with it.

svn path=/trunk/; revision=20854
2003-04-15 21:37:46 +00:00
c0c761da5f fix padding and default size. Fixed warnings elsewhere in file.
2003-04-15  Mike Kestner  <mkestner@ximian.com>

	* gal-define-views-dialog.c (g_d_v_d_init): fix padding and
	default size.  Fixed warnings elsewhere in file.
	(g_d_v_d_set_collection): set the dialog title

svn path=/trunk/; revision=20851
2003-04-15 21:29:29 +00:00
7acf500ad5 use stock buttons, remove desc frame. #if out the copy button. add
2003-04-10  Mike Kestner  <mkestner@ximian.com>

	* gal-define-views.glade : use stock buttons, remove desc frame.
	* gal-define-views-dialog.c (gdvd_init): #if out the copy button.
	* gal-view-instance.c (g_v_i_get_popup_menu): add ellipsis to
	Define Views menuitem.

svn path=/trunk/; revision=20804
2003-04-10 17:47:08 +00:00
8e56e45ae6 add ... to "Define Views" and "Save Custom View" menuitem labels.
2003-04-10  Mike Kestner  <mkestner@ximian.com>

	* menus/gal-view-menus.c (build menus): add ... to "Define Views"
	and "Save Custom View" menuitem labels.

svn path=/trunk/; revision=20802
2003-04-10 15:22:13 +00:00
1735baf281 fix button order fix button order fix button order
2003-04-08  Mike Kestner  <mkestner@ximian.com>

	* gal-define-views-dialog.c : fix button order
	* gal-view-instance-save-as-dialog.c : fix button order
	* gal-view-new-dialog.c : fix button order

svn path=/trunk/; revision=20755
2003-04-08 15:31:51 +00:00
a4f6a54e0a (set_state): Removed debugging message.
svn path=/trunk/; revision=20548
2003-03-27 16:39:32 +00:00
8794fa517a Use glib macro G_GNUC_FUNCTION instead of __FUNCTION__. Thank u, Ettore.
2003-03-19  Sanshao Jiang  <alex.jiang@sun.com>

	* gal-view-collection.c (gal_view_collection_append_with_title):
	(gal_view_collection_set_nth_view): Use glib macro G_GNUC_FUNCTION
	instead of __FUNCTION__. Thank u, Ettore.

	* gal-view-instance.c (gal_view_instance_set_current_view_id): same
	(add_popup_radio_item): Fix to be compilable on other compilers,
	using gcc extension independent codes.(bug#39176)
	(add_popup_menu_item): same

svn path=/trunk/; revision=20455
2003-03-21 17:32:04 +00:00
8bc5772286 Instead of using gtk_widget_unparent(), remove the widget from the
2003-03-17  Hans Petter Jansson  <hpj@ximian.com>

	* gal-define-views-dialog.c (gal_define_views_dialog_init): Instead
	of using gtk_widget_unparent(), remove the widget from the container
	using gtk_container_remove(). This fixes crashers where the dialog
	is being used.

	* gal-view-instance-save-as-dialog.c
	(gal_view_instance_save_as_dialog_init): Ditto.

	* gal-view-new-dialog.c (gal_view_new_dialog_init): Ditto.

svn path=/trunk/; revision=20324
2003-03-17 22:31:22 +00:00
0b82cc7a34 use access() like camel
2003-03-14  Mike Kestner  <mkestner@ximian.com>

	* gal/util/e-util.c (e_mkdir_hier): use access() like camel

2003-03-14  Mike Kestner  <mkestner@ximian.com>

	* gal-view-collection.c (gal_view_collection_load): check failure
	on e_create_directory call and warn.
	* gal-view-instance.c (save_current_view): check for failure and
	warn.

svn path=/trunk/; revision=20291
2003-03-14 17:19:25 +00:00
3de88468be Use G_GNUC_FUNCTION instead of __FUNCTION__.
* menus/gal-view-menus.c (gal_view_menus_unmerge): Use
G_GNUC_FUNCTION instead of __FUNCTION__.

* e-dropdown-button.c (menu_deactivate_cb): Removed debugging
spew.

svn path=/trunk/; revision=20200
2003-03-06 17:24:22 +00:00
fe4da718f0 Remove unneeded MAP_DIR define. (gladedir): Remove. Defined in
* e-timezone-dialog/Makefile.am (INCLUDES): Remove unneeded
	MAP_DIR define.
	(gladedir): Remove. Defined in configure.in now.

	* menus/gal-view-menus.c: #include <string.h>

svn path=/trunk/; revision=19773
2003-02-05 22:04:48 +00:00
285b33d516 Here too.
2003-01-15  Jeffrey Stedfast  <fejj@ximian.com>

	* gal-view-instance.c (save_current_view): Here too.

	* gal-view-collection.c (gal_view_collection_save): Use
	e_xml_save_file().

svn path=/trunk/; revision=19479
2003-01-15 19:38:50 +00:00
be8b72f963 add the parent arg.
2002-12-18  Chris Toshok  <toshok@ximian.com>

	* gal-view.[ch] (gal_view_edit): add the parent arg.

	* gal-view-new-dialog.c (gal_view_new_dialog_init): set the dialog
	modal.

	* gal-view-etable.c (gal_view_etable_edit): take the parent arg
	and pass it to e_table_config_new.

	* gal-define-views-dialog.c (gdvd_button_new_dialog_callback):
	pass the dialog as the parent to gal_view_edit.
	(gdvd_button_modify_callback): same.
	(gdvd_button_new_callback): set view_new_dialog transient for
	dialog.

svn path=/trunk/; revision=19164
2002-12-19 02:23:44 +00:00
02a2b0046f protect against null instance_id's (bug#35540)
2002-12-13  Mike Kestner  <mkestner@ximian.com>

	* gal-view-instance.c (gal_view_instance_construct):
	protect against null instance_id's (bug#35540)

svn path=/trunk/; revision=19118
2002-12-14 05:27:01 +00:00
8d8578a64d check for null or blank view names
2002-12-10  Gilbert Fang  <gilbert.fang@sun.com>

	* gal-define-views-dialog.c (gdvd_button_new_dialog_callback):
	check for null or blank view names

svn path=/trunk/; revision=19096
2002-12-11 05:51:47 +00:00
1a61aa98b3 convert some GnomeDialog stuff to GtkDialog.
2002-11-16  Chris Toshok  <toshok@ximian.com>

	* gal-view-instance.c: convert some GnomeDialog stuff to
	GtkDialog.

	* gal-view-instance-save-as-dialog.c: remove GnomeDialog
	references.

	* gal-view-new-dialog.c: same.

svn path=/trunk/; revision=18813
2002-11-17 07:59:50 +00:00
09e8fe2317 GtkObject->Gobject and GnomeDialog->GtkDialog work.
2002-11-16  Chris Toshok  <toshok@ximian.com>

	* gal-view-instance-save-as-dialog.c: GtkObject->Gobject and
	GnomeDialog->GtkDialog work.

	* gal-view-new-dialog.[ch]: same.

	* gal-view-new-dialog.dialog: same.

svn path=/trunk/; revision=18799
2002-11-16 23:46:27 +00:00
b75c80d63f use GtkDialog's ::response instead of GnomeDialog's ::clicked.
2002-11-14  Chris Toshok  <toshok@ximian.com>

	* menus/gal-view-menus.c (define_views): use GtkDialog's
	::response instead of GnomeDialog's ::clicked.
	(dialog_response): use response id's.
	(gvm_finalize): fix warning.

svn path=/trunk/; revision=18768
2002-11-15 00:26:42 +00:00
8539e8dd1a hrm, we shouldn't need to do this, but gtk_widget_show_all the custom
2002-11-14  Chris Toshok  <toshok@ximian.com>

	* gal-define-views-dialog.c (gal_define_views_dialog_init): hrm,
	we shouldn't need to do this, but gtk_widget_show_all the custom
	widget so it actually shows up.

svn path=/trunk/; revision=18767
2002-11-15 00:26:02 +00:00
6c2f176cb6 more porting work.
2002-11-13  Chris Toshok  <toshok@ximian.com>

	* gal-define-views-dialog.[ch]: more porting work.

	* gal-define-views-model.[ch]: same.

	* gal-view-etable.c: same.

	* gal-view-factory-etable.c: same.

	* gal-view-instance-save-as-dialog.[ch]: same.

	* gal-view-instance.c: same.

	* gal-view-new-dialog.[ch]: same.

	* gal-define-views.glade: convert to glade2.

	* gal-view-instance-save-as-dialog.glade: same.

	* gal-view-new-dialog.glade: same.

svn path=/trunk/; revision=18749
2002-11-13 23:34:40 +00:00
d023f5d548 menus/gal-view-menus.h GObjectified.
* menus/gal-view-menus.h
* menus/gal-view-menus.c: GObjectified.

* e-timezone-dialog/e-timezone-dialog.h
* e-timezone-dialog/e-timezone-dialog.c: GObjectified.

svn path=/trunk/; revision=18747
2002-11-13 22:53:58 +00:00
cd31ceb85f start porting to GObject.
2002-11-13  Chris Toshok  <toshok@ximian.com>

	* gal-view-collection.[ch]: start porting to GObject.

	* gal-view-etable.[ch]: same.

	* gal-view-factory-etable.[ch]: same.

	* gal-view-factory.[ch]: same.

	* gal-view-factory.[ch]: same.

	* gal-view-instance.[ch]: same.

	* gal-view.[ch]: same.

svn path=/trunk/; revision=18745
2002-11-13 20:20:01 +00:00
d9b4457fa6 gnome-xml->libxml
2002-11-13  Not Zed  <NotZed@Ximian.com>

        * menus/gal-view-menus.c: gnome-xml->libxml

        * menus/gal-view-menus.h: gnome-xml->libxml

svn path=/trunk/; revision=18734
2002-11-13 09:42:55 +00:00
9c73777f22 First big sync of my GNOME 2 porting work (incomplete, and still
pretty broken).

Weeeeee!

svn path=/trunk/; revision=18503
2002-11-02 08:25:03 +00:00
613453b109 merging the gal-2 branch back to the trunk.
merging the gal-2 branch back to the trunk.

svn path=/trunk/; revision=18471
2002-10-31 21:30:57 +00:00
48c16713cc ref/unref the gvm
2002-08-15  Mike Kestner  <mkestner@ximian.com>

	* menus/gal-view-menus.c (build_stuff): ref/unref the gvm

svn path=/trunk/; revision=17780
2002-08-15 15:23:17 +00:00
5ad6f45cbc Edit the view after appending it to the model.
2002-06-16  Christopher James Lahey  <clahey@ximian.com>

	* gal-define-views-dialog.c (gdvd_button_new_dialog_callback):
	Edit the view after appending it to the model.

svn path=/trunk/; revision=17203
2002-06-16 22:42:03 +00:00
ad1e5a3b6a Added this function to let you disable the define views dialog.
2002-06-04  Christopher James Lahey  <clahey@ximian.com>

	* menus/gal-view-menus.c, menus/gal-view-menus.h
	(gal_view_menus_set_show_define_views): Added this function to let
	you disable the define views dialog.

svn path=/trunk/; revision=17111
2002-06-04 22:12:08 +00:00
c1dadee81a Don't show this dialog more than once per collection.
2002-06-04  Christopher James Lahey  <clahey@ximian.com>

	* menus/gal-view-menus.c (define_views): Don't show this dialog
	more than once per collection.

svn path=/trunk/; revision=17106
2002-06-04 17:16:57 +00:00
5127b10e8b Added this function to set the user visible name of this collection.
2002-06-04  Christopher James Lahey  <clahey@ximian.com>

	* gal-view-collection.c, gal-view-collection.h
	(gal_view_collection_set_title): Added this function to set the
	user visible name of this collection.

	* gal-define-views-dialog.c (gal_define_views_dialog_init): Set
	the Define Views for %s label.  Fixes Ximian bug #2100 and #4080.

svn path=/trunk/; revision=17100
2002-06-04 12:19:33 +00:00
eec3b5a2f3 Made it so that if the current_id doesn't match any of the given ids, it
2002-05-14  Christopher James Lahey  <clahey@ximian.com>

	* menus/gal-view-menus.c (build_menus): Made it so that if the
	current_id doesn't match any of the given ids, it treats it the
	same as a NULL id.
	(gal_view_menus_apply): Added a check for gvm->priv == NULL here.
	(gal_view_menus_apply, collection_changed, instance_changed):
	Removed calls to set_radio after build_stuff, since the last thing
	build_stuff does is calls set_radio.

svn path=/trunk/; revision=16781
2002-05-14 07:04:49 +00:00
e1f208de7d Set the gettext-domain here.
2002-05-01  Christopher James Lahey  <clahey@ximian.com>

	* gal/e-text/e-completion-view.c (simple_spec),
	gal/widgets/e-categories-master-list-dialog.c (SPEC),
	gal/widgets/e-categories.c (INITIAL_SPEC): Set the gettext-domain
	here.

	* gal/util/e-i18n.h (E_I18N_DOMAIN): #define as makes sense in the
	different cases.

From gal/e-table/ChangeLog:

2002-05-01  Christopher James Lahey  <clahey@ximian.com>

	* e-table-config.c, e-table-config.h, e-table-specification.c,
	e-table-specification.h, e-table-utils.c, e-table-utils.h,
	e-table.c, e-table.h: Made these pay attention to the
	gettext-domain in the etspec.

	* e-table-config.c: Set the gettext-domain in the etspec here.

From gal/menus/ChangeLog:

2002-05-01  Christopher James Lahey  <clahey@ximian.com>

	* gal-define-views-dialog.c (SPEC),
	gal-view-instance-save-as-dialog.c (SPEC): Set the gettext-domain
	here.

svn path=/trunk/; revision=16658
2002-05-01 23:26:42 +00:00