Commit Graph

126 Commits

Author SHA1 Message Date
af2b5dd152 ** See #31027.
2004-06-18  Not Zed  <NotZed@Ximian.com>

        ** See #31027.

        * em-vfolder-editor.c (em_vfolder_editor_new): make sure we
        construct the rule editor with a source of 'incoming', otherwise
        newly created rules have no source in the current session.

        * em-vfolder-rule.c (em_vfolder_rule_init): init the vfolder
        source to 'incoming' always.

        * mail-vfolder.c (uri_is_ignore): fix debug statement.

svn path=/trunk/; revision=26415
2004-06-18 08:57:50 +00:00
a218c7d2f7 ** See #59885.
2004-06-17  Not Zed  <NotZed@Ximian.com>

        ** See #59885.

        ** Moved all of the mail specific filtering stuff from filter/* to
        here.  Renamed appropriately into em* space, etc.

        * em-filter-folder-element.c (emff_copy_value): implement for folders.

        * em-vfolder-rule.c (get_widget): read the vfolder glade from
        mail-config.glade.

        * mail-config.glade: moved the vfolder source selector here.

        * em-search-context.c: new mail search specific rule context.

        * mail-component.c (setup_search_context): use the new
        em_search_context.

        * vfolder-rule.c (validate): change error to mail context.

        * filter-folder.c (validate): change error to mail context.

        * Makefile.am (em-filter-i18n.h): added rule for i18n of mail
        filter type stuff.
        (libevolution_mail_la_SOURCES): added in the filter and vfolder
        rule stuff specific to mail.

        ** See #59885.

        * em-format-html-quote.[ch]: remove and remove from build, not
        used.

        * Makefile.am (libevolution_mail_la_LIBADD): add libeabutil and
        evolutionsmime.

        * mail-component-factory.c (factory): there is no mail_config
        anymore.

svn path=/trunk/; revision=26380
2004-06-17 07:34:50 +00:00
87ae2d3b9c don't check rule->source, its irrelevent to vfolder sources, and clean up
2004-06-14  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (rule_changed): don't check rule->source, its
        irrelevent to vfolder sources, and clean up the logic a bit.
        #59158.

        * em-folder-tree.c (emft_popup_new_folder_response): destroy the
        create dialogue if we're firing up the vfolder creation window.

svn path=/trunk/; revision=26332
2004-06-14 04:56:24 +00:00
7832c0f051 initialise desc to NULL before using it later on. gcc doesn't warn on this
2004-05-26  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (vfolder_adduri_desc): initialise desc to NULL
        before using it later on.  gcc doesn't warn on this if you're not
        optimising.  Sigh.  Probably fix #59070, #59060, #58972 and
        friends.

svn path=/trunk/; revision=26096
2004-05-26 07:53:06 +00:00
bffafba763 ** Another unread count bug, #58814.
2004-05-22  Not Zed  <NotZed@Ximian.com>

        ** Another unread count bug, #58814.

        * mail-vfolder.c (context_rule_added):
        * mail-tools.c (mail_tool_uri_to_folder):
        * mail-component.c (mc_add_local_store_done): don't call mail note
        folder anymore, fix up headers.

        * mail-folder-cache.c (store_folder_opened)
        (mail_note_store_remove, mail_note_store): handle the new
        store:folder_opened signal.  Don't need the mail_note_folder hack
        anymore, mail_tool_uri_to_folder slowly does less.

svn path=/trunk/; revision=26042
2004-05-22 00:45:47 +00:00
31d87dbdfe no new message test if its the drafts folder too.
2004-05-18  Not Zed  <NotZed@Ximian.com>

        * mail-folder-cache.c (folder_changed): no new message test if its
        the drafts folder too.

        * mail-vfolder.c (vfolder_adduri_desc): use a nicer, account-based
        formatter for folder names.  Hmm, that was a good waste of time.
        For #55412.

svn path=/trunk/; revision=25955
2004-05-18 08:46:37 +00:00
e24fd5f7d1 removed.
2004-05-03  Not Zed  <NotZed@Ximian.com>

        * mail-send-recv.c (receive_update_done): removed.

        * em-mailer-prefs.h:
        * message-tag-followup.h:
        * mail-config-druid.h:
        * mail-tools.h: clean up & use forward decls.  Fix users with
        busted includes.

svn path=/trunk/; revision=25745
2004-05-03 10:31:00 +00:00
e23cf1ca36 ** Changed error messages to use EError.
2004-04-28  Not Zed  <NotZed@Ximian.com>

        ** Changed error messages to use EError.

svn path=/trunk/; revision=25653
2004-04-28 06:39:25 +00:00
9e126a8d01 Cleaned up header inclusions and added plenty of forward declarations.
2004-03-31  Not Zed  <NotZed@Ximian.com>

        * *.[ch]: Cleaned up header inclusions and added plenty of forward
        declarations.  Sped up complete re-compilation by upto 20%.

        ** See bug #55950.

        * em-utils.c (em_utils_in_addressbook): utility for checking if an
        email address is in the addressbook.  I can't tell if it works
        'cause it crashes eds.

        * em-format-html.c (emfh_gethttp): handle addressbook checking.

2004-03-30  Not Zed  <NotZed@Ximian.com>

        * mail-config.h: clean up the headers and use some forward decl's
        instead.

        * em-format-html.c (em_format_html_set_load_http): change state to
        an int 'style' instead.

        * em-folder-view.c (emfv_setting_notify): set the format load http
        option to the config value directly.

        ** See bug #56147.

        * message-list.c (clear_info): set the node data to NULL when we
        unref its data.
        (ml_get_save_id): use a different test for the root node, and
        return NULL if we don't have any data on the node (because we're
        cleaing it).

        ** See bug #54962.

        * em-folder-tree.c (emft_popup_new_folder_response): put back the
        old hack to open the vfolder editor if you try to create a folder
        under vfolders.

        ** See bug #55940.

        * mail-autofilter.c (mail_filter_rename_uri): map the uri to an
        email uri before passing to filter code.
        (mail_filter_delete_uri): same here.

svn path=/trunk/; revision=25261
2004-03-31 10:09:04 +00:00
c2ae77c018 fix for vfolder-rule api changes.
2004-02-20  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (mail_vfolder_add_uri): fix for vfolder-rule api
        changes.

svn path=/trunk/; revision=24816
2004-02-20 09:26:49 +00:00
d639971d8a call abort before we unref, aid debugging if we hit it.
2004-02-05  Not Zed  <NotZed@Ximian.com>

        * em-folder-tree.c (em_folder_tree_create_folder): call abort
        before we unref, aid debugging if we hit it.

        * mail-vfolder.c (uri_is_spethal): check for vfolder/vtrash
        folders.  Based on name check and store options.

svn path=/trunk/; revision=24626
2004-02-05 05:14:59 +00:00
ef8a0762ac ** See bug #53683.
2004-02-04  Not Zed  <NotZed@Ximian.com>

        ** See bug #53683.

        * mail-ops.c (mail_sync_store): new async op to call
        CamelStore::sync.

        * mail-component.c (impl_requestQuit): implement, check to see if
        we can quit, or have open or unsent messages (and are in online
        mode).
        (impl_quit): implement.  Trigger off a sync of all open stores,
        and return FALSE until its done.
        (impl_upgradeFromVersion): fixed the signature to match the idl,
        killed that warning at last.

        ** See bug #53832.

        * em-folder-browser.c (emfb_folder_properties): only show this if
        we have a uri set.  Strictly, the menu item shouldn't be
        activated.

        ** See bug #53131.

        * em-folder-browser.c (em_folder_browser_show_preview): copy the
        message list's cursor_uid before calling set_message, since it can
        get freed during setting the message.

svn path=/trunk/; revision=24608
2004-02-04 10:45:20 +00:00
ce042b31b6 ** See bug #53084 and others.
2004-01-27  Not Zed  <NotZed@Ximian.com>

        ** See bug #53084 and others.

        * em-migrate.c (em_migrate): remove the vfolder_revert hack.

        * em-composer-utils.c (ask_confirm_for_only_bcc): removed unused
        vars.

        * mail-tools.c (mail_tool_get_local_inbox): removed, handled by
        mail_component_get_folder now.

        * mail-component.c (mail_component_*): Changed the api slightly.
        Using NULL as the component argument automatically implies you
        want the default component.
        (em_uri_from_camel, em_uri_to_camel): moved to em-utils.[ch].  Ok
        so it isn't namespaced right ... *shrug*.
        (mail_component_get_local_inbox): removed.
        (mail_component_get_folder): single entry point for getting
        standard folders.  This is MT-Safe.
        (mail_component_get_folder_uri): single entry point for getting
        standard folder uri's.  This is MT-Safe.
        (add_store): removed, moved to mail_component_add_store.
        (mail_component_load_store_by_uri): call mail_component_add_store
        directly rather than copying its code.
        (default_*_folder*): Removed, use accessor methods instead, fixed
        all callers.
        (setup_local_store): renamed to mc_setup_local_store, use proper
        url encoding too.  make run-once and thread-safe.
        (MailComponentPrivate): Added a lock.
        (mail_control_new): exported properly to kill warnings.
        (mail_component_init): dont setup_local_store or add accounts
        here.
        (impl_createControls): setup local store/accounts here.
        (mail_component_peek): dont setup vfolder storage here.
        (mc_startup): internal function to startup stuff needed for gui
        operation.
        (setup_search_context): make run-once.
        (mail_component_peek_search_context): call setup_search_context
        incase it isn't setup yet.
        (impl_upgradeFromVersion): remove the local store setup hack.

svn path=/trunk/; revision=24462
2004-01-27 12:35:26 +00:00
b6e44f08f7 Make displayed_uid public.
2004-01-20  Not Zed  <NotZed@Ximian.com>

        * em-folder-view.c (EMFolderView): Make displayed_uid public.

        * em-folder-browser.c (em_folder_browser_show_preview): use
        em_folder_view_set_message rather than message_list_select_uid.
        When clearing, clear view->displayed_uid too.

2004-01-20  Not Zed  <NotZed@Ximian.com>

        ** See bug #52965.

        * mail-component.c (mail_component_init): removed an epfixme, it
        already is an object.
        (impl_upgradeFromVersion): call mail_note_store after running the
        upgrade for local folders.

        * em-migrate.c (em_migrate): revert the vfolders.xml after we've
        imported them.

        * mail-vfolder.c (vfolder_revert): new api to re-load the vfolders
        file.

svn path=/trunk/; revision=24322
2004-01-20 04:32:41 +00:00
04e3d88bcc if we can't open the pop3 cache dir, because it doesn't exist, it is not
2004-01-19  Not Zed  <NotZed@Ximian.com>

        * em-migrate.c (em_upgrade_pop_uid_caches_1_4): if we can't open
        the pop3 cache dir, because it doesn't exist, it is not an error.

        ** See bug #52983.

        * mail-component.c (em_uri_from_camel, em_uri_to_camel): Handle
        vfolder: uri's properly.  And make sure local uri's are properly
        encoded.
        (mail_component_get_folder_from_evomail_uri)
        (mail_component_evomail_uri_from_folder): removed, no longer used.
        (em_uri_from_camel): don't leak the camelurl.
        (d): disable debug

        * mail-vfolder.c (vfolder_load_storage): move the vfolder storage
        location to ~/.evolution/mail/vfolder rather than
        ~/.evolution/mail (this is currently unused anyway).
        (uri_is_ignore): short-circuit exit if we find a match.
        (mail_vfolder_add_uri): dont exit immediately if we have a vfolder
        uri, but don't add it to local/remove either.
        (mail_vfolder_delete_uri): remove any uri from the local/remote
        source list while we're at it.

svn path=/trunk/; revision=24300
2004-01-19 06:11:41 +00:00
13f513ef2a s/g_fre/g_free/
2004-01-16  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-vfolder.c (mail_vfolder_rename_uri): s/g_fre/g_free/

	* em-utils.c (guess_account): Change 'tmp' to not be const - fixes
	a compile warning.
	(em_utils_expunge_folder): Cast parent to a GtkWindow.
	(em_utils_empty_trash): Same.

svn path=/trunk/; revision=24279
2004-01-16 17:02:24 +00:00
7ab4ccfe76 change this to check the store using the provider url_cmp and just lookup
2004-01-16  Not Zed  <NotZed@Ximian.com>

        * mail-folder-cache.c (storeinfo_find_folder_info): change this to
        check the store using the provider url_cmp and just lookup the
        folder name directly.  folder_compare can't be used for uri's,
        this stuff was so broken, my fault :(

        ** See bug #52467.

        * em-folder-tree-model.c (sort_cb): handle null path (root?).

        * mail-vfolder.c (mail_vfolder_add_uri): map uri to euri before
        processing.
        (rule_changed): map uri to camel uri before looking up.
        (mail_vfolder_delete_uri): handle as euri internally.
        (mail_vfolder_rename_uri): "

        * mail-autofilter.c (vfolder_rule_from_message): map camel uri to
        euri before setting as vfolder source.

svn path=/trunk/; revision=24266
2004-01-16 07:14:15 +00:00
afe8c997fd Make vfolder_store 'global'.
2004-01-15  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-vfolder.c: Make vfolder_store 'global'.

	* em-folder-tree-model.c (sort_cb): Fix bug #12600 by not sorting
	VFolders (ie. show them in the same order they appear in the
	editor).

svn path=/trunk/; revision=24257
2004-01-15 21:56:00 +00:00
efa0b9c96b add total + unread counts to properties page.
2004-01-09  Not Zed  <NotZed@Ximian.com>

        * em-folder-tree.c (emft_popup_properties_got_folder): add total +
        unread counts to properties page.

        * em-utils.c (filter_editor_response):
        * mail-vfolder.c (vfolder_editor_response): change for rule editor
        changes, ACCEPT->OK.

svn path=/trunk/; revision=24125
2004-01-09 06:07:49 +00:00
7d18bf233d Do not depend on e-folder-list.
* gui/component/addressbook-config.c: Do not depend on
e-folder-list.

* gui/component/select-names/e-select-names.c: Remove dependency
on evolution-folder-selector-button.
(e_addressbook_create_folder_selector): Just return a FIXME label
for now.
(folder_selected): #if 0 out.
(e_select_names_init): Do not connect.

* gui/component/select-names/e-select-names-manager.c
(e_select_names_manager_activate_dialog): Don't get a shell_client
arg anymore.
(load_completion_books): Stub out.

* gui/component/select-names/e-select-names.c
(e_select_names_new): Don't get an EvolutionShellClient anymore.
Don't create the folder selector button for now.

* gui/component/select-names/e-select-names.h: Remove dependency
on evolution-shell-client.

* gui/component/select-names/e-select-names-bonobo.c: Remove
dependency on evolution-shell-client.
(impl_SelectNames_activate_dialog): Stub out.

* gui/widgets/eab-gui-util.c: Remove dependency on
evolution-shell-client.
(eab_transfer_contacts): Stub out.

* importers/icalendar-importer.c: Do not #include shell stuff.

* gui/main.c: Do not #include <evolution-shell-client.h>.

* gui/e-itip-control.c: Do not #include
<e-folder-selector-button.h> nor <evolution-shell-client.h>.
(start_default_server): Return FALSE.
(default_server_started_cb): Do not connect the "selected" signal
on the button since it's now NULL.
(button_selected_cb): #if 0 out.

* gui/e-cal-list-view.h: Do not #include
"evolution-activity-client.h".

* gui/tasks-component.c (impl_createControls): Give an empty label
for the status bar.

* gui/e-day-view.h: Remove all deps on evolution-activity-client.

* e-msg-composer-hdrs.c: Do not #include
<evolution-folder-selector-button.h>.
(e_msg_composer_hdrs_set_post_to): #if 0 out for now.
(e_msg_composer_hdrs_get_post_to): Likewise.

* mail-vfolder.c: Do not #include "evolution-shell-component.h".

* Makefile.am (libevolution_mail_la_SOURCES): Don't compile
mail-importer.[ch] for now.

* mail-component-factory.c: Do not #include
<evolution-shell-client.h>.
* mail-config.c: Likewise.

* mail-vfolder.h: Do not #include <evolution-storage.h> or
<evolution-shell-component.h>.

* mail.h: Do not #include <evolution-storage.h>.

* mail-ops.h: Do not #include <evolution-storage.h>.
(mail_scan_subfolders): Remove prototype.
(mail_update_subfolders): Likewise.

svn path=/trunk/; revision=23595
2003-12-03 15:37:56 +00:00
bef1822556 Remove all the syncFolder stuff since it's not in the Component interface
* mail-offline-handler.c: Remove all the syncFolder stuff since
it's not in the Component interface anymore.

* mail-mt.c: Remove declaration for global_shell_client.  #if 0
all the code that uses that.

* mail-component-factory.c: Remove declaration for
global_shell_client.

* mail-vfolder.c: Remove declaration for global_shell_client.

svn path=/trunk/; revision=23506
2003-11-30 20:53:49 +00:00
83c14461d1 We can't use a uri to do a lookup of a store-info on the store_hash, we
2003-11-14  Jeffrey Stedfast  <fejj@ximian.com>

	* em-folder-tree.c (emft_popup_new_folder_response): We can't use
	a uri to do a lookup of a store-info on the store_hash, we have to
	get a CamelStore first.
	(row_draggable_cb): validate the iter before using it.
	(row_drop_possible_cb): Same.
	(drag_data_received_cb): Here too.
	(drag_data_get_cb): Same.
	(drag_data_delete_cb): Again here.
	(tree_store_set_folder_info): Recursively add nodes if fi->child
	is non-NULL rather than adding a dummy node.
	(folder_renamed_cb): Implemented.

svn path=/trunk/; revision=23367
2003-11-14 22:28:34 +00:00
c4652e9705 Updated for function name changes in mail-component.c
2003-11-13  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-vfolder.c (vfolder_load_storage): Updated for function name
	changes in mail-component.c

	* mail-offline-handler.c: Updated for function name changes in
	mail-component.c

	* mail-account-gui.c (add_new_store): Fixed to not use EStorage.
	(mail_account_gui_save): Updated for function name changes.

	* em-account-prefs.c (account_delete_clicked): Updated for
	function name changes.
	(account_able_clicked): Same.
	(account_able_toggled): Same.

	* mail-component.c: Renamed mail_component_*storage*() functions
	to mail_component_*store*() since we are no longer dealing with
	storages, but instead with CamelStore's.
	(create_view_widget): If the user selects a store node, don't try
	to open it as a folder.

svn path=/trunk/; revision=23341
2003-11-13 22:33:14 +00:00
1627a08174 Modified to not use EStorage* functions. I don't even think it *needs* to
2003-11-13  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-vfolder.c (context_rule_removed): Modified to not use
	EStorage* functions. I don't even think it *needs* to remove the
	folder from the mail-component, the mail-component should just
	pick it up automagically via CamelStore events.

svn path=/trunk/; revision=23333
2003-11-13 19:43:50 +00:00
8e1251fa17 merged spam filtering branch
svn path=/trunk/; revision=23302
2003-11-12 21:13:05 +00:00
49265bef8d User vfolder rules should be in ${evolution_dir}/mail/vfolders.xml rather
2003-11-06  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-vfolder.c (mail_vfolder_delete_uri): User vfolder rules
	should be in ${evolution_dir}/mail/vfolders.xml rather than
	${evolution_dir}/vfolders.xml
	(mail_vfolder_rename_uri): Same.
	(store_folder_deleted): Here too.
	(store_folder_renamed): And here.
	(vfolder_load_storage): Again here.
	(vfolder_editor_response): Same.
	(edit_rule_response): And here.
	(new_rule_clicked): Here too.

	* mail-session.c (main_get_filter_driver): User filter rules
	should be in ${evolution_dir}/mail/filters.xml rather than
	${evolution_dir}/filters.xml

	* mail-autofilter.c (filter_gui_add_from_message): Same.
	(mail_filter_rename_uri): And here.
	(mail_filter_delete_uri): Here too.

	* em-utils.c (filter_editor_response): Again here.
	(em_utils_edit_filters): Same.

	* em-migrate.c (em_migrate_filter_file): Same (also for
	vfolders.xml)

2003-11-05  Jeffrey Stedfast  <fejj@ximian.com>

	* em-migrate.[c,h]: New source files to migrate from the old mail
	directory to the new mail directory.

	* mail-component.c (mail_component_init): Changed to use
	~/.evolution and added code to migrate the old mail folders over
	if ~/.evolution/mail does not yet exist.

svn path=/trunk/; revision=23201
2003-11-06 21:54:49 +00:00
8ee9b35810 removed #include "folder-browser.h"
svn path=/trunk/; revision=23007
2003-10-22 21:39:34 +00:00
0fb08f3ff8 Merge new-ui-branch to the trunk.
svn path=/trunk/; revision=22964
2003-10-21 18:28:34 +00:00
81a0ff5bc4 cvs removed.
2003-09-17  Not Zed  <NotZed@Ximian.com>

         * folder-browser.c, folder-browser.h, folder-browser-ui.c
         folder-browser-ui.h, mail-callbacks.c, mail-callbacks.h
         mail-display.c, mail-display.h, mail-display-stream.c
         mail-display-stream.h, mail-format.c, mail-format.h
         mail-identify.c, mail-search.c, mail-search.h
         message-browser.c, message-browser.h, subscribe-dialog.c
         subscribe-dialog.h, mail-font-prefs.c, mail-font-prefs.h: cvs
         removed.

        * Makefile.am: Removed mail-font-prefs.[ch], hasn't been built for
        ages.

        * em-*.c: killed a bunch of printfs.

        * em-format-html-display.c (efhd_html_button_press_event): update
        for html object api chagnes.

        ** Merge in mail-refactor-2 branch.

svn path=/trunk/; revision=22602
2003-09-17 21:19:04 +00:00
a356037663 Fix type warnings (folder_browser_toggle_caret_mode): Remove unused
* folder-browser.c (message_list_drag_data_get): Fix type warnings
	(folder_browser_toggle_caret_mode): Remove unused variable.

	* folder-browser-ui.c (basename): remove unused function

	* mail-account-gui.c (mail_account_gui_build_extra_conf): Fix
	warnings

	* mail-callbacks.c (empty_trash): Remove unused variable.

	* mail-display.c: #include gal/widgets/e-gui-utils.h for
	e_auto_kill_popup_menu_on_selection_done

	* mail-importer.c: #include e-util/e-path.h for e_path_to_physical

	* mail-session.c (main_play_sound): don't declare filename to be
	const and then free it.

	* mail-vfolder.c (vfolder_edit_rule, vfolder_gui_add_rule): Fix
	casts

	* message-list.c (build_flat_diff): Fix a typo in the
	non-BROKEN_ETREE code

svn path=/trunk/; revision=21903
2003-07-23 15:01:26 +00:00
cec1fb093d ** See bug #44609
2003-06-16  Not Zed  <NotZed@Ximian.com>

        ** See bug #44609

        * mail-vfolder.c (vfolder_edit_rule): put the ok/cancel buttons in
        the stupid gnome 2 order.

        ** See bug #33593

        * message-list.c (on_selection_changed_cmd): also listedn to
        selection changed events, since the etable api has changed.
        (get_selected_cb): helper for above.
        (message_list_construct): hook to selection change signal.

        * mail-callbacks.c (composer_send_queued_cb): Unref the composer
        to match the ref composer_send_cb();

        ** See bug #44519

        * message-browser.c (message_browser_message_list_built): We want
        to disconnect from the messagelist, not folderbrowser signal.

svn path=/trunk/; revision=21452
2003-06-17 03:15:46 +00:00
974528e1d8 Set the correct border width and vbox spacing to be HIG compliant. Fixes
2003-04-14  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-vfolder.c (vfolder_gui_add_rule): Set the correct border
	width and vbox spacing to be HIG compliant. Fixes bug #41209.
	(vfolder_edit_rule): Same here.

	* local-config.glade: Updated to comply with the HIG. Fixes bug
	#41244.

svn path=/trunk/; revision=20846
2003-04-15 17:29:17 +00:00
907f029cc1 swap button order. For #40900.
2003-04-08  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (vfolder_gui_add_rule): swap button order.  For
        #40900.

svn path=/trunk/; revision=20740
2003-04-08 00:55:44 +00:00
fea6083abf Update for e_notice move (apply_changes): Pass a parent_window to e_notice
* mail-account-editor.c: Update for e_notice move
	(apply_changes): Pass a parent_window to e_notice

	* mail-account-gui.c: Update for e_notice move.
	(mail_account_gui_save): Pass a parent_window to e_notice

	* mail-callbacks.c: Update for e_notice move
	* mail-local.c: Likewise
	* mail-signature-editor.c: Likewise
	* mail-vfolder.c: Likewise

svn path=/trunk/; revision=20502
2003-03-25 15:49:19 +00:00
9623072931 validate rule & rule is unique. Workaround for #39464. Should this just
2003-03-18  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (new_rule_clicked): validate rule & rule is
        unique.  Workaround for #39464.  Should this just use
        rule_context_add_rule_gui??

svn path=/trunk/; revision=20333
2003-03-18 08:31:28 +00:00
c56a8e8c2d Part of a fix for bug #39809
2003-03-17  Jeffrey Stedfast  <fejj@ximian.com>

	Part of a fix for bug #39809

	* mail-vfolder.c (vfolder_edit): Don't add the cancel button here.

	* mail-callbacks.c (filter_edit): Don't add the cancel button here.

svn path=/trunk/; revision=20316
2003-03-17 19:55:25 +00:00
c8a1141a55 Fix the response code, because some bastard changed the filter/* code and
2003-03-11  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (vfolder_editor_response): Fix the response code,
        because some bastard changed the filter/* code and didn't fix the
        callers.  Partial fix for #39165.

svn path=/trunk/; revision=20231
2003-03-10 08:17:05 +00:00
0701addc19 Use g_signal_emit() rather than gtk_signal_emit(). (build_flat): Same
2003-02-10  Jeffrey Stedfast  <fejj@ximian.com>

	* message-list.c (build_tree): Use g_signal_emit() rather than
	gtk_signal_emit().
	(build_flat): Same here.

	* mail-signature-editor.c: #include <string.h>

	* mail-vfolder.c: #include <string.h>

	* mail-session.c: #include <string.h>

	* mail-search.c: #include <string.h>

	* mail-mt.c: #include <string.h>

	* mail-ops.c (save_part_save): Use strcasecmp() instead of
	g_strcasecmp().

	* mail-local.c: #include <string.h>
	(reconfigure_folder_reconfigured): Use a GtkDialog instead of
	gnome_error_dialog().

	* mail-format.c (find_preferred_alternative): Use g_ascii_strdown
	since g_strdown is deprecated.
	(fake_mime_part_from_data): Removed, no longer used it seems.
	(destroy_part): Also removed.

	* mail-display.c (make_popup_window): Replace call to
	gtk_window_set_polociy() with gtk_window_set_resizable() instead.
	(popup_size_allocate_cb): Use gtk_window_set_position() with
	GTK_WIN_POS_MOUSE instead of calculating the position to put it
	in.

svn path=/trunk/; revision=19878
2003-02-10 19:50:55 +00:00
8b11adc287 add EVOLUTION_PRIVDATADIR
* Makefile.am (INCLUDES): add EVOLUTION_PRIVDATADIR

	* component-factory.c (owner_set_cb): Use EVOLUTION_PRIVDATADIR
	* mail-autofilter.c (filter_gui_add_from_message): Likewise
	(mail_filter_rename_uri): Likewise
	(mail_filter_delete_uri): Likewise
	* mail-callbacks.c (filter_edit): Likewise.
	* mail-search-dialogue.c (mail_search_dialogue_construct):
	Likewise
	* mail-session.c (main_get_filter_driver): Likewise
	* mail-summary.c (generate_folder_summaries): Likewise
	* mail-vfolder.c (vfolder_load_storage): Likewise

svn path=/trunk/; revision=19824
2003-02-06 18:44:33 +00:00
cd8eae592e Use EVOLUTION_GALVIEWSDIR.
* folder-browser-ui.c (folder_browser_ui_setup_view_menus): Use
EVOLUTION_GALVIEWSDIR.

* message-browser.c (set_bonobo_ui): Get
evolution-mail-messagedisplay.xml from EVOLUTION_UIDIR.

* mail-signature-editor.c (mail_signature_editor): Get
evolution-signature-editor.xml from EVOLUTION_UIDIR.

* folder-browser-ui.c (ui_add): Get the evoluiton-mail* XML files
from EVOLUTION_UIDIR.

* Makefile.am (INCLUDES): Define EVOLUTION_GALVIEWSDIR; update
EVOLUTION_IMAGESDIR to include the $(BASE_VERSION).
(gladedir): Version using $(BASE_VERSION).
(etspecdir): Likewise.
(iconsdir): Likewise.
(buttonsdir): Likewise.
(etspecdir): Likewise.

* component-factory.c (owner_set_cb): Look for vfoldertypes.xml in
the new version-aware location.
* mail-summary.c (generate_folder_summaries): Likewise.
* mail-search-dialogue.c (mail_search_dialogue_construct): Likewise.
* mail-vfolder.c (vfolder_load_storage): Likewise.

* mail-autofilter.c (filter_gui_add_from_message): Look for
filtertypes.xml in the new version-aware location.
(mail_filter_rename_uri): Likewise.
(mail_filter_delete_uri): Likewise.
* mail-session.c (main_get_filter_driver): Likewise.
* mail-callbacks.c (filter_edit): Likewise.

svn path=/trunk/; revision=19562
2003-01-22 20:11:58 +00:00
e0053bce8e Updated. (request_password): Same.
2003-01-17  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-session.c (do_get_pass): Updated.
	(request_password): Same.

	* mail-send-recv.c (mail_send): Fixed to use EAccountService.

	* mail-config-druid.c (make_account): Updated to use EAccount and
	friends.

	* mail-account-gui.c (service_check_supported): Updated to use
	EAccountService.
	(mail_account_gui_new): Ref the account passed in and also update
	to use EAccount objects.
	(save_service): Updated to use an EAccountService.
	(add_new_store): Updated to use an EAccount.
	(mail_account_gui_save): Updated to use EAccounts.
	(setup_signatures): Updated because the new account->id->def_sig
	is now an int and not a structure pointer.

	* mail-account-editor.c (construct): Updated.
	(mail_account_editor_new): Now takes an EAccount object as an
	argument instead of a MailConfigAccount.

	* mail-crypto.c (mail_crypto_get_pgp_cipher_context): Updated to
	use EAccounts.

	* subscribe-dialog.c (populate_store_foreach): Removed.
	(populate_store_list): Can't use populate_store_foreach here
	because of the change to EAccountList so do it manually.

	* mail-vfolder.c (uri_is_ignore): Rewrote to use EAccountList and
	EIterator and all that fun.

	* mail-send-recv.c (build_dialogue): Updated to use EAccountList
	and EAccount object stuff. *ugh*
	(mail_send_receive): Here too.
	(mail_autoreceive_setup): Same.

	* mail-callbacks.c (check_send_configuration): Updated.
	(composer_get_message): Updated.
	(compose_msg): "
	(list_add_addresses): "
	(guess_me): "
	(guess_me_from_accounts): Same.
	(forward_get_composer): Here too.
	(mail_generate_reply): Same.
	(redirect_get_composer): "
	(empty_trash): And finally here.

	* mail-accounts.c (account_edit_clicked): Updated.
	(account_delete_clicked): Same.
	(account_default_clicked): Here too.
	(account_able_clicked): "
	(account_cursor_change): "
	(mail_accounts_load): Again here.

	* folder-browser.c (folder_browser_is_drafts): Updated to use
	EAccountList and EAccount stuff.
	(folder_browser_is_sent): Same.

	* component-factory.c (mail_load_storages): Updated to use
	EAccount and EAccountList stuff.
	(owner_set_cb): Same.
	(send_receive_cb): Here too.

	* mail-config.c: Rewritten to use EAccount and EAccountList
	objects.

svn path=/trunk/; revision=19509
2003-01-17 23:31:27 +00:00
84c85d8eb7 fixed to build with -DG_DISABLE_DEPRECATED
svn path=/trunk/; revision=19209
2003-01-02 20:52:15 +00:00
f37b0a1ab7 ...And a whole bunch more build fixes.
2002-12-17  Jeffrey Stedfast  <fejj@ximian.com>

	...And a whole bunch more build fixes.

	* mail-vfolder.c (mail_vfolder_delete_uri): Don't use
	g_string_sprintfa() anymore since it is apparently deprecated.

	* mail-session.c (main_get_filter_driver): Don't use
	g_string_sprintfa() anymore since it is apparently deprecated.

	* mail-ops.c (build_from): Don't use g_string_sprintfa() anymore
	since it is apparently deprecated.

	* mail-callbacks.c (ask_confirm_for_unwanted_html_mail): Don't use
	g_string_sprintfa() anymore since it is apparently deprecated.

	* mail-autofilter.c: Don't use g_string_sprintfa() anymore since
	it is apparently deprecated.

	* folder-browser.c: Don't use g_string_sprintfa() anymore since it
	is apparently deprecated.

	* mail-search.c (mail_search_set_subject): Remove the unnecessary
	g_strdup()'age as well as fix a possible buffer overrun.

	* mail-local.c (mail_local_folder_construct): Use
	g_path_get_basename().

	* mail-config-druid.c (make_account): Don't use e_utf8_*
	functions.

svn path=/trunk/; revision=19152
2002-12-17 20:38:25 +00:00
df22fc1623 gnome_pixmap -> gtkimage. (construct): gtk_clist -> gtk_tree_view, setup
2002-11-27  Not Zed  <NotZed@Ximian.com>

        * message-tag-followup.c (construct): gnome_pixmap -> gtkimage.
        (construct): gtk_clist -> gtk_tree_view, setup columns.  They dont
        size well :-/
        (message_tag_followup_append_message): Append using model, remove
        clist stuff.
        (construct): Show date edit (glade bugs?)

        * folder-browser.c (folder_browser_class_init): gtk_marshal -> g_cclosure_marshal
        (setup_popup_icons): gnome_pixmap -> gtk_image.
        (on_right_click): gtk_pixmap -> gtk_image.

        * mail-accounts.c (account_delete_clicked): removed #if 0'd out code.

        * mail-send-recv.c (receive_done): remove FIXME and extra unref.

        * mail-session.c (request_password): Removed #if 0'd out stuff.

        * mail-vfolder.c (new_rule_clicked): proper cast for g_object_get_data.

        * mail-local.c (reconfigure_response): cast for g_object_get_data.

        * mail-account-editor.c (construct): GNOME_DIALOG -> GTK_DIALOG.

        * *.[ch]: re-ran fix.sh for e_notice change

        * mail-callbacks.c (save_msg_ok): g_object_get_data +
        gtk_object_remove_no_notify -> g_object_steal_data.
        (find_socket): gtk_container_children ->
        gtk_container_get_children
        (edit_msg): gnome_*_dialog -> gtk_message_dialog.
        (resent_msg): "
        (search_msg): "
        (confirm_goto_next_folder): gtkmessagedialogised (even if not
        used).
        (confirm_expunge): gtkmessagedialogised
        (filter_edit): "
        (do_mail_print): e_notice -> gtk_message_dialog.
        (are_you_sure): removed e_gnome_ok_cancel_dialog crap, replaced
        with a gtk dialog.
        (are_you_sure): gtkmessagedialogised.
        (edit_msg_internal): Dont free uids array, are_you_sure() free's
        it.
        (resend_msg): Same.
        (check_send_configuration): Use e_notice for stuff.  Sigh, here we
        go again ...!
        (e_question): A utility function to ask a question, potentially
        with 'dont ask again' as well.
        (configure_mail): use e_question to save code.  Here we go again,
        again ...
        (ask_confirm_for_unwanted_html_mail): "
        (ask_confirm_for_only_bcc): "
        (ask_confirm_for_only_bcc): "
        (composer_get_message): Use e_notice.
        (composer_save_draft_cb): Use e_question
        (edit_msg): use e_notice, & change to an ERROR.
        (resend_msg): same.
        (save_msg_ok): Properly initialise ret to OK, and use e_question,
        and use access() to determine existance/write access rather than
        stat, display an error if we can't write to a file that exists,
        and print the filename in all dialogues.
        (confirm_goto_next_folder): Use e_question.
        (confirm_expunge): use e_question.
        (filter_edit): Use e_notice.
        (do_mail_print): use e_notice.

svn path=/trunk/; revision=18974
2002-12-02 03:16:54 +00:00
2382dbef3f clicked->response signal for gtk dialogue. (new_rule_clicked): Dont unref
2002-11-26  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (vfolder_gui_add_rule): clicked->response signal
        for gtk dialogue.
        (new_rule_clicked): Dont unref after destroy (duh, idiot again).
        (edit_rule_response): Same here.
        (mail_vfolder_delete_uri): Connect response signal to
        gtk_widget_destroy directrly using g_signal_connect_swapped.
        (close_dialogue): Removed, as no longer needed.

svn path=/trunk/; revision=18925
2002-11-26 12:06:35 +00:00
e3713d58cd fix warning message, outlook->mbox.
2002-11-19  Not Zed  <NotZed@Ximian.com>

        * importers/evolution-mbox-importer.c (mail_importer_module_init):
        fix warning message, outlook->mbox.

        * importers/Makefile.am: fix serverdir to point to
        $libdir/bonobo/servers.

        * mail-callbacks.c (addrbook_sender): add type to
        bonobo_widget_set_property.

        * mail-vfolder.c (vfolder_editor_response): dont unref after destroy.

        * mail-session.c (pass_response): dont unref aftrer destroy.

        * mail-local.c (reconfigure_response): dont unref after destroy.

        * mail-display.c (launch_cb): dont unref after destroy.
        (launch_cb): "
        (drag_data_get_cb): "
        (html_button_press_event): add type to bonobo_widget::set_property

        * mail-config.c (mail_config_check_service): dont unref after
        destroy.

        * component-factory.c (send_receive_cb): dont unref after destroy.
        (request_quit): "

        * mail-signature-editor.c (mail_signature_editor): Use version 3.0
        of gtkhtml editor interfaces.
        (do_exit): dont unref after destroy.
        (format_html_cb): Add type to bonobo_widget::set_property.

svn path=/trunk/; revision=18837
2002-11-19 05:03:29 +00:00
1669f16747 Want a (GWeakNotify) cast here, not (GWeakNotify *).
* component-factory.c (owner_set_cb): Want a (GWeakNotify) cast
here, not (GWeakNotify *).

* subscribe-dialog.c (fete_init): g_object_set() instead of
gtk_object_set().
(populate_store_list): Likewise.
(menu_item_selected): g_object_get_data() instead of
gtk_object_get_data().

* message-list.c (message_list_create_extras): g_object_set()
instead of gtk_object_set().

* message-browser.c (message_browser_message_list_built):
g_object_get_data() instead of gtk_object_get_data().

* mail-vfolder.c (edit_rule_response): g_object_get_data() instead
of gtk_object_get_data().

* mail-summary.c (generate_folder_summaries): g_object_unref() the
context instead of gtk_object_destroy().

* mail-local.c (reconfigure_response): g_object_get_data() instead
of gtk_object_get_data().

* mail-display.c (pixbuf_gen_idle): g_object_unref() the GdkPixbuf
loader instead of gtk_object_destroy().
(pixbuf_gen_idle): Likewise.
(embeddable_destroy_cb): Likewise.

* mail-config-druid.c (mail_config_druid_destroy): No need to
gtk_object_destroy() the GladeXML object.
(construct): g_object_set() instead of gtk_object_set().

* folder-browser.c (folder_browser_gui_init): g_object_get_data()
instead of gtk_object_get_data().

svn path=/trunk/; revision=18752
2002-11-14 17:20:52 +00:00
bc9886539a Do not #include <libgnome/gnome-defs.h>. Likewise. Likewise. Likewise.
* mail-format.c: Do not #include <libgnome/gnome-defs.h>.
* mail-importer.c: Likewise.
* mail-mt.c: Likewise.
* mail-ops.c: Likewise.
* mail-search-dialogue.c: Likewise.
* mail-session.c: Likewise.
* mail-vfolder.c: Likewise.
* message-tag-followup.c: Likewise.
* main.c: Likewise, and <libgnomeui/gnome-init.h>.

* mail-callbacks.c: Do not #include <libgnome/gnome-paper.h>.
(do_mail_print): Remove the GnomePaper local variable.

svn path=/trunk/; revision=18739
2002-11-13 16:46:52 +00:00
f9804e1193 Commented out stuff that doesn't build yet. Also fixed idl build rule.
2002-11-13  Not Zed  <NotZed@Ximian.com>

	* Makefile.am: Commented out stuff that doesn't build yet.  Also
	fixed idl build rule.  importers still not built.

	* main.c (main): bonobactivationise.  remove push visual/colormap.
	(main): no longer activate activation, let bonobo_init do it.

	* mail-signature-editor.c (menu_help): Change help api.

	* mail-session.c (user_message_destroy_noreply): removed.  Not
	used?

	* mail-local.c (load_metainfo): xml root->children.

	* mail-format.c (g_string_append_len): Removed, it exists now.

2002-11-12  Not Zed  <NotZed@Ximian.com>

	* subscribe-dialog.c: gnome2ised, use gtkdialog.
	(subscribe_get_global_extras): use a weak ref rather than destroy signal.

	* message-tag-followup.c: gnome2ised.

	* message-tag-editor.c: gnome2ised & converted to gtkdialog.

	* message-list.c: gnome2ised.
	(message_list_finalise): From destroy method.  maybe should be
	destroy still.

	* message-browser.c: port to gnome2
	(message_browser_finalise): renamed from destroy method.

	* mail-stream-gtkhtml.c: removed redundant
	camel_class_get_global_classfuncs() call.

	* mail-signature-editor.c: gtkdialogised, & bonobo api changes.


	* mail-search-dialogue.c: gtkdialogised.

	* mail-folder-cache.c: cleaned up camel ref/hook casts.

	* mail-composer-prefs.c (mail_composer_prefs_get_type): convert to
	gtype.

	* mail-font-prefs.c (mail_font_prefs_destroy): from finalise.

	* mail-config.c: s/bonobo_config/e_config_listener/
	Added /apps/Evolution prefix to the evolution keys.
	Changed to use e_config_listener, etc.
	(mail_config_init): remove bonobo_config stuff.
	(mail_config_check_service): gtk dialogise.
	(check_response): from check_cancelled.

	* mail-config-druid.c (mail_config_druid_destroy): renamed from
	_finalize, turned into destroy handler.
	(construct): set type to toplevel, GTK_WINDOW_DIALOG no longer exists.

	* mail-config-factory.c (mail_config_register_factory): bonobo api
	changes.

	* mail-crypto.c (mail_crypto_get_pgp_cipher_context): cleaned up
	unref casts.

	* mail-display.c (write_data_to_file): gnome->gtkdialog.
	(on_link_clicked): use ascii_str*cmp on url.
	(save_part): g_path stuff.
	(launch_cb): gtk dialog.
	(pixmap_press): de-oafify.
	(pixbuf_for_mime_type): gnome-vfs api changes.
	(do_attachment_header): Change the pixmap to a gtkimage.
	(do_signature): "
	(pixbuf_gen_idle): "
	(do_attachment_header): ascii_str*cmp
	(do_attachment_header): gnome pixmap->gtkimage.
	(mail_display_destroy): protect against gtk mentalness.
	(html_button_press_event): ascii_str*cmp
	(drag_data_get_cb): added comment for translators of filename.

	* mail-format.c (component_supports): de-oafise.
	(is_anonymous): ascii_strncmp
	(attachment_header): remove utf8<>locale stuff, and gnomevfs api
	changes.
	(format_mime_part): fix g_strdown call.
	(write_field_row_begin): kill utf8->gtk stuff.
	(write_address): "
	(default_header_index): ascii_strcasecmp
	(handle_text_plain): "
	(handle_text_enriched): "
	(handle_multipart_encrypted): remove utf/gtk stuff.
	(handle_message_external_body): ascii_str*cmp

	* mail-identify.c (mail_identify_mime_part):
	(identify_by_magic): gnome vfs api changes.

	* mail-importer.c: Converted.

	* mail-local.c (load_metainfo): xml childs -> children.
	(mls_get_folder): g_strerror.
	(mls_delete_folder): g_strerror.
	(reconfigure_got_folder): Gnome->GtkDialog
	(reconfigure_response): from reconfigure_clicked.

	* mail-mt.c (mail_msg_check_error): gnome -> gtk dialog
	(error_response): renmae from error_gone.  destroy widget on any
	response.

	* mail-offline-handler.c (impl_finalise): renamed from
	impl_destroy since thats what it should be anyway.

	* mail-ops.c: removed utf8 widget conversion & camel_object_un/ref
	casts.

	* mail-preferences.c (mail_preferences_get_type): glib2'ised.

	* mail-search.c (mail_search_finalise): renmaed from destroy &
	properly chain.
	(mail_search_get_type): glib2 & make gtkdialog parent.
	(entry_run_search): run search when entry activated.  not sure if
	gtkdialog has anohter way to do this on an arbitrary widget.

	* mail-send-recv.c (dialogue_response): renamed from clicked.  Use
	gtkdialog.

	* mail-session.c (request_password_deleted): removed, redundant.
	(pass_response): rename from pass_got, changed for gtkdialog.
	(user_message_destroy): Removed, redundant.
	(user_message_response): Renamed from user_message_clicked.

2002-11-11  Not Zed  <NotZed@Ximian.com>

	* mail-stream-gtkhtml.c (mail_stream_gtkhtml_class_init): dont use
	get_global_classfuncs, just get the type

	* mail-tools.c: converted gnome2 api's.

	* mail-vfolder.c (vfolder_editor_response): clicked->response.
	(vfolder_editor_destroy): Removed.
	(vfolder_edit): gtk dialog api
	(edit_rule_response): clicked->response.
	(vfolder_edit_rule): gnomedialog->gtkdialog.
	(vfolder_gui_add_rule): "
	(new_rule_clicked): clicked->response

svn path=/trunk/; revision=18723
2002-11-12 14:59:35 +00:00
abafd9de4f Unref the driver before returning to main thread, so any closing
2002-08-06  Not Zed  <NotZed@Ximian.com>

        * mail-ops.c (filter_folder_filter): Unref the driver before
        returning to main thread, so any closing operations are handled
        async (as in fetch_mail_fetch()), for #28072.

        ** fixes for #24605.

        * mail-vfolder.c (vfolder_gui_add_from_mlist): Removed.

        * folder-browser.c (filter_type_uid,vfolder_type_uid): Changed to
        accept args directly.  Fixed callers.
        (filter_mlist_uid,vfolder_mlist_uid): Use filter_type_uid instead
        of mlist variant.
        (vfolder_type_current): new function to handle setup of vfolders
        from the main menu.  It now uses the vfolder_type_uid function the
        same as the popup.
        (vfolder_subject, vfolder_sender, vfolder_recipient,
        vfolder_mlist): Changed to use vfolder_type_current.
        (filter_type_current): Similar for filters.
        (filter_subject, filter_sender, filter_recipient,
        filter_mlist): Changed to use filter_type_current.

        * mail-autofilter.c (rule_from_message): Handle AUTO_MLIST type.
        (rule_from_mlist):
        (vfolder_rule_from_mlist):
        (filter_rule_from_mlist): Removed.
        (filter_gui_add_from_mlist): Removed.

        * mail-autofilter.h: Added AUTO_MLIST type.

svn path=/trunk/; revision=17704
2002-08-06 02:45:07 +00:00