Commit Graph

2811 Commits

Author SHA1 Message Date
b851882164 Use g_ptr_array_sized_new() rather than using set_size() after creating a
2004-08-13  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-summary.c (imap4_summary_fetch_all):
	Use g_ptr_array_sized_new() rather than using set_size() after
	creating a GPtrArray so that array->len starts out at 0.
	(imap4_summary_fetch_flags): Same.

svn path=/trunk/; revision=26923
2004-08-13 18:13:02 +00:00
20618e52c5 Use g_ptr_array_sized_new() rather than using set_size() after creating a
2004-08-13  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-summary.c (imap4_summary_fetch_all):
	Use g_ptr_array_sized_new() rather than using set_size() after
	creating a GPtrArray so that array->len starts out at 0.
	(imap4_summary_fetch_flags): Same.

svn path=/trunk/; revision=26922
2004-08-13 18:12:49 +00:00
37646eb1f9 remove the cal/taksks sources when account is disbaled. Also do not try to
2004-08-13  Sivaiah Nallagatla <snallagatla@novell.com>

       * providers/groupwise/camel-gw-listener.c (account_changed):
       remove the cal/taksks sources when account is disbaled. Also
       do not try to to create sources when a disabled account is changed to
       Novell Groupwise
       (camel_gw_listener_construct) : do not add the disbaled
       accounts to exitsting groupwise accounts list

svn path=/trunk/; revision=26920
2004-08-13 16:35:25 +00:00
4ff1e84802 update ssl setting label and title of the soap settings section Fixes
2004-08-13  Sivaiah Nallagatla <snallagatla@novell.com>

       * providers/groupwise/camel-groupwise-provider.c : update
       ssl setting label and title of the soap settings section
       Fixes #62747

svn path=/trunk/; revision=26918
2004-08-13 16:11:15 +00:00
ed76fc7724 Handle et/comm_err.h as well as the normal comm_err.h
2004-08-13  Rodney Dawes  <dobey@novell.com>

	* camel-sasl-gssapi.c: Handle et/comm_err.h as well as the
	normal comm_err.h

svn path=/trunk/; revision=26911
2004-08-13 14:39:19 +00:00
f9394de34e added a comment
svn path=/trunk/; revision=26898
2004-08-12 21:01:36 +00:00
5e090dfdc0 use g_string_append_len when appending a subset of a string rather than g_string_append, duh.
svn path=/trunk/; revision=26890
2004-08-12 20:20:19 +00:00
b58176fd48 Fix for bug #62771
2004-08-11  Jeffrey Stedfast  <fejj@novell.com>

	Fix for bug #62771

	* camel-mime-utils.c (append_quoted_pair): New function to append
	a string of text that may contain quoted-pairs.
	(header_decode_text): Now takes a ctext argument specifying
	whether or not to expect comments and to handle them.
	(camel_header_decode_string): Pass FALSE as ctext argument.
	(camel_header_format_ctext): New function to format text|comment
	header field bodies.

svn path=/trunk/; revision=26888
2004-08-12 16:33:25 +00:00
5c8d34f45e fix for e_passwords api change, and handle reprompting as well.
2004-08-10  Not Zed  <NotZed@Ximian.com>

        * providers/groupwise/camel-gw-listener.c
        (get_addressbook_names_from_server): fix for e_passwords api
        change, and handle reprompting as well.

svn path=/trunk/; revision=26879
2004-08-12 06:53:28 +00:00
d1ed7c7084 Call camel_operation_progress(). (imap4_summary_fetch_all): Setup info we
2004-08-06  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-summary.c (untagged_fetch_all): Call
	camel_operation_progress().
	(imap4_summary_fetch_all): Setup info we need for progress
	reporting.
	(imap4_summary_fetch_flags): Same.

svn path=/trunk/; revision=26846
2004-08-06 19:24:04 +00:00
7962318648 In the case of start() or end() failing, loop starting with the first
2004-08-03  Jeffrey Stedfast  <fejj@novell.com>

	* camel-url-scanner.c (camel_url_scanner_scan): In the case of
	start() or end() failing, loop starting with the first character
	immediately following the failed match position. Fixes bug #62136.

svn path=/trunk/; revision=26831
2004-08-05 17:38:05 +00:00
29adbe584e #include <gal/util/e-iconv.h>
2004-08-04  Rodney Dawes  <dobey@novell.com>

	* camel-charset-map.c: #include <gal/util/e-iconv.h>

svn path=/trunk/; revision=26821
2004-08-04 15:22:06 +00:00
fa86654782 Pass a reconnect func.
2004-08-03  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-store.c (imap4_construct): Pass a
	reconnect func.

	* providers/imap4/camel-imap4-engine.c
	(camel_imap4_engine_iterate): Reconnect if needed.
	(camel_imap4_engine_new): Now takes a reconnect func.

svn path=/trunk/; revision=26813
2004-08-03 16:31:47 +00:00
5b7760d260 This needs to prequeue the CAPABILITY command rather than queue it
2004-07-30  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-engine.c
	(camel_imap4_engine_capability): This needs to prequeue the
	CAPABILITY command rather than queue it normally for the case of
	reconnecting.
	(camel_imap4_engine_namespace): Same.

svn path=/trunk/; revision=26781
2004-07-30 21:02:19 +00:00
25fc2454a2 fixed sed-o's (s/IMAP44/IMAP4/g)
svn path=/trunk/; revision=26780
2004-07-30 18:49:58 +00:00
986136ecf9 bleh
svn path=/trunk/; revision=26779
2004-07-30 18:19:14 +00:00
a07cfcb2bd Similar fix as below in a later if-statement. Thanks to Suresh for
2004-07-30  Jeffrey Stedfast  <fejj@ximian.com>

	* camel-mime-utils.c (camel_header_encode_string): Similar fix as
	below in a later if-statement. Thanks to Suresh for spotting this
	one.

svn path=/trunk/; revision=26776
2004-07-30 15:30:38 +00:00
b99bbc4232 Fixed an ABR that may have been responsible for bug #62029.
2004-07-28  Jeffrey Stedfast  <fejj@novell.com>

	* camel-mime-utils.c (camel_header_encode_string): Fixed an ABR
	that may have been responsible for bug #62029.

svn path=/trunk/; revision=26769
2004-07-29 14:24:10 +00:00
bbfd4edac1 Add an entry to specify POA address and a check box to say whehter ssl has
2004-07-29 Sivaiah Nallagatla <snallagatla@novell.com>

        * proivders/groupwise/camel-groupwise-provider.c :
        Add an entry to specify POA address and a check box to
        say whehter ssl has to be used for SOAP or not
        (groupwise_auto_detect_cb) : new function to
        automatically fill POA address with host specified in receiving mail page
        (camel_provider_module_init) : use the new auto_detect funcntion

        * providers/groupwise/camel-gw-listener.c (modify_esource)
        (account_changed) (add_calendar_tasks_sources)
        (remove_calendar_tasks_sources) (get_addressbook_names_from_server)
        (add_addressbook_sources) (modify_addressbook_sources)
        (remove_addressbook_sources) : while forming the uri, use the value
        from new poa_address setting instead of url->host. Also use ssl
        setting from the new check box provider instaed of imap one

        (get_addressbook_names_from_server) : display an error to user
        when connection cpuld not be established with server during account setup

svn path=/trunk/; revision=26765
2004-07-29 06:46:26 +00:00
6551a127b3 Changed the logic slightly to only match certain charsets if the locale
2004-07-26  Jeffrey Stedfast  <fejj@novell.com>

	* camel-charset-map.c (camel_charset_best_mask): Changed the logic
	slightly to only match certain charsets if the locale matches
	(Macedonians don't want to use koi8-r for example).

svn path=/trunk/; revision=26758
2004-07-28 16:44:08 +00:00
d2e789798e ** See bug #61841.
2004-07-27  Not Zed  <NotZed@Ximian.com>

        ** See bug #61841.

        * providers/groupwise/camel-groupwise-provider.c: added junk settings.

svn path=/trunk/; revision=26752
2004-07-28 06:57:08 +00:00
7fcf69af0f Changed to be the same prototype as engine_queue().
2004-07-27  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-engine.c
	(camel_imap4_engine_prequeue): Changed to be the same prototype as
	engine_queue().
	(engine_prequeue_folder_select): Updated.

	* providers/imap4/camel-imap4-store.c (connect_to_server): Use
	engine_prequeue() for STARTTLS in case we are reconnecting and
	already have a command queue.
	(imap4_try_authenticate): Use prequeue() here too.
	(imap4_reconnect): Moved all the connect logic in here.
	(imap4_connect): just lock and call reconnect().

svn path=/trunk/; revision=26748
2004-07-27 19:38:51 +00:00
3aff7416c1 do not set transport object for groupwise provider. We want user to use
2004-07-27  Sivaiah Nallagatla <snallagatla@novell.com>

       * providers/groupwise/camel-groupwise-provider.c
       (camel_provider_module_init) : do not set
       transport object for groupwise provider. We want user to
       use SMTP itself instead of "Novell Groupwise"

       Fixes #61454

svn path=/trunk/; revision=26744
2004-07-27 15:37:22 +00:00
8cfdad88c9 Don't instantiate an engine here. Instead, take an engine as an argument
2004-07-26  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-store.c (connect_to_server): Don't
	instantiate an engine here. Instead, take an engine as an argument
	(it has a service pointer) and connect using that. Also, if
	connect fails, don't unref the engine.
	(connect_to_server_wrapper): Now also takes an engine argument
	rather than a service argument.
	(imap4_try_authenticate): Now also takes an engine argument.
	(imap4_connect): Pass the engine to connect/auth functions rather
	than the store.
	(imap4_query_auth_types): Updated.
	(imap4_disconnect): Don't unref the engine here.
	(camel_imap4_store_init): Create the engine here.
	(imap4_get_folder_info): Can't check engine == NULL to know to
	connect (that was a broken check anyway).

	* providers/imap4/camel-imap4-engine.c (camel_imap4_engine_new):
	Now simply takes a service argument rather than a session and url.
	(camel_imap4_engine_next_token): Set the state to DISCONNECTED.
	(camel_imap4_engine_eat_line): Same.
	(camel_imap4_engine_line): Same.
	(camel_imap4_engine_literal): Same.

svn path=/trunk/; revision=26740
2004-07-26 21:24:20 +00:00
b06ecefc61 ** See bug #61761.
2004-07-22  Not Zed  <NotZed@Ximian.com>

        ** See bug #61761.

        * providers/pop3/camel-pop3-engine.c (camel_pop3_engine_iterate):
        if we get an io error, move every current/active and queued
        command to the done queue and mark as failed.

svn path=/trunk/; revision=26709
2004-07-23 03:37:33 +00:00
c1a82b06e7 Free result after parsing it. Fixes a leak.
2004-07-19  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap/camel-imap-store.c (get_subscribed_folders): Free
	result after parsing it. Fixes a leak.

svn path=/trunk/; revision=26689
2004-07-21 15:55:00 +00:00
a0045571d2 only copy 5 chars after the F if we actually have "From ", otherwise we
2004-07-19  Not Zed  <NotZed@Ximian.com>

        * camel-mime-filter-canon.c (filter): only copy 5 chars after the
        F if we actually have "From ", otherwise we might have F.{,4}\n
        instead and break eol canonicalisation.  For #53355.

svn path=/trunk/; revision=26679
2004-07-20 03:28:05 +00:00
25e8440cb7 Added some debug stuff.
2004-07-16  Not Zed  <NotZed@Ximian.com>

        * camel-gpg-context.c: Added some debug stuff.

svn path=/trunk/; revision=26672
2004-07-19 02:11:31 +00:00
1db91f63b8 Don't grab the connect_lock before calling refresh_info so that we avoid
2004-07-15  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap/camel-imap-folder.c (imap_transfer_online): Don't
	grab the connect_lock before calling refresh_info so that we avoid
	the deadlock in bug #61551.

svn path=/trunk/; revision=26668
2004-07-16 17:11:11 +00:00
6891ddd74e Fix for bug #61538
2004-07-14  Jeffrey Stedfast  <fejj@novell.com>

	Fix for bug #61538

	* camel-process.c (camel_process_fork): Same.

	* camel-filter-driver.c (pipe_to_system): Fixed strings

svn path=/trunk/; revision=26652
2004-07-14 19:00:37 +00:00
b26eba17f1 fixed all the way
svn path=/trunk/; revision=26651
2004-07-14 18:33:21 +00:00
dff192490c fixed changelog
svn path=/trunk/; revision=26650
2004-07-14 18:32:13 +00:00
d035c5539b : pass "use_ssl" value to these functions and set it on e-source
2004-07-12 Sivaiah Nallagatla <snallagatla@novell.com>

        * providers/groupwise/camel-gw-listener.c : (add_esource)
        (modify_esource) (add_addressbook_source)
        (modify_addressbook_sources) : pass "use_ssl" value to these functions and
        set it on e-source
        (add_calendar_tasks_source) : read the "use_ssl" param
        from camel url and pass it to add_esource) calls
        (get_addressbook_names_from_server) : use "https" or http
        depending upon whther ssl is enabled or not
        (account_changed) : compare urls from account
        instead of uris formed to know wheter somehting in the account
        changed

svn path=/trunk/; revision=26631
2004-07-13 07:35:53 +00:00
0a3341dda8 ** This is no guarantee of security, but its just a helper to prevent old
2004-07-09  Not Zed  <NotZed@Ximian.com>

        ** This is no guarantee of security, but its just a helper to
        prevent old memory accidentally being included/used elsewhere.

        * camel-smime-context.c (sm_decrypt): mark the output stream
        'secure'.

        * camel-gpg-context.c (gpg_decrypt): set the output stream to
        secured, so we automagically blank it out on finalise.

        * camel-stream-mem.c (camel_stream_mem_set_secure): set the
        memory-stream 'secured', all we do at the moment is blank out the
        buffer on finalise.
        (camel_stream_mem_set_byte_array, camel_stream_mem_finalize):
        clear memory if owner and secured.  kill dead comment.
        (clear_mem): utilitiy to set memory to 0xABADF00D

2004-07-08  Not Zed  <NotZed@Ximian.com>

        ** See bug #61186.

        * camel-cipher-context.c (camel_cipher_sign):
        (camel_cipher_verify, camel_cipher_encrypt, camel_cipher_decrypt):
        Add preliminary progress reporting.

svn path=/trunk/; revision=26629
2004-07-13 04:05:10 +00:00
87b7542305 use CAMEL_GROUPWISE_CFLAGS. (libcamelgroupwise_la_LIBADD): use
2004-07-07  Chris Toshok  <toshok@ximian.com>

	* providers/groupwise/Makefile.am (INCLUDES): use
	CAMEL_GROUPWISE_CFLAGS.
	(libcamelgroupwise_la_LIBADD): use CAMEL_GROUPWISE_LIBS.

svn path=/trunk/; revision=26598
2004-07-08 19:53:01 +00:00
24b931b213 s/Can't/Cannot/.
2004-07-02  Christian Neumair  <chris@gnome-de.org>

	* camel-smime-context.c: s/Can't/Cannot/.

svn path=/trunk/; revision=26560
2004-07-02 12:19:34 +00:00
c9715f0a81 Set the size of the ptrarray to prevent potentially realloc'ing several
2004-06-30  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-search.c (imap4_body_contains): Set
	the size of the ptrarray to prevent potentially realloc'ing
	several times.

svn path=/trunk/; revision=26555
2004-06-30 19:55:29 +00:00
7f4c97c904 Aded a new %formatter 'V' which takes a string vector (needed for SEARCH).
2004-06-29  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-command.c
	(camel_imap4_command_newv): Aded a new %formatter 'V' which takes
	a string vector (needed for SEARCH).

	* providers/imap4/camel-imap4-search.[c,h]: New source files
	implementing search functionality.

	* providers/imap4/camel-imap4-folder.c (imap4_sync_flag): Use the
	new public version of imap4_get_uid_set().
	(imap4_transfer_messages_to): Same.
	(camel_imap4_folder_new): Create a search context.
	(camel_imap4_folder_finalize): Unref the search context.
	(camel_imap4_folder_class_init): Override the search methods.
	(imap4_search_by_expression): New.
	(imap4_search_by_uids): New.
	(imap4_search_free): New.

	* providers/imap4/camel-imap4-utils.c (camel_imap4_get_uid_set):
	Moved here from camel-imap4-folder.c

svn path=/trunk/; revision=26551
2004-06-29 21:22:09 +00:00
be9d78b480 add any parents of the new name before we actually do the rename so the
2004-06-29  Not Zed  <NotZed@Ximian.com>

        * camel-vee-store.c (vee_rename_folder): add any parents of the
        new name before we actually do the rename so the rename has
        somewhere to go to.  #60775.

svn path=/trunk/; revision=26546
2004-06-29 10:05:21 +00:00
c096dca1ea override CAMEL_FOLDER_NAME arg so we can translate "." into "Inbox".
2004-06-28  Not Zed  <NotZed@Ximian.com>

        * providers/local/camel-maildir-folder.c (maildir_folder_getv):
        override CAMEL_FOLDER_NAME arg so we can translate "." into
        "Inbox".

svn path=/trunk/; revision=26538
2004-06-28 08:36:29 +00:00
218b162a5d take url argument directly, fixes a memleak. (camel_folder_info_new): make
2004-06-28  Not Zed  <NotZed@Ximian.com>

        * providers/local/camel-maildir-store.c (camel_folder_info_new):
        take url argument directly, fixes a memleak.
        (camel_folder_info_new): make the toplevel "." into "Inbox"
        always.
        (maildir_rename_folder): dont let users rename inbox.

svn path=/trunk/; revision=26537
2004-06-28 06:59:38 +00:00
90d63d2b2a More fixes.
2004-06-27  Jeffrey Stedfast  <fejj@novell.com>

	* camel-url-scanner.c (camel_url_web_end): More fixes.

svn path=/trunk/; revision=26532
2004-06-28 00:18:20 +00:00
497bf57430 remove more debugging printfs
svn path=/trunk/; revision=26525
2004-06-25 19:22:56 +00:00
c04a0ac796 fixed an uninitialised memory read from my last fix
svn path=/trunk/; revision=26524
2004-06-25 19:06:25 +00:00
46d1d136e7 Fixed to handle :pass in proto://user:pass@host. Fixes bug #60104.
2004-06-25  Jeffrey Stedfast  <fejj@novell.com>

	* camel-url-scanner.c (camel_url_web_end): Fixed to handle :pass
	in proto://user:pass@host. Fixes bug #60104.

svn path=/trunk/; revision=26514
2004-06-25 15:09:21 +00:00
0ef312f45d Error out and set an exception if camel_pop3_engine_new() returns NULL
2004-06-24  Jeffrey Stedfast  <fejj@novell.com>

	* providers/pop3/camel-pop3-store.c (connect_to_server): Error out
	and set an exception if camel_pop3_engine_new() returns NULL
	(which it can do now).

	* providers/pop3/camel-pop3-engine.c (get_capabilities): No longer
	reads the greeting.
	(camel_pop3_engine_new): Reads the greeting itself and returns
	NULL if an error occurs (like stupid braindamaged piece of shit
	POP servers that spew debug prinfs).

svn path=/trunk/; revision=26504
2004-06-24 21:49:41 +00:00
4633426c1b If we fail to lock the folder, close the lockfd and reset it to -1. Fixes
2004-06-24  Jeffrey Stedfast  <fejj@novell.com>

	* providers/local/camel-spool-folder.c (spool_lock): If we fail to
	lock the folder, close the lockfd and reset it to -1. Fixes bug
	#54680.

svn path=/trunk/; revision=26499
2004-06-24 17:44:13 +00:00
ed34d79a98 First LIST/LSUB the toplevel folder, and then LIST/LSUB the subfolders (it
2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-store.c (imap4_get_folder_info):
	First LIST/LSUB the toplevel folder, and then LIST/LSUB the
	subfolders (it needs to be 2 commands to work properly).
	(imap4_delete_folder): CLOSE the folder we are about to DELETE if
	it is currently SELECTED.

svn path=/trunk/; revision=26489
2004-06-24 03:52:13 +00:00
758f7345f5 Same.
2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap/camel-imap-provider.c (imap_url_equal): Same.

	* providers/imap4/camel-imap4-provider.c (imap4_url_equal): Check
	the protocol.

svn path=/trunk/; revision=26488
2004-06-24 03:01:42 +00:00
eb44d99148 Hide password, etc info in the fi->uri's. (imap4_create_folder): Don't
2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

	* providers/imap4/camel-imap4-store.c (imap4_build_folder_info):
	Hide password, etc info in the fi->uri's.
	(imap4_create_folder): Don't bother to use
	imap4_get_folder_info(), we can construct the fi ourselves.
	(imap4_delete_folder): Emit the folder_deleted signal and
	construct an fi ourselves.
	(imap4_subscribe_folder): Same.
	(imap4_unsubscribe_folder): Same.

	* providers/imap4/camel-imap4-provider.c: Specify that the
	fragment is the path.

svn path=/trunk/; revision=26483
2004-06-23 20:26:56 +00:00