Commit Graph

341 Commits

Author SHA1 Message Date
9692758dc5 EMFolderTree: Store an EMailBackend instead of an EMailSession.
All this so EMFolderTree can submit EActivity instances for async ops.
You can obtain an EMailSession from an EMailBackend, but not vice versa.

Creates lots of pretty ripples in the mail code, but ultimately reduces
complexity.  So it's a code cleanup of sorts.
2011-05-23 21:50:50 -04:00
cb97c2dc8f Coding style and whitespace cleanup. 2011-05-21 17:56:06 -04:00
9aa668aa6b Bug 650587 - Hide Search Folder actions when Search Folders are disabled
Add an action group for Search Folders to EMailReader.  The action
group's visibility is bound to the "mail-enable-search-folders" setting,
so that menu items related to Search Folders are hidden when Search
Folders are disabled in GConf.

Affected menu items are:

   Edit -> Search Folders
   Message -> Create Rule -> Search Folder from Subject...
   Message -> Create Rule -> Search Folder from Sender...
   Message -> Create Rule -> Search Folder from Recipients...
   Message -> Create Rule -> Search Folder from Mailing List...
   Search -> Create Search Folder From Search...
2011-05-20 19:05:55 -04:00
7333f12087 EMailReader: Support multiple action groups.
Use an enum type to request different action groups.  For now we just
have E_MAIL_READER_ACTION_GROUP_STANDARD.  EMailReader implementations
should map the enum value to an appropriate GtkActionGroup.
2011-05-20 19:05:55 -04:00
86c9c4d793 Remove mail_remove_folder().
Use e_mail_folder_remove() instead.
2011-05-20 13:14:53 -04:00
b3b917365f Remove mail_store_prepare_offline().
Use e_mail_store_prepare_for_offline() instead.
2011-05-17 19:51:11 -04:00
766c0b0b55 Bug 650088 - Cannot send message from Contacts view
This starts up the EMailShellBackend whenever a new composer window is
created.  Normally this happens when switching to the Mail shell view,
but if trying to send a message from a different shell view before the
Mail shell view is ever activated, the mail accounts were not getting
loaded and sending or saving the message to a mail folder would fail.
2011-05-16 14:19:16 -04:00
d20e186ce7 Bug #601541 - Add 'Copy Image' Option On Inline Email Images 2011-05-16 13:21:22 +02:00
c5765a097f GN-bug #649935 - Check folder validity before asking for its URI 2011-05-13 14:05:11 +02:00
7af2865b7f EMailShellView: Remove some unused utility functions.
I guess I meant to move these to EMailReader but forgot to delete the
original versions.
2011-05-12 19:31:35 -04:00
e270dfde64 Keep forgetting to add prefixes to EAlert tags. 2011-05-12 19:26:34 -04:00
b663d51f1b Miscellaneous cleanups. 2011-05-12 19:00:09 -04:00
6ae1b3fe3c em_utils_reply_to_message(): Require a CamelMimeMessage.
No more fetching a message itself.  Oh, and stop unreffing the message.
Those kinds of insane semantics are what lead to crashes.
2011-05-12 18:24:42 -04:00
366dacefa0 Add e_mail_reader_new_activity().
Configuring and submitting an EActivity for every mail operation is
getting tedious.  This function helps reduce boilerplate code by:

  * Creating a new EActivity instance.

  * Installing an EAlertSink using e_mail_reader_get_alert_sink().

  * Installing a GCancellable (which is really a CamelOperation).

  * Submitting the activity via e_shell_backend_add_activity().

I'm considering adding a similar function (or class method) for
EShellView.  Not sure yet...
2011-05-12 18:24:41 -04:00
1c68dd8339 Reimplement em_folder_properties_show().
Now uses camel_store_get_folder() and camel_folder_get_quota_info(),
although I need to rewrite the quota function to be asynchronous.
2011-05-12 00:45:47 -04:00
ba8f1f78f4 Add e_activity_handle_cancellation().
Convenience function for use in GAsyncReadyCallback functions.

This acknowledges the cancellation, so that the activity's description
changes from "(cancelling)" to "(cancelled)" and the description appears
crossed out in the UI for a moment before disappearing.
2011-05-11 12:59:29 -04:00
e5760e065f Reimplement em_utils_forward_messages().
Now uses e_mail_folder_build_attachment() and
e_mail_folder_get_multiple_messages().
2011-05-11 12:58:53 -04:00
8a186c3588 Coding style cleanups. 2011-05-08 13:37:20 -04:00
4cfb84c573 Whitespace and coding style cleanups. 2011-05-07 18:48:38 -04:00
c7b455de89 Adapt to CamelFolder:name -> display-name. 2011-05-07 11:15:51 -04:00
6d44258b85 em_folder_utils_create_folder(): Change function parameters.
Take a folder URI string instead of a CamelFolderInfo, and swap places
with the GtkWindow parameter.
2011-05-06 12:34:33 -04:00
308f972f08 em_folder_utils_copy_folder(): Change function parameter.
Take a folder URI string instead of a CamelFolderInfo.
2011-05-06 12:23:21 -04:00
974924a8b8 Drop support for command-line 'email://' URIs.
I have no idea what this was used for, but it looks way too convoluted
to be useful anymore.
2011-05-05 15:20:22 -04:00
a9c9f0be5f Remove e_mail_reader_get_folder_uri().
Instead call e_mail_reader_get_folder() and, if you really need to,
generate the folder URI with e_mail_folder_uri_from_folder().
2011-05-03 14:42:29 -04:00
06411bdbbb Remove 'from_uri' params from e-msg-composer-utils.c.
Pass CamelFolder objects instead, which are already available at almost
every call site.
2011-05-03 13:42:15 -04:00
b8a932ae1e Fix compiler warnings.
Mostly dead assignments.
2011-05-03 10:45:46 -04:00
c3b983d6e1 Drop 'folder_uri' param from em_utils_folder_is_outbox(). 2011-05-03 09:42:06 -04:00
b9f932b1b8 Drop 'folder_uri' param from em_utils_folder_is_sent(). 2011-05-03 09:42:06 -04:00
9e0f0f529f Drop 'folder_uri' param from em_utils_folder_is_drafts(). 2011-05-03 09:42:06 -04:00
ae28ea4621 EMailShellView: Open the selected folder ourselves.
This one's a little involved:

 - EMailShellView now obtains a CamelFolder itself in response to
   EMFolderTree::folder-selected signals.  Uses EActivity to do so.

 - Revise EMFolderTree::folder-selected signal arguments to be more
   useful: emit a CamelStore object instead of a folder URI.

 - Also revise EMFolderTree::folder-activiated signal arguments the
   same way while we're at it.

 - Remove the "folder_uri" argument from e_mail_reader_set_folder().
   If you have a CamelFolder object you can obtain the URI string by
   calling camel_folder_get_uri().
2011-05-02 21:01:48 -04:00
52844f40f1 Add em_folder_tree_get_selected_account().
Comes in handy for a few EMailShellView actions.
2011-05-02 19:07:06 -04:00
d21199c919 Bug #588891 - Spam settings dialog terribly un-higgy 2011-04-29 09:21:58 +02:00
7a61438713 Bug #303653 - Make headers collapsable in preview pane 2011-04-27 17:42:49 +02:00
397aeade05 Adapt to CamelService changes. 2011-04-21 07:45:45 -04:00
e3686d088b Kill em_composer_prefs_new_signature().
No longer used.
2011-04-14 19:02:22 -04:00
63c26d5712 Miscellaneous GtkAction-related cleanups.
Prefer the newer GtkAction "set" functions over g_object_set().
2011-03-27 18:38:39 -04:00
ba6a234386 Restore lockdown integration.
With lockdown settings available through GSettings, widgets can handle
lockdown integration themselves without having to use EShellSettings.

Also fixed a few places where printing or save-to-disk actions were
either not properly wired up or not responding to lockdown settings,
but much more work needs done.  Attachments, for example, are not
honoring the disable-save-to-disk setting at all.

This too requires the recently-added gsettings-desktop-schemas
dependency.
2011-03-27 18:38:39 -04:00
cf7a5095c2 Bug 643507 - Font preferences don't work 2011-03-08 18:13:13 -05:00
c6fd77460f Coding style and whitespace cleanup. 2011-03-05 12:34:28 -05:00
29cc2891d8 Bug #642093 - Frees message attachment content on Reply 2011-03-01 15:53:15 +01:00
1301cf02ef Bug #614480 - Avoid using G_TYPE_INSTANCE_GET_PRIVATE repeatedly 2011-02-25 16:20:41 +01:00
fcb29478f6 Coding style and whitespace cleanup. 2011-02-18 20:44:24 -05:00
94e43758de Bug #638333 - Critical warning when invoking File->New->Mail Folder 2011-02-16 13:14:49 +01:00
1afbba4a8b Bug 642171 - Implicit libgnome dependency for lockdown GConf keys
Lockdown keys have moved to gsettings-desktop-schemas, so disable
lockdown integration until we're ready for GSettings.
2011-02-12 13:40:33 -05:00
7a1677520d Remove NULL checks for GObject methods.
As of GLib 2.28 all GObject virtual methods, including constructed(),
are safe to chain up to unconditionally.  Remove unnecessary checks.
2011-02-12 12:54:08 -05:00
2c31a5bc23 Bug 641756 - Fix warnings from GCC 4.6
GCC learned how to find dead assignments.
2011-02-08 11:57:50 -05:00
0109aa3a92 More whitespace cleanup. 2011-01-30 11:33:28 -05:00
21ab8044da Coding style and whitespace cleanup. 2011-01-29 20:22:57 -05:00
b7c2f49973 Adapt size_request vfuncs to latest gtk+-3.0 API. 2011-01-25 10:37:16 -05:00
adc0e71ea6 Adapt to GtkComboBox class reorg. 2011-01-25 10:37:10 -05:00