2001-12-18 Damon Chaplin <damon@ximian.com>
* src/libical/icalyacc.y: removed unused 'trigger:' production.
* configure.in (AC_OUTPUT): patch from Jeremy Katz <katzj@redhat.com>
to remove src/libicalss/Makefile and src/libicalvcal/Makefile, as we
don't ship those directories now.
svn path=/trunk/; revision=15152
2001-12-10 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_display_name): if all
we have is the TZID, see if it is one of our TZIDs and if so get the
city name out of it. Fixes bug #16571.
svn path=/trunk/; revision=14957
2001-11-13 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_tzid): initialize the
builtin timezones, to ensure that the TZID of the UTC zone is set.
Hopefully fixes bugs #14941 & #14622.
svn path=/trunk/; revision=14689
2001-10-31 Damon Chaplin <damon@ximian.com>
* src/libical/icalproperty.c (get_next_line_start): use MAX_LINE_LEN
rather than magic numbers all over the place.
svn path=/trunk/; revision=14536
2001-10-31 Damon Chaplin <damon@ximian.com>
* src/libical/icalproperty.c (icalproperty_as_ical_string): had to
redo the folding code since Outlook 2000 doesn't like parameter values
like 'TENTATIVE' cut in half. Now it tries to split after a ';', ':'
or space.
svn path=/trunk/; revision=14529
2001-10-30 Damon Chaplin <damon@ximian.com>
* src/libical/icalproperty.c (fold_property_line): forgot to account
for the spaces added, so it could have been writing over the end of
the allocated memory. Added check for buffer overflow as well.
This could well have been the problem causing bug #14067.
svn path=/trunk/; revision=14517
2001-10-30 Damon Chaplin <damon@ximian.com>
* zoneinfo/*.ics: Regenerated all VTIMEZONEs, to be compatable with
Outlook Web Access. They now only include 2 RRULEs components or
1 simple DTSTART component.
svn path=/trunk/; revision=14454
2001-10-29 Damon Chaplin <damon@ximian.com>
* src/libical/Makefile.am: renamed the library to libical-evolution.la,
install ical.h into $includedir/evolution, with the other Evo headers.
* src/libical/icalproperty.c (fold_property_line): new function to
fold property lines around every 70 characters. Outlook Web Access
doesn't seem to like some properties folded after the property name
(e.g. UID, VTIMEZONE stuff.) Slight chance of data corruption here.
* src/libical/icalvalue.c (icalvalue_text_as_ical_string): don't fold
the lines here.
* src/libical/icaltime.c (icaltime_from_string): DATE values should
not have is_utc set to 1 - they don't have a timezone.
* src/libical/icalvalue.c (icalvalue_utcoffset_as_ical_string):
always round UTC offsets to the nearest minute, for compatability
with Outlook. Should round data when parsing as well.
svn path=/trunk/; revision=14396
2001-10-27 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_display_name): added
function to get a reasonable name to display for the timezone.
(Though it won't be translated.)
svn path=/trunk/; revision=14265
2001-10-25 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_tznames_from_vtimezone):
Outlooks (2000) places "Standard Time" and "Daylight Time" in the
TZNAME strings, which is useless, so return NULL in that case.
ETimezoneEntry will then use the TZID instead, in which Outlook does
place the actual timezone name. (I just hope Outlook doesn't translate
"Standard Time" to other languages, as we won't be able to fix it then)
svn path=/trunk/; revision=14107
2001-10-23 Damon Chaplin <damon@ximian.com>
* src/libical/icalrecur.c (icalrecur_two_byrule): use
sizeof(test_array) for the memset call. It was clearing 9 bytes but
the array uses shorts.
svn path=/trunk/; revision=13958
2001-10-22 Damon Chaplin <damon@ximian.com>
* zoneinfo/*: updated all files again, placing current RDATEs first,
so Outlook uses those. Also fixed a few bugs in vzic which resulted in
a few changes.
* zoneinfo/Makefile.am (DIRS): added America/North_Dakota.
2001-10-22 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_utc_offset):
(icaltimezone_get_utc_offset_of_utc_time): if we go off the start of
the changes array, return the TZOFFSETFROM of the first change.
Also changed the maximum year to 2037.
* src/libical/icaltime.c (icaltime_day_of_week):
(icaltime_start_doy_of_week):
(icaltime_week_number): init tm_hour to 12. Sometimes mktime()
adjusts the time, if that local time doesn't actually exist, leading
to the wrong day being returned. It is unlikely to adjust by 12 hours.
(icaltime_as_timet_with_zone):
(icaltime_from_timet_with_zone): change it back so it does convert
DATE values to/from the timezone. time_t values don't really go well
with DATE values, so be very careful when using them. We now assume
that the time_t points to the start of the day in the given timezone.
(We used to assume it pointed to the start of the day in UTC, but
that meant it was actually incorrect wrt the displayed calendar.)
* src/libical/icalrecur.c (expand_year_days): for FREQ=YEARLY with no
modifiers, we add one day, using the month and day from DTSTART.
(next_year): make sure we never go past 2037.
* scripts/mkderivedproperties.pl: Updated to allow DTSTART, DTEND, DUE
and RECURRENCE-ID to be set with DATE values. I think it now handles
all properties which can take DATE values, except RDATE which uses
DATE-TIME-PERIOD.
svn path=/trunk/; revision=13912
2001-09-26 Federico Mena Quintero <federico@ximian.com>
Fix the libical-related part of Ximian bug #7892.
* src/libical/icalduration.c (icaldurationtype_as_ical_string):
The correct string for zero seconds is "PT0S", not "PTS0". Also
handle "negative zero" durations.
* src/libical/icalvalue.c (icalvalue_new_from_string_with_error):
Use icalerrno to see if the duration string is invalid. We cannot
use icaldurationtype_is_null_duration() because a duration of zero
*is* valid, not an error (icalduration_type_from_string() returns
a zero duration on parse error, too).
svn path=/trunk/; revision=13172
2001-09-11 Federico Mena Quintero <federico@ximian.com>
* src/libical/icalvalue.c (icalvalue_new_from_string_with_error):
Generate an ICAL_ATTACH_VALUE value from the string.
svn path=/trunk/; revision=12769
2001-09-10 Damon Chaplin <damon@ximian.com>
* src/libical/icalcomponent.c (icalcomponent_compare_vtimezones):
strdup the result of the first call to ical_component_as_ical_string()
since the second call may free it.
Also, don't free the results of ical_component_as_ical_string() since
it is a tmp buffer which is freed elsewhere.
svn path=/trunk/; revision=12750
2001-09-10 Federico Mena Quintero <federico@ximian.com>
Replace struct icalattachtype by an opaque icalattach that is
properly reference-counted.
* src/libical/icalvalueimpl.h (struct icalattach_impl): Private
declaration for the icalattach type.
(struct icalvalue_impl): Make the v_attach field be an icalattach *.
* src/libical/icaltypes.h: Added declaration for icalattach. This
is now an opaque type; the implementation is in icalvalueimpl.h.
(struct icalattachtype): Removed.
* src/libical/icaltypes.c (icalattach_new_from_url): New function.
(icalattach_new_from_data): New function.
(icalattach_ref): New function.
(icalattach_unref): New function.
(icalattach_get_is_url): New function.
(icalattach_get_url): New function.
(icalattach_get_data): New function.
(icalattachtype_new): Removed.
(icalattachtype_free): Removed.
(icalattachtype_add_reference): Removed.
(icalattachtype_set_url): Removed.
(icalattachtype_get_url): Removed.
(icalattachtype_set_base64): Removed.
(icalattachtype_get_base64): Removed.
(icalattachtype_set_binary): Removed.
(icalattachtype_get_binary): Removed.
* src/libical/icalderivedvalue.c.in (icalvalue_new_attach): New
function; we implement it ourselves.
(icalvalue_set_attach): New function.
(icalvalue_get_attach): New function.
* src/libical/icalvalue.c (icalmemory_strdup_and_dequote): Made
static.
(icalvalue_new_clone): Clone BINARY and ATTACH values by refing
the old attach value.
(icalvalue_free): Free BINARY and ATTACH values.
(icalvalue_attach_as_ical_string): Handle the new icalattachtype.
(icalvalue_compare): Ditto.
* src/libical/Makefile.am (CLEANFILES): Added ical.h.
* design-data/*: Mark ATTACH as a custom value.
svn path=/trunk/; revision=12745
2001-09-06 Damon Chaplin <damon@ximian.com>
* src/libical/icalcomponent.c (icalcomponent_merge_vtimezone): pass
the VTIMEZONE component to icalcomponent_compare_vtimezones(), not
the icaltimezone*. Strangely we weren't getting a compiler error.
Fixes bug #5275, hopefully.
* src/libical/icaltimezone.c (icaltimezone_dump_changes): updated so
it still outputs the same format, even though the '1 Jan 0001'
component isn't included any more.
svn path=/trunk/; revision=12670
2001-08-31 Damon Chaplin <damon@ximian.com>
* zoneinfo/*: updated all of the VTIMEZONE files to try to be more
compatable with Outlook. i.e. We don't use seconds in UTC offsets,
we don't use BYMONTHDAY if we can avoid it (there are still a few uses
of this we need to fix), and we don't use years < 1600.
* src/libical/icalvalue.c (icalvalue_utcoffset_as_ical_string): if
seconds is 0 then don't output it. None of the builtin VTIMEZONE data
uses the seconds value any more, since it messes up iTIP with Outlook.
We may want to make it always round to the nearest minute, to avoid
interop problems.
svn path=/trunk/; revision=12551
2001-08-16 Federico Mena Quintero <federico@ximian.com>
* src/libical/icalvalue.c (icalmemory_strdup_and_dequote): Dequote
the same characters that we know how to quote in
icalvalue_text_as_ical_string(). Fixes Ximian bug #7433.
svn path=/trunk/; revision=12115
2001-07-30 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_builtin_timezone):
changed the debugging message to avoid a crash on non-glibc boxes.
(Using %s with a NULL argument will crash them.)
svn path=/trunk/; revision=11492
2001-07-30 Damon Chaplin <damon@ximian.com>
* src/libical/icalcomponent.c (icalcomponent_merge_vtimezone): copy
the TZID just in case the property we got it from gets modified.
(icalcomponent_rename_tzids_callback): break out of the loop if we
have renamed the TZID parameter. Otherwise our tzid variable would be
invalid.
* scripts/mkderivedproperties.pl (fudge_data): changed this so we can
set EXDATEs that are DATE values, by checking the is_date field.
I'm not entirely sure this is the way it should be done.
If it is, I'll also do this for other things like DTSTART/DTEND.
* src/libical/icalrecur.c (icalrecurrencetype_as_string): handle
UNTIL as a DATE value as well as a DATE-TIME.
* src/libical/icalcomponent.c (icalcomponent_compare_vtimezones):
fixed stupid error, getting TZID property from wrong VTIMEZONE.
This would only have affected iTIP stuff, with VTIMEZONEs that don't
use the '/' prefix (i.e. from Outlook). It probably just meant we
kept multiple copies of the same VTIMEZONE.
* src/libical/icaltimezone.c: removed some debugging messages.
svn path=/trunk/; revision=11491
2001-07-26 JP Rosevear <jpr@ximian.com>
* src/libical/icalcomponent.c (icalcomponent_begin_component):
call pvl_next on i rather than itr.iter
svn path=/trunk/; revision=11439
2001-07-26 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_convert_time): if from_zone
is NULL (i.e. it is a floating time), just return.
svn path=/trunk/; revision=11435
2001-07-25 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c: accept an icaltimezone* of NULL for all
the public functions, since NULL is used to represent floating times.
svn path=/trunk/; revision=11413
2001-07-23 JP Rosevear <jpr@ximian.com>
* src/libical/icalparser.c: pass extra param to
icalparser_get_next_char
(icalparser_get_next_char): only use quote mode if the flag is set
svn path=/trunk/; revision=11326
2001-07-23 Damon Chaplin <damon@ximian.com>
* src/libical/icaltime.c (icaltime_day_of_year): changed so it doesn't
use mktime(). We are having problems because mktime() only works
post 1970.
svn path=/trunk/; revision=11325
2001-07-16 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_location_from_vtimezone): return NULL if we couldn't find the LOCATION.
(icaltimezone_get_utc_offset): ifdef'd out a debugging message.
(icaltimezone_get_location):
(icaltimezone_get_latitude):
(icaltimezone_get_longitude): don't load the builtin timezone for
these. We should already have the data from reading zones.tab.
(icaltimezone_get_builtin_timezone_from_tzid): return NULL if the TZID
given is NULL or "" (i.e. a floating time).
svn path=/trunk/; revision=11143
2001-07-10 Peter Williams <peterw@ximian.com>
* src/libicalss/Makefile.am (libicalss_la_SOURCES): Add the
COMBINEDHEADERS here and remove the EXTRA_DIST. This fixes distcheck.
We can't just put CONBINEDHEADERS at the bottom of _SOURCES because
of the $(srcdir).
svn path=/trunk/; revision=11040
2001-07-11 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c: only create the timezones array when we
need to, and make sure we free things when necessary.
Also added timezones_sorted variable, which we set to 0 when adding a
timezone. We then sort the array before doing binary searches (oops!)
* src/libical/icaltimezone.[hc]: added free_struct() arg to
icaltimezone_free() to specify whether to free the icaltimezone struct.
Also added icaltimezone_array_free() function.
svn path=/trunk/; revision=11026
2001-07-10 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_convert_time): don't convert
DATE values.
* src/libical/icaltime.c (icaltime_from_timet_with_zone):
(icaltime_as_timet_with_zone): changed so they do not convert DATE
values according to the timezone.
* src/libical/icaltime.[hc]: added icaltime_current_time_with_zone()
and icaltime_today() functions.
svn path=/trunk/; revision=10983
2001-07-09 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_convert_time): if the 2
zones are the same just return.
* src/libical/icaltime.c (icaltime_adjust): normalize the month.
svn path=/trunk/; revision=10944
2001-07-03 Damon Chaplin <damon@ximian.com>
* src/libical/icalcomponent.c (icalcomponent_add_component): add the
icaltimezone to the timezone array of the toplevel VCALENDAR component.
svn path=/trunk/; revision=10738
2001-07-03 Damon Chaplin <damon@ximian.com>
* src/libical/icalcomponent.c (icalcomponent_merge_component): fixed
bad assertion, '!=' -> '=='.
(icalcomponent_merge_vtimezone): get the TZID from vtimezone, not comp.
svn path=/trunk/; revision=10733
2001-06-28 Peter Williams <peterw@ximian.com>
* zoneinfo/Makefile.am (dist-hook): Add $(srcdir) as in install-data-local
rule.
svn path=/trunk/; revision=10605
2001-06-28 Damon Chaplin <damon@ximian.com>
* configure.in: commented out AC_DEFINE(ICAL_ERRORS_ARE_FATAL,1).
We only want it to abort when there is no possibility of carrying on.
svn path=/trunk/; revision=10581
2001-06-14 Damon Chaplin <damon@ximian.com>
* src/libical/icaltimezone.c (icaltimezone_get_latitude):
(icaltimezone_get_longitude): added functions to get the coords of
builtin timezones.
svn path=/trunk/; revision=10222
2001-06-13 Damon Chaplin <damon@ximian.com>
* src/libical/icalrecur.c: merged in some new stuff from libical CVS.
(icalrecur_add_byrules): If no sign is given set sign to 1 (i.e.
default to positive).
(icalrecur_iterator_new): when setting up the year days array, handle
the case where a year has no occurrences and we have to skip it.
Also initialize the last.day and last.month fields.
(expand_by_day): set the last day of the year explicitly rather than
adding 1 to year and subtracting 1 from day. It is more efficient,
and less prone to bugs. Also rewrote a bit.
(expand_year_days): added code to handle BY_MONTH_DAY and BY_DAY +
BY_MONTH_DAY, and rewrote code to handle BY_DAY + BY_MONTH.
(next_year): handled the case where there are no occurrences in the
year.
* src/libical/icaltime.c (icaltime_adjust): new function to adjust a
time by a number of days/hours/minutes/seconds.
(icaltime_day_of_week): rewrote using a single call to mktime().
(icaltime_day_of_year): rewrote using a single call to mktime().
(icaltime_from_day_of_year): rewrote in a simpler way. The old version
had a bug in it.
* src/libical/icaltime.h (struct icaltimetype): added is_daylight
flag, so we can try to distinguish between standard and daylight time
when the clocks go back. Though this doesn't always resolve the
ambiguity.
* src/libical/icalcomponent.c: added some stuff to handle timezone
data connected to the calendar component. Unfinished.
* src/libical/icalyacc.y: merged in a fix from sourceforge CVS version
of libical, so we can handle -ve UTC offsets.
* src/libical/Makefile.am (CPPFLAGS): added PACKAGE_DATA_DIR define
for finding the VTIMEZONE files.
(libical_la_SOURCES): added icalarray.[hc] and icaltimezone.[hc].
(COMBINEDHEADERS): added icalarray.h and icaltimezone.h to the headers
to be combined into ical.h.
svn path=/trunk/; revision=10220
